From: Zhang Changzhong <zhangchangzhong@huawei.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: <hauke@hauke-m.de>, <andrew@lunn.ch>, <vivien.didelot@gmail.com>,
<f.fainelli@gmail.com>, <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: dsa: lantiq_gswip: add missed clk_disable_unprepare() in gswip_gphy_fw_load()
Date: Fri, 13 Nov 2020 10:34:43 +0800 [thread overview]
Message-ID: <04b3adaa-b385-3077-84ef-e5f66f22ed9e@huawei.com> (raw)
In-Reply-To: <20201112124110.yhquvw2cptvh2oii@skbuf>
On 2020/11/12 20:41, Vladimir Oltean wrote:
>
> gswip_gphy_fw_list
> -> gswip_gphy_fw_probe
> -> gswip_gphy_fw_load
> -> clk_prepare_enable
> -> then fails
>
> Then gswip_gphy_fw_list does this:
> for_each_available_child_of_node(gphy_fw_list_np, gphy_fw_np) {
> err = gswip_gphy_fw_probe(priv, &priv->gphy_fw[i],
> gphy_fw_np, i);
> if (err)
> goto remove_gphy;
> i++;
> }
>
> return 0;
>
> remove_gphy:
> for (i = 0; i < priv->num_gphy_fw; i++)
> gswip_gphy_fw_remove(priv, &priv->gphy_fw[i]);
>
>
> Then gswip_gphy_fw_remove does this:
> gswip_gphy_fw_remove
> -> clk_disable_unprepare
>
> What's wrong with this?
> .
>
Thanks for reminding, I got it wrong.
prev parent reply other threads:[~2020-11-13 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 11:11 Zhang Changzhong
2020-11-12 12:41 ` Vladimir Oltean
2020-11-13 2:34 ` Zhang Changzhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b3adaa-b385-3077-84ef-e5f66f22ed9e@huawei.com \
--to=zhangchangzhong@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®