From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>
Cc: Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v5] checkpatch: Check for 0-length and 1-element arrays
Date: Thu, 01 Jun 2023 19:24:59 -0700 [thread overview]
Message-ID: <04c4e064a44589d39361b7c7b849ee7f41ef76b5.camel@perches.com> (raw)
In-Reply-To: <20230601151500.b9937b28946c38ef186c1ce5@linux-foundation.org>
On Thu, 2023-06-01 at 15:15 -0700, Andrew Morton wrote:
> On Thu, 1 Jun 2023 09:07:46 -0700 Kees Cook <keescook@chromium.org> wrote:
>
> > Fake flexible arrays have been deprecated since last millennium. Proper
> > C99 flexible arrays must be used throughout the kernel so
> > CONFIG_FORTIFY_SOURCE and CONFIG_UBSAN_BOUNDS can provide proper array
> > bounds checking.
> >
> > Cc: Andy Whitcroft <apw@canonical.com>
> > Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
> > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > Fixed-by: Joe Perches <joe@perches.com>
>
> You didn't checkpatch your checkpatch patch!
>
> WARNING: Non-standard signature: Fixed-by:
> #248:
> Fixed-by: Joe Perches <joe@perches.com>
>
> I'll do my usual
>
> [joe@perches.com: handle __packed for srtucts]
With that spelling?
Anyway, I went back and forth a few times with Kees
giving suggestions and corrections before sending it
on to you for more than just __packed.
I didn't (and still don't) care much about anything
other than the code.
cheers, Joe
prev parent reply other threads:[~2023-06-02 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:07 Kees Cook
2023-06-01 20:08 ` Joe Perches
2023-06-01 22:15 ` Andrew Morton
2023-06-02 2:24 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c4e064a44589d39361b7c7b849ee7f41ef76b5.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®