From: "Arnd Bergmann" <arnd@arndb.de>
To: "Mehdi Djait" <mehdi.djait@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"laurent.pinchart" <laurent.pinchart@ideasonboard.com>
Cc: "Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: Kconfig: Select COMMON_CLK for ACPI-based systems
Date: Tue, 08 Jul 2025 18:28:12 +0200 [thread overview]
Message-ID: <04c7c949-d0ac-43c0-91cb-7445cb44a036@app.fastmail.com> (raw)
In-Reply-To: <20250708161637.227111-1-mehdi.djait@linux.intel.com>
On Tue, Jul 8, 2025, at 18:16, Mehdi Djait wrote:
> ACPI-based systems are required to create and register a fixed rate clock
> using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the
> common clk framework.
>
> Ensure that COMMON_CLK is selected.
>
> Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
You should never 'select' another subsystem or a drvier from
an unrelated subsystem.
What you want here instead is 'depends on COMMON_CLK'.
Arnd
next prev parent reply other threads:[~2025-07-08 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 16:16 Mehdi Djait
2025-07-08 16:28 ` Arnd Bergmann [this message]
2025-07-09 7:48 ` Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c7c949-d0ac-43c0-91cb-7445cb44a036@app.fastmail.com \
--to=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®