From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726A5181334 for ; Tue, 14 Apr 2026 09:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776158267; cv=none; b=sBoblgQYU3Ce87S274CDjhTmTG5MZ+btabL6m0tcmaddKu/7Wzw5zpU6se4bl4f25wRzlikRJB1Lm1IHgL3CPSoY8pSDgg0eZqHp/C65Vqm4K0vKAObVo2yXq0KB4/T/IKMEOakckmmont9TgTnQL4DwXHcfsOu7fy+hNT0Lu+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776158267; c=relaxed/simple; bh=y9RBwNlL7JFhRplM8GzxiuHZYoF1Od4tFFoLb5d65OE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=P7KN4ISH5vXettraE3Abp43aYhAYvT/rhoZ4pWtRKxmygG+hDGMvA//izWWDJUytqRfR85Gj3koG5y/+HZVTO74iJUpafivwVd1H/hEWExKYJqGyuBTp4M5TgyQTjt6euKAG6acm9l+fn/WrrkyKJxD5HG14l9tsUKS5dgV54yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PXb9T8Pj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=U2D3WG+x; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PXb9T8Pj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="U2D3WG+x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776158265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8o+jTcPee9ytS2fBNgNkDGXbrpoLlX9QLHbrMcVIiqY=; b=PXb9T8PjQrlpvT93q8c0B6rv2otrPLefXYMTDpmW8vMLFnZ1gHmm/9QoJ8058bqFMdUe// XURhNqAJBzmA9DnQYNrBq1lNmtAihkzqNUxqT6CE37izcvpxihJ2amF1sy94E/Jwj9GPuV oja0Or83mVb4H7ncyQxD5rD27INGU68= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-udEBKbatPWe1JEyt7iR7hw-1; Tue, 14 Apr 2026 05:17:43 -0400 X-MC-Unique: udEBKbatPWe1JEyt7iR7hw-1 X-Mimecast-MFC-AGG-ID: udEBKbatPWe1JEyt7iR7hw_1776158263 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d177fb157so5290378f8f.0 for ; Tue, 14 Apr 2026 02:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776158263; x=1776763063; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=8o+jTcPee9ytS2fBNgNkDGXbrpoLlX9QLHbrMcVIiqY=; b=U2D3WG+xLbxBDcflMW/7RIsu1hpb1bX7i03/sFi4cuQC5qZmlAiJKC4vA/JggHRfOz +f/2M0gggTjhtypa+v+ZILkm3KTqbAM4tcWWaNkw/+xK3ioXwe43WChH9ITYIrG+DJvV 68iqfSXUmVfbb1mV/SxfBeORnej0WqE5n49t2v5QdWuX24WJ8JDEgcbEwGic5qiE/LR7 BjZcfzjm/5YSgq80anjgC0EFMG/X6XyFWjMnWHEtCoIhrI0+nHcVsdSd0SQHhaqtUM3Q BKq2x+R4qAGmuMs3+5Lsr+w+py2oKZLFKvXBZ69d38QVgdHoM7fYRuccsl+qav4tTGcv GY6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776158263; x=1776763063; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8o+jTcPee9ytS2fBNgNkDGXbrpoLlX9QLHbrMcVIiqY=; b=LEFrrYu0T9u+sdU4c0sCtkS6nWzJgm36bknXVclPzzQzhtqPdrC5xA5MOYebfdG2uX SgbsVAdYF+kQWeZHQaV5xqtzBCEYouJ+RjgRAVWRVJ62STBOvXyCRqdR077m1gMCGGBF os+Ws6WvgLkvIF2DqA9Mr+0L7jHdDOa1gtaITxrnrWi/8iq9xg2tqIvIQt6ametMlQT7 YpJGhBXpFpiaWMqrtm/i6S198NLE8Md9Za7fO+wF89KO7L6TtPE+PPQHyqXfxm3q6Jzo hrLq3h85QGq/oPOLvqsF3E/YgfImBqVgPhoTsDBF0TlmZmT1D+/+Qq6M/5h7vA7FDd0D eHjQ== X-Forwarded-Encrypted: i=1; AFNElJ+4yu/ACg2R6zrAK01A4bwww8qdeFdhMqMwQ0lVr1y/54yE3lTo5bGVx6KzUrpISsRd+099RXsCPFZ0bKA=@vger.kernel.org X-Gm-Message-State: AOJu0YwD8H45GUuNidwCIUdy4P4gB8WT5chNQ+2pFBWAS4/C+3PmKfuo KiG7S7uuvcF3V9RGZZqU9uPMmiRTixp+rM/HuwnTZIwu5/xLJugtJ9PkmnPtnuYRO/NSqi7eZc3 fIKglfB8jmZK8rPeC1Rr4MBUhhdv9xNMkkH+Uh2oHb7UEcL0xny/fYr3Rz20mYv4kyg== X-Gm-Gg: AeBDiesrLe6TumvwtoVP1xoyqXfq3awiFAfkbfhXFeBoH2RzYZ/6wzaPH4yT72SfA8A 8O4pMHVymFT1WEKkjT7gMcu7sqE4Zptkueg2SUcIc7yJuPudjTzvfx4X83ySzmo7eMLaruPqEn6 SLv6obU0WcJEoK5rgYA1i5laq35WYwdyYyOLQt8wVav+wWEWwZGS8VnVnxssJvEBLtiYBpZYOZ6 DPgbkjpIudlmCY3PiDEshrRiaygY+oPZbFMbva6btWd+mKdWpb2xTFXYa31mpkTboIshhMtGEyw HUiyasoBm4/uBm40TKkzJgEVcY18k4vN95KsRixm1TmJCPa1XdrUx2b5qZYIyw3A5+XWnQ3sJ1C QmCrliDkdIeUXt8aeEUBtRUFZvuNS9j+vq9oK+YWK3eYPZvWIyt7oA142 X-Received: by 2002:a05:600c:a404:b0:487:1108:48b8 with SMTP id 5b1f17b1804b1-488d67b8d97mr197779035e9.2.1776158262584; Tue, 14 Apr 2026 02:17:42 -0700 (PDT) X-Received: by 2002:a05:600c:a404:b0:487:1108:48b8 with SMTP id 5b1f17b1804b1-488d67b8d97mr197778675e9.2.1776158262108; Tue, 14 Apr 2026 02:17:42 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede2ba5asm32868935e9.12.2026.04.14.02.17.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 02:17:41 -0700 (PDT) Message-ID: <04cafd50-7af5-4835-b0df-67393d9f5a51@redhat.com> Date: Tue, 14 Apr 2026 11:17:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 2/2] selftests/bpf: verify syncookie statistics in tcp_custom_syncookie From: Paolo Abeni To: Kuniyuki Iwashima , Jiayuan Chen , Eric Dumazet , Daniel Borkmann Cc: netdev@vger.kernel.org, Neal Cardwell , "David S. Miller" , Jakub Kicinski , Simon Horman , David Ahern , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260411013211.225834-1-jiayuan.chen@linux.dev> <20260411013211.225834-2-jiayuan.chen@linux.dev> <6b22a595-cd65-42ec-b332-c835273bc174@redhat.com> Content-Language: en-US In-Reply-To: <6b22a595-cd65-42ec-b332-c835273bc174@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/14/26 11:08 AM, Paolo Abeni wrote: > On 4/14/26 7:50 AM, Kuniyuki Iwashima wrote: >> On Fri, Apr 10, 2026 at 6:32 PM Jiayuan Chen wrote: >>> >>> Add read_tcpext_snmp() helper to network_helpers which reads a >>> TcpExt SNMP counter via nstat, and use it in the tcp_custom_syncookie >>> test to verify that LINUX_MIB_SYNCOOKIESRECV is incremented and >>> LINUX_MIB_SYNCOOKIESFAILED stays unchanged across a successful >>> BPF custom syncookie validation. >>> >>> The delta is captured between start_server() and accept(), which >>> covers the full SYN/ACK/cookie-check path for one connection. >>> >>> Signed-off-by: Jiayuan Chen >>> --- >>> tools/testing/selftests/bpf/network_helpers.c | 22 +++++++++++++++++++ >>> tools/testing/selftests/bpf/network_helpers.h | 1 + >>> .../bpf/prog_tests/tcp_custom_syncookie.c | 20 +++++++++++++++++ >> >> As you touch bpf selftest helper files, please rebase on bpf-next >> to avoid possible conflicts and tag bpf-next in the Subject. > > To hopefully minimize the conflicts handling I'm going to apply patch > 1/2 to net-next. Please resubmit patch 2/2 to bpf-next after the > relevant net core reach there. Uhmm... the original feature went through the bpf tree, so I guess both patches could/should via bpf-next. Hopefully conflict into the tcp code should be minimal. @Eric, @Daniel: please LMK if you prefer otherwise. /P