From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E50C77B73 for ; Sun, 30 Apr 2023 17:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbjD3RTk (ORCPT ); Sun, 30 Apr 2023 13:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbjD3RTV (ORCPT ); Sun, 30 Apr 2023 13:19:21 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AE5E3AAE; Sun, 30 Apr 2023 10:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=W2m9o5cAZcUL4YwF6LNqupdePboCY6WLH6EEUshsr3k=; b=h/ v1BqlSOSj4XcZqtRa6+SdSZW7KyYBo8pN4hWyOTz+aKTF/WiuNz2KryyZ+I7WmRK9FCVsahgmC/qx Gcgk+6q+8JKcX8VvNm23QRkNth3TIQea829DuinR4SMHPcZ/7/WlqUJTXcaPw8QepSNQOSHRJ0iJv qKBPQzX4m04tydo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ptAgT-00BYs6-15; Sun, 30 Apr 2023 19:18:01 +0200 Date: Sun, 30 Apr 2023 19:18:01 +0200 From: Andrew Lunn To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: David Bauer , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Landen Chao , DENG Qingfang , Sean Wang , Daniel Golle , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 2/2] dt-bindings: net: dsa: mediatek,mt7530: document MDIO-bus Message-ID: <04cc2904-6d61-416e-bfbe-c24d96fe261b@lunn.ch> References: <20230430112834.11520-1-mail@david-bauer.net> <20230430112834.11520-2-mail@david-bauer.net> <396fad42-89d0-114d-c02e-ac483c1dd1ed@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <396fad42-89d0-114d-c02e-ac483c1dd1ed@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 30, 2023 at 07:17:10PM +0300, Arınç ÜNAL wrote: > On 30.04.2023 15:34, Arınç ÜNAL wrote: > > On 30.04.2023 14:28, David Bauer wrote: > > > Document the ability to add nodes for the MDIO bus connecting the > > > switch-internal PHYs. > > > > This is quite interesting. Currently the PHY muxing feature for the > > MT7530 switch looks for some fake ethernet-phy definitions on the > > mdio-bus where the switch is also defined. > > > > Looking at the binding here, there will be an mdio node under the switch > > node. This could be useful to define the ethernet-phys for PHY muxing > > here instead, so we don't waste the register addresses on the parent > > mdio-bus for fake things. It looks like this should work right out of > > the box. I will do some tests. > > Once I start using the mdio node it forces me to define all the PHYs which > were defined as ports. Try setting ds->slave_mii_bus to the MDIO bus you register via of_mdiobus_register(). Andrew