From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219AB83A0E for ; Wed, 27 Mar 2024 15:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711552243; cv=none; b=BxfN164AKM/4PBw7qM0gfRZ4kcxPaRbus4OlkLHdUtwrs83L+UcRlOQ2vo6AMq2ALqXX6yFxjP5tHan7VXF6Tz6CP2yoNsFQn5bWKVacF7m45BhY5bdtTAPEYdk+qCoK/Zor0YlcJRk9VtGxKTFbpsaYjgko+ZnY8083QSbMiLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711552243; c=relaxed/simple; bh=xSl+elXw6TGnfDDxTuwZc3OijKW+bN4Ubbs24XJFxWA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KdPDsSvkDDVu3eZbKLOjCLiabOKhQAR1dYWweRmj9RGOjSEdQ69tczFRXwT3zJZpf7clTAePvResXV4tsj597H39NyamaFImc4YSn/TF+iG4VIysNIuYduxD6mLZpleonkfdcLUZMWfkqdUc7zVonRwOFtIstwK2MHynDbv2fJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=JU5CiExG; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="JU5CiExG" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-566e869f631so7482436a12.0 for ; Wed, 27 Mar 2024 08:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711552238; x=1712157038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wg3QzX5qREXmVZsGaqo0PzIOFIXQE1IbveON87ikDwQ=; b=JU5CiExGX2fWxeAmFJzOzhGwjmo9bvN5OJ/5W3s11sF16i8OXUMOe5F/pBm76Go78K hBC6XSl0UIB6l1qrL1CW7g8K/2XbIftE+yGsoUacfC3KOd3MXzrTCcrlgVAo8ZSidJZI B9bYh0AHyTi0Dh75aQhLByihVplja8peRlycoXedc36fWXesh4Qut8qQVrkpIa2miVBC blI0uZ1p0/q9qT4iq8nAj8XB7kPceKzwfPkKjn9NMeLN39iZmbRXwEMIk3IefFw4yEli thw+qo0uqtpTn0QpODta8N3GGOX/5ITLRLURxRNq/RJR7FxSe1dMUHXkrJEHdHZAy9uY P6hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711552238; x=1712157038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wg3QzX5qREXmVZsGaqo0PzIOFIXQE1IbveON87ikDwQ=; b=u4/4eep/Y9Kadq9QQ6V7HJoapbsH3MUrdj9wSg4Q0M/zt5v41K8pFnL5/MmB7x5DUe 18w4L1uQm7MSninzJ3w7Ln6AVmd9MNqZ7X38jkvSIAqZVakiipzykkqz/ZZV9KCV86I7 zhxIfpo8Fa5GovvQMVca5drgOXa4ENshgl9EH2Gpe0aUcRrY7PhGwryhY545Xjm6r0WL LpPviUB6nbqnyT2rjD2eqpxLk/LSxhWuf3jNS1mAMMqY933jewkJOolIMbA1YUEvM2jW qVeL1B38OGWwwhoH/HahlgAq8ImyjEQfBYaPN9E29H6cTSihcKXUELYz0EmYzRd5R5nX hPzw== X-Forwarded-Encrypted: i=1; AJvYcCXOjo9Mnb4HOIJUeDj87rDVcu5mAq7xfU4w0lp2y0fRhnNfoH+q50LSt4PeOc1lIm7WghnXvUV5uSdzo6ytxvONaaS15nb9TacGy6Hv X-Gm-Message-State: AOJu0Yzuak16jM1vJpKa4UhY+LVWlHrGvj7OrhfteBRwcUwaBzRjt2WR jTkIUoU2dt4HaZbDzP3q87IZRXqnhaNGpLUBTF4Ja/l/ASwdDM2Zgkv4Aua2i3c= X-Google-Smtp-Source: AGHT+IEG6gS6qYe0E+lUJL//xh4zBdNakL80EjwnyIFcIwgzZrLzz6D+EK8zTW1O20qHE7z/Fw/K4A== X-Received: by 2002:a50:f61d:0:b0:567:737f:e910 with SMTP id c29-20020a50f61d000000b00567737fe910mr80250edn.3.1711552238517; Wed, 27 Mar 2024 08:10:38 -0700 (PDT) Received: from ?IPV6:2001:a61:1366:6801:b2db:904d:e0b0:46ec? ([2001:a61:1366:6801:b2db:904d:e0b0:46ec]) by smtp.gmail.com with ESMTPSA id dm28-20020a05640222dc00b0056b7ed75a46sm5403800edb.27.2024.03.27.08.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 08:10:38 -0700 (PDT) Message-ID: <04cfa214-4d45-48b1-87ba-500e3e501977@suse.com> Date: Wed, 27 Mar 2024 16:10:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] usbnet: fix cyclical race on disconnect with work queue To: Sai Krishna Gajula , Oliver Neukum , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "syzbot+9665bf55b1c828bbcd8a@syzkaller.appspotmail.com" References: <20240321124758.6302-1-oneukum@suse.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/22/24 18:43, Sai Krishna Gajula wrote: > >> -----Original Message----- >> From: Oliver Neukum >> Sent: Thursday, March 21, 2024 6:17 PM >> To: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; >> pabeni@redhat.com; netdev@vger.kernel.org; linux-usb@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Cc: Oliver Neukum ; >> syzbot+9665bf55b1c828bbcd8a@syzkaller.appspotmail.com >> Subject: [PATCH net-next] usbnet: fix cyclical race on disconnect >> with work queue > > This patch seems to be a fix, in that case the subject need to be with [PATCH net] OK > >> >> The work can submit URBs and the URBs can schedule the work. >> This cycle needs to be broken, when a device is to be stopped. >> Use a flag to do so. >> >> Fixes: f29fc259976e9 ("[PATCH] USB: usbnet (1/9) clean up framing") > > Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("")' - ie: 'Fixes: f29fc259976e ("[PATCH] USB: usbnet (1/9) clean up framing")' Ehm, what exactly did I do differently >> --- a/drivers/net/usb/usbnet.c >> +++ b/drivers/net/usb/usbnet.c >> @@ -467,10 +467,12 @@ static enum skb_state defer_bh(struct usbnet *dev, >> struct sk_buff *skb, void usbnet_defer_kevent (struct usbnet *dev, int work) > > space prohibited between function name and open parenthesis '(' I am sorry, but this is the context of the diff. You are not suggesting to mix gratitious format changes into a bug fix, are you? >> diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h index >> 9f08a584d707..d26599faab33 100644 >> --- a/include/linux/usb/usbnet.h >> +++ b/include/linux/usb/usbnet.h >> @@ -76,8 +76,26 @@ struct usbnet { >> # define EVENT_LINK_CHANGE 11 >> # define EVENT_SET_RX_MODE 12 >> # define EVENT_NO_IP_ALIGN 13 >> +/* >> + * this one is special, as it indicates that the device is going away >> + * there are cyclic dependencies between tasklet, timer and bh >> + * that must be broken >> + */ > > Networking block comments don't use an empty /* line, use /* Comment... OK Regards Oliver