mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: linux-kernel@vger.kernel.org, richardcochran@gmail.com,
	hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org,
	john.stultz@linaro.org, prarit@redhat.com,
	stephen.boyd@linaro.org, ghackmann@google.com,
	mlichvar@redhat.com, linux-tip-commits@vger.kernel.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Cc: Shuah Khan <shuah@kernel.org>
Subject: Re: [tip:timers/core] kselftests: timers: set-timer-lat: Tweak reporting when timer fires early
Date: Tue, 19 Sep 2017 19:02:41 -0600	[thread overview]
Message-ID: <04d5e9e4-ef81-a9e7-8180-2c668e3af9d0@kernel.org> (raw)
In-Reply-To: <tip-a524b1184b8e86141d689fa78ad150fbf2db9b4c@git.kernel.org>

Hi Greg,

On 08/20/2017 03:56 AM, tip-bot for Greg Hackmann wrote:
> Commit-ID:  a524b1184b8e86141d689fa78ad150fbf2db9b4c
> Gitweb:     http://git.kernel.org/tip/a524b1184b8e86141d689fa78ad150fbf2db9b4c
> Author:     Greg Hackmann <ghackmann@google.com>
> AuthorDate: Tue, 25 Jul 2017 14:36:25 -0700
> Committer:  John Stultz <john.stultz@linaro.org>
> CommitDate: Thu, 17 Aug 2017 12:14:54 -0700
> 
> kselftests: timers: set-timer-lat: Tweak reporting when timer fires early
> 
> Rather than printing an error inside the alarm signal handler, set a
> flag that we check later.  This keeps the test from spamming the console
> every time the alarm fires early.  It also fixes the test exiting with
> error code 0 if this was the only test failure.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Miroslav Lichvar <mlichvar@redhat.com>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Prarit Bhargava <prarit@redhat.com>
> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Greg Hackmann <ghackmann@google.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>

This commit is making the set-timer-lat hang. I reverted this commit
and there is no hang. Could you please take a look and see if this
commit should be reverted.

make kselftest as well as make -C tools/testing/selftests/timers run_tests
hang.

I had to revert the following as well, however a524b1184b8e86141d689fa78ad150fbf2db9b4c
is the suspect.

Commit-ID:  28be3f8f48cfb3cf024860f042d424cd4824f5f7
Gitweb:     http://git.kernel.org/tip/28be3f8f48cfb3cf024860f042d424cd4824f5f7
Author:     Greg Hackmann <ghackmann@google.com>
AuthorDate: Tue, 25 Jul 2017 14:36:26 -0700
Committer:  John Stultz <john.stultz@linaro.org>
CommitDate: Thu, 17 Aug 2017 12:14:58 -0700

kselftests: timers: set-timer-lat: Add one-shot timer test cases

Please let me know how you want to proceed. At the moment kselftest
run hangs due this test hang.

thanks,
-- Shuah

       reply	other threads:[~2017-09-20  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-a524b1184b8e86141d689fa78ad150fbf2db9b4c@git.kernel.org>
2017-09-20  1:02 ` Shuah Khan [this message]
2017-09-20  3:21   ` John Stultz
2017-09-20  3:36   ` John Stultz
2017-09-20 12:31     ` Prarit Bhargava
2017-09-20 23:38       ` Shuah Khan
2017-09-21 19:40         ` Greg Hackmann
2017-09-21 19:42           ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04d5e9e4-ef81-a9e7-8180-2c668e3af9d0@kernel.org \
    --to=shuah@kernel.org \
    --cc=ghackmann@google.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mlichvar@redhat.com \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=stephen.boyd@linaro.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®