From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Sean Rhodes <sean@starlabs.systems>, chrome-platform@lists.linux.dev
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Prasanth Ksr" <prasanth.ksr@dell.com>,
"Jorge Lopez" <jorge.lopez2@hp.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Joshua Grisham" <josh@joshuagrisham.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Brian Norris" <briannorris@chromium.org>,
"Julius Werner" <jwerner@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Andersson" <andersson@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Eric Biggers" <ebiggers@kernel.org>,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Michal Simek" <michal.simek@amd.com>,
"Sven Peter" <sven@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Titouan Ameline de Cadeville" <titouan.ameline@gmail.com>,
"Kees Cook" <kees@kernel.org>,
dri-devel@lists.freedesktop.org,
"Oliver Lin" <oliver@liuxiaozhen.dev>
Subject: Re: [PATCH v11 3/4] firmware: Rename google firmware directory to coreboot
Date: Tue, 4 Aug 2026 13:04:55 +0200 [thread overview]
Message-ID: <04db0ee0-a8d5-4f30-a494-5c7f8ac757c8@oss.qualcomm.com> (raw)
In-Reply-To: <e0d2a22e-a0cd-4a71-82c4-b88abcc7456e@oss.qualcomm.com>
On 04/08/2026 13:02, Krzysztof Kozlowski wrote:
> On 04/08/2026 12:13, Sean Rhodes wrote:
>> rename to drivers/firmware/coreboot/Kconfig
>> index b78c644fa253..d273bd836245 100644
>> --- a/drivers/firmware/google/Kconfig
>> +++ b/drivers/firmware/coreboot/Kconfig
>> @@ -1,13 +1,16 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> -menuconfig GOOGLE_FIRMWARE
>> - bool "Google Firmware Drivers"
>> +menuconfig COREBOOT_FIRMWARE
>
> As pointed out by defconfig change, which is supposed to be separate
> commit, this will affect users of the kernel for no real gain.
>
> Do not change this.
I am surprised that such change appeared at v10.
Changelog is quite incomplete and I do not see any explanation for this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-04 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:13 [PATCH v11 0/4] coreboot CFR firmware attributes Sean Rhodes
2026-08-04 10:13 ` [PATCH v11 1/4] platform/x86: Sort firmware attributes class includes Sean Rhodes
2026-08-04 10:13 ` [PATCH v11 2/4] firmware: Move firmware attributes class helper Sean Rhodes
2026-08-04 10:13 ` [PATCH v11 3/4] firmware: Rename google firmware directory to coreboot Sean Rhodes
2026-08-04 11:02 ` Krzysztof Kozlowski
2026-08-04 11:04 ` Krzysztof Kozlowski [this message]
2026-08-04 11:24 ` Sean Rhodes
2026-08-04 11:28 ` Krzysztof Kozlowski
2026-08-11 20:21 ` Julius Werner
2026-08-12 10:06 ` Krzysztof Kozlowski
2026-08-12 19:47 ` Julius Werner
2026-08-04 10:13 ` [PATCH v11 4/4] firmware: coreboot: Add CFR firmware attributes driver Sean Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04db0ee0-a8d5-4f30-a494-5c7f8ac757c8@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=chenhuacai@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corentin.chary@gmail.com \
--cc=dakr@kernel.org \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiggers@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jorge.lopez2@hp.com \
--cc=josh@joshuagrisham.com \
--cc=jwerner@chromium.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=luke@ljones.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=o-takashi@sakamocchi.jp \
--cc=oliver@liuxiaozhen.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
--cc=sean@starlabs.systems \
--cc=simona@ffwll.ch \
--cc=sven@kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tzimmermann@suse.de \
--cc=tzungbi@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®