From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D3312B94 for ; Wed, 8 Jul 2026 08:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783499458; cv=none; b=lCkyQs6sk/Az2BEEf/FYF7M/0LBkxKZcByUHH++7yjYykz9hCtiDh2NJP8Vc2P5z2Rl242ucEs7IDz20W0yKQYzYINWGljIpv/cFjPr0lF/UD7eY1Kqi5HnpecUTX10RC/FAGA48lz6Dm/J3ar8pcHUGvP+cdU1f2gDohGZZviY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783499458; c=relaxed/simple; bh=vUxkYgLjD7SSNYU9O4l3RAJNTa98pYA33vlEm8vPQ1c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d4dZgXgovMm2aG+274CI6EeEOe1gOQIiHMI3+Jil2rfTwufLMyEylcFZbVvx3SX1QZ25HazzE6/J6SyLe+7CUx+nt+GmJKFzEVBQSbc52+H4zOxYuJpjmmn4462uRlV/oCkdHK/g9o8zTtbQG/M0iPsqqSeoKGMas6/swZ1Nzl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HWLd9fzq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=idMdybzy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HWLd9fzq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="idMdybzy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783499455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2x2KW8jXt7Qu/ChgVuNcsLQe8Mz8PkKb4meLHcRszN0=; b=HWLd9fzqpLVKMJZpJddVc8eCgyMdMLZuadtDy5/t6o3QTI8I4/XQHPNp57KoQm/BWCWZjv sDAQPgNRM4C//L9yOIbvUvg+lfXP8IPL3D0yq7CB3qGoSFl07/yLC3UpG/Bp1ga6gmy3vj W3fjkVkxSow7ZZTevQwFif1IItJ60y0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-Q2rL8zhQMjWQJKpi1_Z-sg-1; Wed, 08 Jul 2026 04:30:53 -0400 X-MC-Unique: Q2rL8zhQMjWQJKpi1_Z-sg-1 X-Mimecast-MFC-AGG-ID: Q2rL8zhQMjWQJKpi1_Z-sg_1783499453 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-493dc8408fdso3346885e9.1 for ; Wed, 08 Jul 2026 01:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783499453; x=1784104253; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2x2KW8jXt7Qu/ChgVuNcsLQe8Mz8PkKb4meLHcRszN0=; b=idMdybzyWDpzo7kOmz/tBNeV/f3+ngyqZeyuKrWOcekEI/ZlMOF7AJatdsNzWinw+O +vD0k9IBO6dPK3ymeU0GPwB10KH6Nb2zVom2Pu7xiKzRmxJGsKRHQbTQ0Kw6yeoZSK7f UFHu0/VIWv7h7RCSTORbNfJ/pz/lgXtRlomU8xVpmKO9l/seGMUlgarxWqt+ALPlvvsh S1agV3msl+T9aASGy/jly42fH1Uo6w9SGg6rx9XdtgcqRJFioWoL5zi4lG+1UXkipuwc B/otqsAtJlN3gHKE9NmvZj7Pj2S9odDp+ZSNb/7o0k4rsD1x/qFFQFAj57PnwdoBS3FS qjag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783499453; x=1784104253; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2x2KW8jXt7Qu/ChgVuNcsLQe8Mz8PkKb4meLHcRszN0=; b=FovUsQEDqYUmvP62uoHrvle/qan8BcdbxB7f6Vk7C3ilqnOoVL0S5zZSzaOfvAT6I+ Sc28ZkFXO2E1bBU7kpCu2uGC2BdX5wrM4A2vKdyvX06BvWbe12SKRNZkwYN18mxGfu8e /2aecT/r7n7gYD0nUOZE2E/tvf6Umzjgz5ZLesa8xWC8FAO5TliSK3ee0i/cjQRvh6hv rYnIee2ako0DVTJjCSJ4bjrmyL9MXO8B7pCJdkbj0aQjqzPF1+xdCRRNmTPTutt8WQwf Al7C1lHpMojEhvmC+gqcnGeRzb03cHFfZmjWvlopyewMhPYES/C+KcdPmQARxDfwbNuM jmGA== X-Forwarded-Encrypted: i=1; AHgh+RrYJYJIVHbKUwSdT7BXfCurWRwxHJdoN5o0Cbi1UdgGkCmh2v00w47XUMyRiGuvZKRfW4MMAMyDoIT74s0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+9y3QnkIftJ8v3oFAbiZRBd1Ckg7z0VCP6a4k0F7mPMQFkInv wlHrVRF/4mm3SXOB2P6sHn7qLSiPKjMuPrsye8ypXGozMqBphOlwMvxyBwSW/NtEL5zzAsQVlcK v1VwGdI4Bi6G3FwCUTZ0e4hN0Cwduzhzsu/8hn3fpDzCR+Tvmv5ZPEVUsw0Bvxx7iX0QBjIEZDw == X-Gm-Gg: AfdE7cnLwdH0TX4J9eqx4lq2xIq8WC/hg4JEfNRBlposryYRNNU+LsiIv+r8ty2KPzf BYyZmdrnJMHnPoUxT/E5Z3+gdg0A3W57HyRqeB69W8PFSd6FOzKhKUMKqScT/23Zyq6jHFQTgxb qvfRNMAv6Wz8einrBgEGC6OFuP1sXal4haH/sd8HObm8UBeoycKJJIo+OtOhzrTYIrWsQvSmteF fssroMjHJzaGvf+dp5VZpYib+4mhfptXZxZ1XBAEXG8U9Lx9j9g+IYBNWa11EjFrigXzF+1l72B MNdEqKSlccKBxHCeLcZHzaTJlvUlubPcZbulEEXFpU0j+4gz4f5LqCFcROE4yj1DY/BwShqfdp6 yjONhczxZtYVb3HHpBKAdvyI84siXRs28DOi3kIdp1cKK3myRnBiNO0itB/zxOy5Xh0QgerG0Eo dCBskHRILPdGQI X-Received: by 2002:a05:600c:6206:b0:493:bc92:ba9a with SMTP id 5b1f17b1804b1-493e68bee61mr14535925e9.13.1783499452623; Wed, 08 Jul 2026 01:30:52 -0700 (PDT) X-Received: by 2002:a05:600c:6206:b0:493:bc92:ba9a with SMTP id 5b1f17b1804b1-493e68bee61mr14535405e9.13.1783499452198; Wed, 08 Jul 2026 01:30:52 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0faed08sm111777175e9.11.2026.07.08.01.30.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 01:30:51 -0700 (PDT) Message-ID: <04debe19-bbe8-4b5f-9668-753d1f97832d@redhat.com> Date: Wed, 8 Jul 2026 10:30:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: skb: isolate skb data area allocations into a separate bucket To: Pedro Falcato , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: Simon Horman , Jason Xing , Kuniyuki Iwashima , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook References: <20260702170728.168755-1-pfalcato@suse.de> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260702170728.168755-1-pfalcato@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/2/26 7:07 PM, Pedro Falcato wrote:> @@ -586,6 +586,8 @@ struct sk_buff *napi_build_skb(void *data, unsigned int frag_size) > } > EXPORT_SYMBOL(napi_build_skb); > > +static kmem_buckets *skb_data_buckets __ro_after_init; > + > static void *kmalloc_pfmemalloc(size_t obj_size, gfp_t flags, int node) > { > if (!gfp_pfmemalloc_allowed(flags)) > @@ -593,7 +595,8 @@ static void *kmalloc_pfmemalloc(size_t obj_size, gfp_t flags, int node) > if (!obj_size) > return kmem_cache_alloc_node(net_hotdata.skb_small_head_cache, > flags, node); > - return kmalloc_node_track_caller(obj_size, flags, node); > + return kmem_buckets_alloc_node_track_caller(skb_data_buckets, obj_size, > + flags, node); Sashiko noted that some drivers may require GFP_DMA buckets, and the above may break them: https://sashiko.dev/#/patchset/20260702170728.168755-1-pfalcato%40suse.de > } > > /* > @@ -634,7 +637,7 @@ static void *kmalloc_reserve(unsigned int *size, gfp_t flags, int node, > * Try a regular allocation, when that fails and we're not entitled > * to the reserves, fail. > */ > - obj = kmalloc_node_track_caller(obj_size, > + obj = kmem_buckets_alloc_node_track_caller(skb_data_buckets, obj_size, > flags | __GFP_NOMEMALLOC | __GFP_NOWARN, > node); Minor nit: checkpatch laments WRT brackets alignment. /P