From: "Shenhar, Talel" <talel@amazon.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>,
Ronen Krupnik <ronenk@amazon.com>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>
Subject: Re: thermal: thermal_mmio: Constify static struct thermal_mmio_ops
Date: Wed, 22 Sep 2021 14:01:26 +0300 [thread overview]
Message-ID: <04e09b28-3b0d-ed64-8bec-f07bc0ddf88e@amazon.com> (raw)
In-Reply-To: <20210920203849.32136-1-rikard.falkeborn@gmail.com>
The only usage of thermal_mmio_ops is to pass its address to
> devm_thermal_zone_of_sensor_register(), which has a pointer to const
> struct thermal_zone_of_device_ops as argument. Make it const to allow
> the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Talel Shenhar <talel@amazon.com>
> ---
> drivers/thermal/thermal_mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
> index ded1dd0d4ef7..360b0dfdc3b0 100644
> --- a/drivers/thermal/thermal_mmio.c
> +++ b/drivers/thermal/thermal_mmio.c
> @@ -34,7 +34,7 @@ static int thermal_mmio_get_temperature(void *private, int *temp)
> return 0;
> }
>
> -static struct thermal_zone_of_device_ops thermal_mmio_ops = {
> +static const struct thermal_zone_of_device_ops thermal_mmio_ops = {
> .get_temp = thermal_mmio_get_temperature,
> };
>
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-09-22 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 20:38 [PATCH] " Rikard Falkeborn
2021-09-22 11:01 ` Shenhar, Talel [this message]
2021-10-05 14:36 ` Rafael J. Wysocki
2021-10-05 16:51 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e09b28-3b0d-ed64-8bec-f07bc0ddf88e@amazon.com \
--to=talel@amazon.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=ronenk@amazon.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®