mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Matteo Rizzo <matteorizzo@google.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2] perf/x86: Check data address for IBS software filter
Date: Fri, 21 Mar 2025 21:49:13 +0530	[thread overview]
Message-ID: <04f0a3b5-6665-40f7-a19f-f3ed36aece52@amd.com> (raw)
In-Reply-To: <Z9tCyVkqCzbulODv@gmail.com>

Hi Namhyung, Ingo,

>>> We have two options:
>>> 1) Restrict IBS + PERF_SAMPLE_RAW to privilege users.
>>> 2) Remove all sensitive information from raw register dump before
>>>    passing it to userspace. (Kernel data addresses and all physical
>>>    addresses are the only sensitive info I suppose?).
>>>
>>> 2 is better IMO since it will allow unprivileged user to use IBS
>>> with full potential. wdyt?
>>
>> I'm slightly inclined to #1 for simplicity and safety, but #2 is fine 
>> to me as well.
> 
> I'd prefer #2 for superior usability, if it doesn't get too 
> complicated.

Thank you for your opinion.

I've posted a v3 based on 2nd option:
https://lore.kernel.org/r/20250321161251.1033-1-ravi.bangoria@amd.com 

@Ingo, can you please revert v2 and apply v3? (provided @Namhyung is okay
with it).

Thanks,
Ravi

      reply	other threads:[~2025-03-21 16:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 16:37 Namhyung Kim
2025-03-17 22:51 ` [tip: perf/urgent] " tip-bot2 for Namhyung Kim
2025-03-18 10:32 ` [PATCH v2] " Ravi Bangoria
2025-03-18 18:09   ` Namhyung Kim
2025-03-19 10:54     ` Ravi Bangoria
2025-03-19 20:30       ` Namhyung Kim
2025-03-19 22:18         ` Ingo Molnar
2025-03-21 16:19           ` Ravi Bangoria [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04f0a3b5-6665-40f7-a19f-f3ed36aece52@amd.com \
    --to=ravi.bangoria@amd.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matteorizzo@google.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®