From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F6D733E355 for ; Thu, 27 Aug 2026 07:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787814600; cv=none; b=bbXT6kcZ4nl27Iiolo63SfMOA1kMfAzaE48UmdL/dV8BELPOSh69evIXThEyw/tnupaMyr7yCG7PDAHh+NyySmLfB/eG4kTPOMxGGue+asbWKVNZhQY4met84FU6G9PvDdWbRXQj6j0rPMUyngzViFlj7AYbW5WvGBy391+VeVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787814600; c=relaxed/simple; bh=otjiHE/ALxd0WQQGUzZepzGe33+eZ8p10IspGrscHgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lM1jKyt5fnKttvJxmNxENpIsTF9CwfakCJWKheSLM6h4sZBPLABxkEwMyym20yCY6BpG6JE/UtxprzPht2y7r687hUKF6aWOiXRov8XSoLzVg630PX7crC1PhWfnlbZK9ZC/PpUk+GF1rHTjl6lTezUyXMEXkdngnzN5sd9bqUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=nni1pEqo; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="nni1pEqo" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67R6VdG01082064; Thu, 27 Aug 2026 07:09:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=otjiHE /ALxd0WQQGUzZepzGe33+eZ8p10IspGrscHgI=; b=nni1pEqoVHrmpKiBr5bo0o oyus+ruOYk4xc6qTGJS5sPtcgefmv9BbB1irt3YKFSugjo48mHpAxreHXXyYCa4J jkEVuC0QiGZU8Hxml+oady7G18L5fjx2AZEZqgL7IXGkLbzYL18uxgCbfahnzJSP Ya09n/DRTBq2rR1yHvr4cD1lmEb/xQWOiBWmfMkKLXNTzv04FUSY6KpUII8kehdy ZoHoCV5K/HRP/wGKiHOlqorRnvL826qG9vw1Kb6+e7l0zvafhO4DFWKddxP3sdrs 8nHBn/Khr3RmnhJbXVngRFdutexEi7843aziNk7FYLgPbHWqv0ZXVeYIAu0HpOLg == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4g726euq5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 07:09:45 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67R6uK2A024191; Thu, 27 Aug 2026 07:09:44 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4g7pfweshf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 07:09:44 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67R79dfR42795394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Aug 2026 07:09:39 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B04B520043; Thu, 27 Aug 2026 07:09:39 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3DD812004E; Thu, 27 Aug 2026 07:09:35 +0000 (GMT) Received: from [9.67.147.197] (unknown [9.67.147.197]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Aug 2026 07:09:34 +0000 (GMT) Message-ID: <04f38671-f894-40ef-94b2-f24e2bd42474@linux.ibm.com> Date: Thu, 27 Aug 2026 12:39:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ppc/fadump: collect dump if the collected size is lesser than reserved To: Shivang Upadhyay , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: adityag@linux.ibm.com, adri.vero.dev@gmail.com, anushree.mathur@linux.vnet.ibm.com, chleroy@kernel.org, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com References: <20260826125626.2108771-1-shivangu@linux.ibm.com> <1a0a3a16-b92e-47ec-8545-035022583de7@linux.ibm.com> <7ed10640c0b27403d7e9ef9807b957cff59eba60.camel@linux.ibm.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: <7ed10640c0b27403d7e9ef9807b957cff59eba60.camel@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=TfimcxQh c=1 sm=1 tr=0 ts=6a8fe2b9 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=5vD7ezWpz5V1CiZQhYcA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDA1NiBTYWx0ZWRfX+Loab30cce3G lPTklQ1tYVhXnZ1ZcSOhUmV/pyNDH61NnGV/FPpIe5MujzY7y737A/aEbVyp8YVDuQroo3+q4QT yNsuNT9+h+ckEC8zCzzkdq26LCjuwik= X-Proofpoint-GUID: 7aKIp31cxkHQE5qmDpFzf8ewqZ8jTyeU X-Proofpoint-ORIG-GUID: ZSktznSnj5VpQkVey1pmz34mzZNHfiT_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDA1NiBTYWx0ZWRfXzvVhD3S+P9Bd otwH6IyKZFKTSLS2l33uWpZgf2QCK48iie6YM388h8pRZySv5/TPSNS+p98VLXMtmiN/loQ+QGI 1JOtkz0qcpMcbigmljMGCFmv97baVWPuXeIZ20IUlkUSRhd6TUwcPnNvPhZ165MGy8NJCdj1Iw7 uGNWmr4EdEcVgFH7hWy+fWl1LNKcpcsggjE40vcCjjUpimQ6NyECW7pAHKgzUVM+BNhMEBu8j2S hRjmSyjR0xZsL/DenClWkNvjvyExYZV3xVHaG/crqqxQyXFFgPHHOqCthwqUT+sTp12S+79hcx0 onZUeOwKOiTcL3btJ2SLt44y9bSmBgFMsFXm6u304L7ndgVMRccZ593HE3pOkxoveG955Xyb6/k imJadv8ZKFyGukG7MvU9las2v7CLSjcKhvg5m9U+SKvrcEdjhbtg563CS2nz8qAgXt5n38Jg/QA xCAITEsKl6uGaU5PlwQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_03,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270056 On 27/08/26 12:06, Shivang Upadhyay wrote: > On Thu, 2026-08-27 at 11:05 +0530, Sourabh Jain wrote: >>> bytes_dumped <= source_len)); >> Do we really need region_collected variable? Can't we manage with rc >> only? >> >> Is bytes_dumped < source_len is good enough instead of <=. There are >> a >> couple of warnings/errors reported by the checkpatch script. >> Please address them in the next version. >> >> - Sourabh Jain >> > Hi Sourabh, > > bytes_dumped < source_len should also be correct, but "<=" is more > expressive. Why not leave such optimizations to compiler. > > For the region_collected, RC should be used to manage the return code, > so I as per me it is more appropriate to use new variable here. Or > maybe, type the condition in the bracket itself(?). Yes this also works. - Sourabh Jain > > Thanks for pointing out the checkpatch bugs, I'll send a revision soon. > > ~Shivang.