From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B751C84D29 for ; Mon, 1 Jul 2024 10:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719829394; cv=none; b=eijqHmZPRMsMZbsgB+czTGYSK3B53fjkN+723b2r0MxWOlhULMHXeb5AC9ivBSzSQCPwW6p56/rQvVHMPbdBbErTnpCa8zKRNh4xp6qqChKLCcd37OHI1vC22ISDwODBgTvcanCXuh0ahwlH9/xIseTNmhd+2QaypVthcXrsYLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719829394; c=relaxed/simple; bh=oehHj9FkeJZ5B3gLsstjBGUSPx9PQYiE1Ctx3x47C3A=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Q2gU2Z0A6i+92xlaSvJmvag8Si02eftkk0K5LJ0OBT2s43i1Rc4TlcCzW6WMu4ntGbJ8Ea53ODLAzrOVXJ6HlvqiU98L0/Kr0jxaj7GLNRfK7iPSCFMk2oMtHAAYVLtDGJ/9A26+ZrABGLwl1A/CuBA3f53ODRBQbMm6qb7QNwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nKMVrknX; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nKMVrknX" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-42565cdf99cso25355535e9.3 for ; Mon, 01 Jul 2024 03:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719829391; x=1720434191; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=es72ued27T4MScFVaYol2Tr8ps+FK1gW8G/gs4qGvrk=; b=nKMVrknXl/Fby6bCuw8EhGEeRp2wdWB6w6SHbCvl44VuPB1yLUZCTIMENS9Yg1Wq50 dqnBcI4OR65xyFjzL4Bzz0FG+Q0cHAYgn/lnVkPaZr7gZshCdYVdmeEMiRG9Uvsay/JE p7mBGwuTOQCCFr1oSCcFyhmA09pE8iGUOfuRdphBVj32SXvjD83YQR75LsPl+IGDYrJB ZG0hVhPsYRV5xb9EYavQSXMr7cs8PUTe5ysDgY5coedZutvbHbQG9wftnN0cvpSqicDK BTFXGXp92vR9bg6b6j/eGJB6TLfo8WQNa6FyHCof4jsOmGl4i/+uqMXXGdto9dq6h6Ya 4yUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719829391; x=1720434191; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=es72ued27T4MScFVaYol2Tr8ps+FK1gW8G/gs4qGvrk=; b=o+0/UckpptTAPC+qdtVR54XRS3Qxj8dERYQo7WRE8YWyG64y7jWEF/zLhYwHlQix04 DHGDcX6gDx2YPwhDErXcEYxgdpsIh5/zgrQ2oDRBflZnhS6uC7FfRxcpyhFKqAUCR6uC eCe5I2cty4czZgEV/qxCQgFzoZwQ87FM0oqkpSPCLvuY+J0nq1gRC0QwbVD94+nTGeP5 eFSUJPmGTijA/l41khFkE7vXD1SmW+GD6rIUh/nkFhse3rrc7eRxbqs+Yf/lTyfyiDbA +qTHrFiGq635lhjlcGcISRSBzR3JGbLL0NQR2YOwVbpwPWWSPv5ZVAMrCia99MfVzqDN e6wg== X-Forwarded-Encrypted: i=1; AJvYcCW5OxxYOHTfwgXGHyB/rcvB2yG6RRH3GlQn8LkbrcH/C/nfHYqkOxaHi8787Y8xXOxoV/PSxHM8jTMv/OwrgyCg8wYqTw8F3mSMvRZ5 X-Gm-Message-State: AOJu0YzzE5l4EY6ijXuTbteEP6eRRzlR8Kkegb+bEEawebdopmwqnygL WLNEn5ZVWdBC21FVwJTiiUL3KNHq6h+rDrK3m636QW9x3084Fv6K/LMHrTyOj7I= X-Google-Smtp-Source: AGHT+IFwf8NGDtaFlS7TXsmaKZFBedPeQ9EYRZFjtGYPSpWoAoCiJI6iD0t3kI8k4Et64t0vGIvb7Q== X-Received: by 2002:a05:600c:4804:b0:425:7784:56e6 with SMTP id 5b1f17b1804b1-4257a007729mr43982445e9.11.1719829391130; Mon, 01 Jul 2024 03:23:11 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.178]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256af557fesm148418925e9.11.2024.07.01.03.23.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 03:23:10 -0700 (PDT) Message-ID: <04f5162d-8a95-45ce-a891-3f711b27a469@linaro.org> Date: Mon, 1 Jul 2024 11:23:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR chip From: Tudor Ambarus To: Erez , Esben Haabendal Cc: Erez Geva , linux-mtd@lists.infradead.org, Pratyush Yadav , Michael Walle , linux-kernel@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20240629103914.161530-1-erezgeva@nwtime.org> <20240629103914.161530-4-erezgeva@nwtime.org> <1c457520-07b7-4bde-b040-e8bca959a4f5@linaro.org> <1d56c3b2-7adf-45b9-a509-956340f3f17b@linaro.org> Content-Language: en-US In-Reply-To: <1d56c3b2-7adf-45b9-a509-956340f3f17b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/1/24 11:15 AM, Tudor Ambarus wrote: > > > On 7/1/24 10:46 AM, Erez wrote: >> When using mx25l12805d, we do not read SFDP. >> As it uses the no-SFDP flags. >> When using mx25l12833f hardware with mx25l12805d driver, it did not >> try to read the SFDP. >> Yet mx25l12833f does have SFDP, when I remove the no-SFDP flags, the >> driver fetch the SFDP. >> >> Secondly SFDP does not contain OTP information. >> >> mx25l12805d has two OTP regions of 128 KiB and 384 KiB (yes asymmetric). >> While mx25l12833f has two OTP regions of 512 KiB. >> >> How do we handle it? > > You would first try to parse SFDP and initialize the flash based on > SFDP. If there's no SFDP then you fallback to the flags declared at > flash declaration. Esben had a try recently, see [1]. I don't know if > there's any progress in that direction. > And you can then decide which OTP org to use based on whether SFDP is present or not. > Also, you haven't mentioned anything about the testing. Do you have the > flash? > > [1] > https://lore.kernel.org/linux-mtd/20240603-macronix-mx25l3205d-fixups-v2-0-ff98da26835c@geanix.com/