From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Marc Zyngier'" <marc.zyngier@arm.com>,
"'Axel Lin'" <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"'Russell King'" <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
Date: Fri, 02 Dec 2011 17:43:37 +0900 [thread overview]
Message-ID: <04f701ccb0ce$7c044d30$740ce790$%kim@samsung.com> (raw)
In-Reply-To: <4ED7ADCE.8040609@arm.com>
Marc Zyngier wrote:
>
> On 01/12/11 15:24, Axel Lin wrote:
> > Fix below build error:
> > CC arch/arm/mach-exynos/cpu.o
> > arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
> > arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared
> (first use in this function)
> > arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is
> reported only once
> > arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
> > arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
> > make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
> > make: *** [arch/arm/mach-exynos] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Arghhh... My bad. Thanks for fixing that.
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
Hi Marc,
Since the commit 4e44d2cb("ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER") is not in my tree, this should be handled in your tree and Axel's patch, "ARM: exynos4: Fix build error" is too.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> > ---
> > arch/arm/mach-exynos/cpu.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> > index fed62f4..c7cb462 100644
> > --- a/arch/arm/mach-exynos/cpu.c
> > +++ b/arch/arm/mach-exynos/cpu.c
> > @@ -240,7 +240,7 @@ static const struct of_device_id
> exynos4_dt_irq_match[] = {
> > void __init exynos4_init_irq(void)
> > {
> > int irq;
> > - unsigned int bank_offset;
> > + unsigned int gic_bank_offset;
> >
> > gic_bank_offset = soc_is_exynos4412() ? 0x4000 : 0x8000;
> >
>
>
> --
> Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2011-12-02 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 15:24 Axel Lin
2011-12-01 15:25 ` [PATCH 2/2] ARM: exynos4: Fix build error Axel Lin
2011-12-01 16:39 ` [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Marc Zyngier
2011-12-02 8:43 ` Kukjin Kim [this message]
2011-12-02 9:24 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04f701ccb0ce$7c044d30$740ce790$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=axel.lin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome