From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB7B346AE6 for ; Wed, 4 Mar 2026 07:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609349; cv=none; b=amWFIHi2uXQUhYajQiPge+cT6DlXOYJL/TcTVj6rCP97l+6j4q9PW2u7/cDeBwiQaiNMUw7McnkY/JfyGs5JzO/N+0B9/i39xSaVXY/1q72MKVlOfXgMvl6OJezFJ4XrEgMBr2VCBy4HZzZZ9tziGJnjUfx6F9IYqYF+u4ba7ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609349; c=relaxed/simple; bh=owgmetOP017zUc2xmYxQF4xO4rRCUn1Zs9CHzd9jTb4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=bEb1zz3WivRGUelsubgX1z4H7y8MZQzDLoQBJhBoj9x6akycb1CRQ1fAgukm2mmWUKrnyowIPP6TbVviunu6GwM1+d4t0tkizSU5ZX59EM0jtIkH2GTJgCC+2PNV5wOX9DnKTFyVn8rVFHmkci5qPU8RBTFPzwakbDwPRPHO424= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L9AoUr2w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F1HHykAn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L9AoUr2w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F1HHykAn" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245SO0J1421894 for ; Wed, 4 Mar 2026 07:29:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= acRVQGvlsUrqD0vKmGV4gn6wFUEPlbyFgT5Hb+l0yOY=; b=L9AoUr2wyg0u+woe h/mIenrzyjjUQj3+H0OqNNE1ifR/4+1jC/pGGOcRW2O3Fr6e/jND1+rANqW3eSe9 nzxNdOI4nxP1rV/Dl5pz7LXEELqXyNgBqZtum/dI2gLk9T9N3m/kcWNC5hSEq6M0 mryvZNhKVJiinOyaYOFYTiyCsmstDkd96kfj8ZC+Ux5t4+b7NCKgumlmHrrwVMc3 PpxkdfhnhjTCZZGOp/H59g/pD+OMEq13wlb6QStqfb4+KyWP/qFgxJkqAgnPbE6q hldJIUhh5nj66a5w8a1xKXYZqdKevDvCaa6hBHWoz92s/GMAaNZZucoSHJbAZ96F PWsgrg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpe8u0dne-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 07:29:06 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35983ee9f3bso3542731a91.1 for ; Tue, 03 Mar 2026 23:29:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772609345; x=1773214145; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=acRVQGvlsUrqD0vKmGV4gn6wFUEPlbyFgT5Hb+l0yOY=; b=F1HHykAnOhndPh5bTIq4WpY0lS/d3stxXv82FBLWe5e+7oMAmR5Cl6WzqJYIMW4JWh jjx2BPa+igYnl4lFY3SsMke4u60eX9DG05+vsqNhGZi4UB/pNU9BonvyAiRjbUpaFdSN 7DipPw4Cl6lMu2TCp7/iqI9k7Kefym8XOWPtyXhFFpJnA4R54riUQns4s3+3SFbkA4np ACjdPdS5y0bLv+PudxKcmgbmHCETqOHXu4KxWKlqrTwawGgT5ZP64pTC10EHDrknF4Sa TGlCqLiL+fJT/Y04o75IBXuwp+r5GulbJfNMeh8DJuOo4GxYf8qcJK8CL/z3qzQEeFGB VxHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772609345; x=1773214145; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=acRVQGvlsUrqD0vKmGV4gn6wFUEPlbyFgT5Hb+l0yOY=; b=FaI/VN2y/kNlbDyhJaeEWhGUfsq4lZ82ZRS8dKWrxVQUUL6n8GNreqdhQS73wEKzrU MmjVt9XHc1q/7GtH4LtF++7516L8HetWvM6uDLEhWU3qBuUGgtcyKVpvjJqjwT3kB3JX 24dM6QMF5yZ3OmX0R/VQSOJny1q4vWW7gPIZgqSKQlv+zSRYIK7wauPY5H9bfjCiO96U 0jCCZ6J2ii62ImOLUQQEvYhL2c0Ke5WDo4wa+exiwRQjmEUE5ETSFeI2cAQ+bNLS2HKC TghqxdAQa28gLXbqh4XfLk52A0sqy+MhV4grItrBM1YMgxrAJCpbpAvYJhGEV3yoo76x uEAw== X-Forwarded-Encrypted: i=1; AJvYcCX7gdYp5ZGsapQhjz1rJobyFu7SuucxnsviAlsA6N4XHgefcXqWJjLj8ItjawVCTbUrzJuE2m+6tlYfoH8=@vger.kernel.org X-Gm-Message-State: AOJu0YwfFcjwXpzP+khB68p2onGIdzb26LpfhQLGOnTEIgBbsRk+GVAe QQjGRywx9WSEVEX34GzMLgii0rQ66fOdW+QdftLI3Zg3rWOvV4WJVHowvCROYEvrK4JscYugHXG oKK4PFSzbSWdzeiH1jNfVuFSEt1OpAa+1PmMWCxVInk7hqay1D8RfNt1UWdSFdALLzA0= X-Gm-Gg: ATEYQzy7C51h9KjL+QuEwVx3lhthrfX0kSU7jjoxc+mfYvXgc6vgG57pXLrt/tD7K4F ImEtAxO1PLN72VIWukVqKu+fM5kr4y+gKiBKflhc0zszHN+KSXkT4xtZMT2ccCsoSl027Q5APoZ Gc0axuQ9QjXuqpqDcgkef3ZFMwD3F1f0fk0d1PPjkDpuyTzCwszfEaXLVvDx/kHkG7OfgEqp+i4 mvo2Ru1F94V5LD4KnDE2FSzx73P0UY/+mRaUKROoi8NBqnvYUWw2yaEaOARc234sh3OTt4ulDzE 84Xs1k7saLqwhM/gFsuHlMsx3nMwhQmsoz8q76/j2dIUKPcyw73QXrFD5f5xWAy0HOZRwZLmqtZ 4uQFaCLT/bGKB7Xmv1sSBfDagjYQKTCj6PKXglEaM8IiplwIDEg== X-Received: by 2002:a17:90b:2792:b0:349:19a8:e00e with SMTP id 98e67ed59e1d1-359a6a7ca47mr1074415a91.31.1772609345235; Tue, 03 Mar 2026 23:29:05 -0800 (PST) X-Received: by 2002:a17:90b:2792:b0:349:19a8:e00e with SMTP id 98e67ed59e1d1-359a6a7ca47mr1074400a91.31.1772609344684; Tue, 03 Mar 2026 23:29:04 -0800 (PST) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359aa403c57sm96394a91.13.2026.03.03.23.29.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 23:29:04 -0800 (PST) Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle To: Krzysztof Kozlowski Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Abhinaba Rakshit References: <20260217052526.2335759-1-neeraj.soni@oss.qualcomm.com> <20260217052526.2335759-2-neeraj.soni@oss.qualcomm.com> <20260217-berserk-puma-of-focus-bcbe82@quoll> <21a87714-cd11-4217-a2aa-82fddc3a8530@kernel.org> <544925d0-cf32-6b2a-548e-d6f7cc517581@oss.qualcomm.com> <01085021-c116-46de-a0ce-730455620cb2@kernel.org> <32b7763b-ba44-4341-8528-be97d6607354@kernel.org> <06967254-7fa6-218e-db8a-8e4a118a7d24@oss.qualcomm.com> <3339ddcb-d0f5-4117-99fd-f3f158b7903d@kernel.org> From: Neeraj Soni Message-ID: <04f83e93-5866-9747-b5f8-109ae3c16368@oss.qualcomm.com> Date: Wed, 4 Mar 2026 12:58:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <3339ddcb-d0f5-4117-99fd-f3f158b7903d@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: kbUQKa4BL0dat0LwUfu5Mcq9hGcrvXcv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA1OSBTYWx0ZWRfX4Dt27lelstbn dprHf3O2t0KjO6oxi0hcKFiiwKUKqqCifDGDYmq1BuqpnTXttaTZTJsrOHEALa9Q5uD+2oYfSBI ZKAV+1abWL0ssJqGDBp6Sgw2CIUwNPy4QKaVdzEbwbu9OfdXe+U1om9aHZ1PgfFzQyB7lC5rFpR wYkiZRg7gYVD+p8Aeg4gCHoiZPMDAJVwL2Vk9xJ+kCcfYfXFNIS9KzYQa9W0qtyrLu6WrKKEK8+ /e9REyyGJYgf3o67xsYaA+BlAiO7XvoCwtrGM+0jRdWTZAtYsjTNA+aidPMcPBA3zOAVgA5bixG +PjNN6LKG2c2kaMzkn+LJCKloyuuh1PCyS1X1+f0uxxx7SsS+jsyJ2hKGFJOGVMbV/Rs7Pa9yGP jYi5Ba4COVX0FHHiBTTFuDRREZYOLksSlg4teKbQIGS9TH8Cmg/WQrkfcRhqa79UogpklbZJYba oiER18r3VHdaxotSGwQ== X-Authority-Analysis: v=2.4 cv=FpAIPmrq c=1 sm=1 tr=0 ts=69a7df42 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=RyUJWM3ohA95taQL8aIA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: kbUQKa4BL0dat0LwUfu5Mcq9hGcrvXcv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_02,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040059 On 3/2/2026 10:08 PM, Krzysztof Kozlowski wrote: > On 02/03/2026 12:25, Neeraj Soni wrote: >> >> >> On 3/2/2026 2:27 PM, Krzysztof Kozlowski wrote: >>> On 02/03/2026 08:48, Krzysztof Kozlowski wrote: >>>> On 02/03/2026 08:45, Neeraj Soni wrote: >>>>> >>>>> >>>>> On 2/19/2026 1:57 PM, Krzysztof Kozlowski wrote: >>>>>> On 19/02/2026 06:38, Neeraj Soni wrote: >>>>>>>>> >>>>>>>>> + - if: >>>>>>>>> + required: >>>>>>>>> + - qcom,ice >>>>>>>>> + then: >>>>>>>>> + properties: >>>>>>>>> + reg-names: >>>>>>>>> + not: >>>>>>>>> + contains: >>>>>>>>> + const: ice >>>>>>>> >>>>>>>> And reg is still 4? This is not correct syntax. You need to define >>>>>>>> proper and final constraints per each device. I would write example, but >>>>>>>> why... more things you could just ignore. >>>>>>>> >>>>>>> I had included changes for reg in v3: >>>>>>> https://lore.kernel.org/all/20260206112053.3287756-2-neeraj.soni@oss.qualcomm.com/ >>>>>>> >>>>>>> but those were not reviewed so i assume them to be incorrect and dropped it. >>>>>>> Will fix this in next patch and post. >>>>>>> >>>>>> Patch v3 was also not correct, because SDHCI v5 devices should have 1 or >>>>>> 2 entries, not 1-3 as previous patch said. >>>>>> >>>>> This is not clear to me. Here: >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n80 >>>>> it says the entries should be 1-4 and there are no v5 specific constraints. >>>> >>>> There are, just scroll. >>> >>> Here: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n212 >>> >> Yes i had looked at this but, as i understand, this constraints the minItems: not the >> maxItems: and in your comment here: >> >> https://lore.kernel.org/all/21a87714-cd11-4217-a2aa-82fddc3a8530@kernel.org/ >> >> you expect v5 entries to be constrained to 1-2 and not 1-3. So, as i understand from here: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n78 >> >> the v5 can have 1-4 entries without "qcom,ice" and 1-3 with it which is what i had posted. > > We have long discussion and you are just not replying to the problem. I > am done here. I wrote already what is wrong and what I expect. > > Repeating the same as before in the FIRST comment: Your patch allows > incorrectly four reg entries for v4 and there reg entries for v5. > Sure. I will test and post the new patch with constraints for v4 and v5. > That's a NAK. > > Best regards, > Krzysztof > Regards, Neeraj