From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF1F846F for ; Wed, 11 Mar 2026 00:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773187472; cv=none; b=FRLEy5e0hnjv10So1ukQmGzVUfd1t5erDZvsH3hCS6CtyxMzYcX1j7/27TTtEWih82SInCHvd8slxff4w/038ApuIrzVovpxrY9j5yrHF1ULhClSiBgh9PsvaWznZiwSx/1eTmwuuE0R+mH3huYFqZKiJFMJujCpoS9zaQWHKB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773187472; c=relaxed/simple; bh=+43BOdwo7VXiTUsgxdy44JLwgVIf885ihZJy1GIB76E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KeTTOUtWc1SXyISM1lCRT1rZ6LPT963O5Wku4xBkn/OIKRhyTmCRr5n6P9Ie7ucAnWWP9Mlr/j9BxnD+2cCFWFqMInktP2/hluRwOdxjIlug8adso9/9i3rOz/BskvJtEYhudNa8dgr+uahIoKu04fd89fo/PTVL5atw2aQgM7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ViAirm3o; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ViAirm3o" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-466f935a82fso2251244b6e.0 for ; Tue, 10 Mar 2026 17:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773187468; x=1773792268; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UyycAT2xnAdXjbETtQQr3m+mbib4kFnv3znRqdNWGp8=; b=ViAirm3osrVbeKYxqIwJquIRPqf7j7Ct/h10HSGJCuzHbQ+xNoWOqRm5x2iGD3bKIN gSo7/nsHTZkTcOZIbxCGO/QWQ6PSbHh3QUk7CyVD65VB60Mi5Qk+lSC6q/8nSobaySXp STUqXGpov3Vo4AxXqM1AzTqN8CnZlbBXArj2O8DjAMfbWBGaXf0EZC9e3/UZ5bMeIRCZ HtbX0ws/VCcgyTO5MF3NtmfII0EMEZSW3mzCVmHn8+Pj0op+4VKpDLURRDzfdJVY/1lF 14ZKnNeLykDQgguwn+u0eizWHoEkwHv42ObQCXiG0qbzIgil3Dd1Uo/m1PxHjCumj72C h54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773187468; x=1773792268; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UyycAT2xnAdXjbETtQQr3m+mbib4kFnv3znRqdNWGp8=; b=NcWMY1ykn3PH3TQ98sHiMYrSUKPwMgNKzKxu+UMRS8vVsG0c66hlU2ijQxZTRwV0V6 4v1W/eaofC/Tw0YxPCrvyv50uXjLD4io9t+HivWhc4R+q3WrhGzJFQjNO66fp1d9Rhkj A3ZPi1fS1NpsEkCdXePqlnuGPKAPe1SQrCN5bRXUzhBYATaduCgNP+Yvvca311tVOEIY LZTxVYoMhf8LmDTir3f/cMRRdm1HqQnfCjI8pc3/tCgMgKYj7FU7KjUyLM14yeH5VADh PUno193rRMLTrAHo8GyasyFc6y7YQe2pDljMfJdtEtA07xq0kw5FGO7lINP1AAjZ6SRY inQQ== X-Forwarded-Encrypted: i=1; AJvYcCWnlXSF2U4FwLs+YhqJYM+matr+YAd3ehODm8TBedHeIWeoaxkIJkLsCpzrvwpsv9ipT0Ru88afBmB+q8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwcO+kwLFnhpc4xBrfyfdy6q8obYbm8QzZm56uxHMVyhg5STkjW K1VXH9UMUUqlRVURtuKmxAnfKTQ26SBpRz6IlmdLzUsYLR6gtKpOVDnzPZa0w/PXCzo= X-Gm-Gg: ATEYQzwHm0FCBqTPGwKijIpnIJN4DzqERL7shpLA5h0YAhzk36S8x1Ob6znmqzVeXUl 4u29wBxiLq+UM7KwA1lWoCeIB6d9StUVVrdvsmmgnJUVifQsB4xsxkNa6wYasIeMvQ1WMOv+58e ehIR6wM8OMfxYlW7KTWyBkFAmYz4vrhFgcA2MwfH8FlNPFXHxe3SDq/6bKFVuYWlMQJm+ZZ6xVr IRtgdU4FpYTHczcSQVX7j87WmGChBy4lDzZ35v+Hl/7p6suWwi3yY27rBMcEiQg7xN8yNfukdLW fND1jw6SWi9O/Fx8XxbnolQyFWp+AKwRyHAmHIw01FHvLa3NVad2WyBoGUb1/y1rhP0DmU7Kft2 xXKj1GtAJEQFmBRrWepA+JiBOG2cYw8bBDvDm4JPQaC+RmBt9R74SyOrztq1MsmYCNKGNk0/WmK Yff1i/Nf6ljmgdXk4GlvZdfVj58NPfO14U0VeGKY9rUDUW6rSJUyk4NB5hlH8NJ4h3ZnSNrlm1J A== X-Received: by 2002:a05:6808:14c8:b0:450:b249:718c with SMTP id 5614622812f47-46733547c85mr330873b6e.31.1773187468063; Tue, 10 Mar 2026 17:04:28 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:82ac:f3fe:2e5f:ec03? ([2600:8803:e7e4:500:82ac:f3fe:2e5f:ec03]) by smtp.gmail.com with ESMTPSA id 5614622812f47-46734160cebsm233690b6e.7.2026.03.10.17.04.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 17:04:26 -0700 (PDT) Message-ID: <04ffc988-f4ce-47f8-a998-66d2553d88af@baylibre.com> Date: Tue, 10 Mar 2026 19:04:24 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] iio: st_sensors: simplify cleanup using __free To: Sanjay Chitroda , jic23@kernel.org, m.tretter@pengutronix.de, mchehab@kernel.org, p.zabel@pengutronix.de, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, pure.logic@nexus-software.ie Cc: nuno.sa@analog.com, andy@kernel.org, kernel@pengutronix.de, kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz, marcelo.schmitt1@gmail.com, maudspierings@gocontroll.com, hverkuil+cisco@kernel.org, ribalda@chromium.org, straube.linux@gmail.com, dan.carpenter@linaro.org, lukagejak5@gmail.com, ethantidmore06@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, tglx@kernel.org, mingo@kernel.org, sun.jian.kdev@gmail.com, weibu@redadmin.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, skhan@linuxfoundation.org References: <20260310200513.2162018-1-sanjayembedded@gmail.com> <20260310200513.2162018-4-sanjayembedded@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260310200513.2162018-4-sanjayembedded@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/10/26 3:05 PM, Sanjay Chitroda wrote: > From: Sanjay Chitroda > > Replace manual cleanup logic with __free attribute from cleanup.h. This > removes explicit kfree() calls and simplifies the error handling paths. > > No functional change intended for kmalloc(). > > Signed-off-by: Sanjay Chitroda > --- > drivers/iio/common/st_sensors/st_sensors_core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c > index dac593be5695..f641b62e692b 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_core.c > +++ b/drivers/iio/common/st_sensors/st_sensors_core.c > @@ -501,14 +501,14 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev, > > byte_for_channel = DIV_ROUND_UP(ch->scan_type.realbits + > ch->scan_type.shift, 8); > - outdata = kmalloc(byte_for_channel, GFP_DMA | GFP_KERNEL); > + u8 *outdata __free(kfree) = kmalloc(byte_for_channel, GFP_DMA | GFP_KERNEL); Even better would be to not alloc new memory at all. We could probably reuse buffer_data from struct st_sensor_data for this. > if (!outdata) > return -ENOMEM; > > err = regmap_bulk_read(sdata->regmap, ch->address, > outdata, byte_for_channel); > if (err < 0) > - goto st_sensors_free_memory; > + return err; > > if (byte_for_channel == 1) > *data = (s8)*outdata; > @@ -517,9 +517,6 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev, > else if (byte_for_channel == 3) > *data = (s32)sign_extend32(get_unaligned_le24(outdata), 23); > > -st_sensors_free_memory: > - kfree(outdata); > - > return err; Should be able to change this to `return 0;` now. > } >