From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D346738F928 for ; Mon, 29 Jun 2026 05:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711309; cv=none; b=LDYbBvZOZyyherQTY/DWlcr/IXgABfPt8Vp0RAHh3V/PQGg/RB/pEAKITbuV8CME7h4MgbthEXtBDUzP4Ypm1Fm1oa3wmickc3BeYyqJ0TH33M2HH1yAdjzIWBFvoUdnsuYmqbWLtQEmmFHqxsMrwIHUA7Lrf5vCJOSQY2BZvFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711309; c=relaxed/simple; bh=NUHkiulByDcPD0LAw9zMG3d04+sAsSZ07dBbYP1Ch6Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hfWIgJ1stBnEoPOFV3QDG9vJR25aRTp0z6nN9tyzT69AdR4/WQxG3KATVSNZfUHNcwx1G7UwWYwup2fcL5AezKI1Wc8dKHHOU7eGYjW97Coq0xANoyzpvrkTngJ1NonmmEF4ti0DLYlU/gQkxD8VADNBgLmsBzDOBLVAf50zUG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=P0itAd6v; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="P0itAd6v" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 611CC1A2D; Sun, 28 Jun 2026 22:34:55 -0700 (PDT) Received: from [10.164.19.15] (unknown [10.164.19.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 80DDB3F836; Sun, 28 Jun 2026 22:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782711299; bh=NUHkiulByDcPD0LAw9zMG3d04+sAsSZ07dBbYP1Ch6Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P0itAd6vODdm2NYbl3qHV3hGeNp2VIPcAJ/V9Ivgot/IaB5bbw9qP+/3uXqGQgVT/ Yejr5kGsMbjZHOz47M9TnzmUdCks/F2WlQ9k8+M8r07TABDjtKigA3YQ2GB6XbV7/a 42wDAWuyfBStSLIydd/5uh9Z5opV+pcGsHnzDr0g= Message-ID: <05021709-829b-46ac-92c8-fe64507d99e7@arm.com> Date: Mon, 29 Jun 2026 11:04:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] arm64/vmalloc: Allow arch_vmap_pte_range_map_size to batch multiple CONT_PTE To: Wen Jiang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com Cc: baohua@kernel.org, Xueyuan.chen21@gmail.com, rppt@kernel.org, david@kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, ajd@linux.ibm.com, linux-kernel@vger.kernel.org, jiangwen6@xiaomi.com, shanghaoqiang@xiaomi.com References: <20260618084726.1070022-1-jiangwen6@xiaomi.com> <20260618084726.1070022-3-jiangwen6@xiaomi.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260618084726.1070022-3-jiangwen6@xiaomi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/06/26 2:17 pm, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > Allow arch_vmap_pte_range_map_size to batch across multiple CONT_PTE > blocks, reducing both PTE setup and TLB flush iterations. > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > --- > arch/arm64/include/asm/vmalloc.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h > index 4ec1acd3c1b34..787fd17b48e2c 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -23,6 +23,8 @@ static inline unsigned long arch_vmap_pte_range_map_size(unsigned long addr, > unsigned long end, u64 pfn, > unsigned int max_page_shift) > { > + unsigned long size; > + > /* > * If the block is at least CONT_PTE_SIZE in size, and is naturally > * aligned in both virtual and physical space, then we can pte-map the > @@ -40,7 +42,9 @@ static inline unsigned long arch_vmap_pte_range_map_size(unsigned long addr, > if (!IS_ALIGNED(PFN_PHYS(pfn), CONT_PTE_SIZE)) > return PAGE_SIZE; > > - return CONT_PTE_SIZE; > + size = min3(end - addr, 1UL << max_page_shift, PMD_SIZE >> 1); > + size = 1UL << __fls(size); Nit: I'd rather use rounddown_pow_of_two() : __fls is confusing : ) Reviewed-by: Dev Jain > + return size; > } > > #define arch_vmap_pte_range_unmap_size arch_vmap_pte_range_unmap_size