From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Miaoqian Lin" <linmq006@gmail.com>,
"Joel Stanley" <joel@jms.id.au>,
"Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>,
"Patrick Venture" <venture@google.com>,
"Robert Lippert" <roblip@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq
Date: Fri, 22 Jul 2022 11:44:31 +0930 [thread overview]
Message-ID: <0503175d-944d-4ffa-ba39-ff99797e78a1@www.fastmail.com> (raw)
In-Reply-To: <20220603123904.30714-1-linmq006@gmail.com>
On Fri, 3 Jun 2022, at 22:09, Miaoqian Lin wrote:
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
prev parent reply other threads:[~2022-07-22 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 12:39 Miaoqian Lin
2022-07-22 2:14 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0503175d-944d-4ffa-ba39-ff99797e78a1@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roblip@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®