From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB3D3B4EB2 for ; Tue, 7 Apr 2026 12:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566295; cv=none; b=S4uiJi3l2GUeIRJo4LtKmw6o1xzuDvBadxEERFubfAgXdGnIuky9e9xzYt8nQdvoe4z1wlpyP8jO+iYU7n6jsJQ2dYA8tZjHnyHNKyL/Pe2u5DrjvFEyy2YzK1h4qKZIcrAs/jzd/zywB8tEG9JIyFyAEqyAIVhx68lTYH4clFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566295; c=relaxed/simple; bh=c6fKxssJtIj3CIJdNmGZs6AiMnNPplX+dnIRE+mMbDE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CC66FSgJfZCshzv4wKs6JZ85zNpTEkGWeYF/511BZLBzJGH/oN6DF2tgunOqkw8Cg9ROweGHBGVcmgCJ/S9mSx1kF8IF4MnSI13g1AB/eAqtF7IRxCRhRRjp3mI80ayVXYW2L3OJwh1oTJp/MVq/Yi8sbOLqrwRGpU/HpM/23Ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Z374labG; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Z374labG" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso20506115e9.1 for ; Tue, 07 Apr 2026 05:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775566293; x=1776171093; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=7M2L5Q2b/RxLVV6QJQb6U42CemJltMVdvNn+W75xc98=; b=Z374labGMsq5MVaf2cBMlYbWrom55pJxJ5Ap/MZCuos+oq+Hkk5cCZUoaUVHqyu6Lq MMi/eF88W57q8V8QhTqRINu9e4tEnL3NhlQkoUNY+YPz/+p0jHLlEr2VDuHdvkxUlh8+ cnzYU3JYyFBT29FAkwxzbcblHHGAYOOM9xmlb7R08Qt4OxOQoiWlT7OtNMTudbH71izU WduhvVVxEBrMdl8QGc/mkr7e5tWpUTZ9w9YCTMxsoqKJfW5xauEgHNp4fxcluyBJ9Q+Y M/07JPpDeBpLM59CpU69KPxUwdLCrMAd7PfAhT23ak56OkW8o27w8cHYM8fyvE9769PK UTVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775566293; x=1776171093; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7M2L5Q2b/RxLVV6QJQb6U42CemJltMVdvNn+W75xc98=; b=ZIpgKQCob24Ph7gEOwvj0HI40PVuTMEriqNcUnYa8SIqi/1/BMNQmmh/POczdTRPOf XYhB32/cJ7huE31GfCc3UBmOxlEZK0fpVjsB6xXPzV9dBPkxbMRSNvHmwYDqmffWegko Rfq4cZ0VA9v/DTGorESAPaJU2p4PExf5SyuWBLyv1z0Kofji2jIkq65syKCvh3Vvqhqh AnxE49+7KGUbZQDdJIQNNO/OQQELcewUA2bwuopERPeU8qDtOQJKsi5h0vMX9zzunajd QmTVi97AHVgr1oJhuFdnebv71nHJMeHn2MoP8AsXHBFzp1fm+bBwslQt0sdk6qKR/A3G 5cMA== X-Forwarded-Encrypted: i=1; AJvYcCViZHH5U5kCm7MZ7102YlbZRf8XvjWGlEHkKrF1/1HQY0k+f5CexW8d1gLTNdGQ7dMtq43kxJDyGWLdBIE=@vger.kernel.org X-Gm-Message-State: AOJu0YxLDioQ45E24RTkryG+OVWQEbMiymrUiwfFwNuwgkDZH2i+eMUx u+SsW+b+HVrHgYnEMZl+xaMZoy/G2Il8hgL1Umyvvj8hW3IoQdPOcFkVuRsyLFVJAb8= X-Gm-Gg: AeBDieuqtlgs2Agamn7vU5MHeVbONsSyMmO5RrF5wkls4DJIs/5gZnr/BPuhbp0orbS wOJ346CfGMxJDJv6grRTW2r1H4P8oWrn+4rSlpYa1Rko1B0GbYtYcQkRqTO2A29mru/++bFYzXv ELhwFyv/zjFT4GlK/XS8kTBGUmCuCY7+0Swl2M65dAz5jaSAhs87OfTGI+gcSikXVEQTvs/X23X Cwrunbm/TT23d/AHP5Gn2iULylOVWo+3ubld2dwpf4j1nGRVYbPapTIGj9DLIMXm/1hQvvLFU2f f7/6M32Hgdwubxvq9WPA3/4hpJGik8BXkfn5gd9SSDgwtPE0PwXk/9doFcn/zsb4YsBsHRsAaNj yF7sGoj5OyEPSkl2+WFNWs4xkjXiA6VgqcqbbJMwqtkcdgxIR+XezUUwM0/kskLnuNiyYAnfVxc mg75lykQS3U8HIgAb4j/kljTi20R+wylvapd7yyuedKST87hJs6RwQR3fZAbw= X-Received: by 2002:a05:600c:c0cf:b0:485:3c2e:60d5 with SMTP id 5b1f17b1804b1-4889945f8e8mr147405115e9.2.1775566292578; Tue, 07 Apr 2026 05:51:32 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [185.218.67.101]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488b64f03afsm122587285e9.0.2026.04.07.05.51.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 05:51:31 -0700 (PDT) Message-ID: <050a2494-88e6-4c15-beae-2e97f3b1cace@suse.com> Date: Tue, 7 Apr 2026 15:51:29 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mce: Restore MCA polling interval halving To: Borislav Petkov , "Li,Rongqing(ACG CCN)" Cc: "Luck, Tony" , Thomas Gleixner , Ingo Molnar , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Yazen Ghannam , "Zhuo, Qiuxu" , Avadhut Naik , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" References: <20260114135034.GAaWefKm97-CkbEp4P@fat_crate.local> <20260207115142.GBaYcnTp7maUDVv3Nc@fat_crate.local> <20260210150117.GBaYtIPfsP0Txw7iIc@fat_crate.local> <3748e8c7057a4182bc2a361b44dda51b@baidu.com> <3431b52760444d209f8460059264cc13@baidu.com> <20260306152903.GEaaryvxD9BTT7Fd10@fat_crate.local> <20260316134411.GBabgJK1RFUG3zrTrx@fat_crate.local> <20260406224915.GAadQ4azQ7IRsTjnXD@fat_crate.local> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260406224915.GAadQ4azQ7IRsTjnXD@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7.04.26 г. 1:49 ч., Borislav Petkov wrote: > Ok, > > finally. :-\ > > Pls run it to make sure it DTRT for you too. > > Thx. > > --- > From: "Borislav Petkov (AMD)" > Date: Mon, 16 Mar 2026 16:12:00 +0100 > Subject: [PATCH] x86/mce: Restore MCA polling interval halving > > RongQing reported that the MCA polling interval doesn't halve when an > error gets logged. It was traced down to the commit in Fixes: because: > > mce_timer_fn() > |-> mce_poll_banks() > |-> machine_check_poll() > |-> mce_log() > > which will queue the work and return. > > Now, back in mce_timer_fn(): > > /* > * Alert userspace if needed. If we logged an MCE, reduce the polling > * interval, otherwise increase the polling interval. > */ > if (mce_notify_irq()) > > <--- here we haven't ran the notifier chain yet so mce_need_notify is > not set yet so this won't hit and we won't halve the interval iv. > > Now the notifier chain runs. mce_early_notifier() sets the bit, does > mce_notify_irq(), that clears the bit and then the notifier chain > a little later logs the error. > > So this is a silly timing issue. > > But, that's all unnecessary. > > All it needs to happen here is, the "should we notify of a logged MCE" > mce_notify_irq() asks, should be simply a question to the mce gen pool: > "Are you empty?" > > And that then turns into a simple yes or no answer and it all > JustWorks(tm). > > So do that. > > Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector") > Reported-by: Li RongQing > Signed-off-by: Borislav Petkov (AMD) > Link: https://lore.kernel.org/r/20260112082747.2842-1-lirongqing@baidu.com Much cleaner and simpler, Reviewed-by: Nikolay Borisov