mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock
Date: Mon, 13 Dec 2021 14:47:24 +0100	[thread overview]
Message-ID: <050bb635-4462-793c-dcd4-97335ca2932c@microchip.com> (raw)
In-Reply-To: <20211209102542.254153-1-tudor.ambarus@microchip.com>

On 09/12/2021 at 11:25, Tudor Ambarus wrote:
> Naming clocks is a good practice. The atmel-quadspi driver supports
> an unnamed clock for the peripheral clock in order to be backward
> compatible with old DTs, but it is recommended to name the clocks
> on new DTs. The driver's bindings file requires the clock-names
> property, so name the clock.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Queued in at91-dt branch for 5.17.
Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/sama5d2.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 801969c113d6..09c741e8ecb8 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -288,6 +288,7 @@ qspi0: spi@f0020000 {
>   				reg-names = "qspi_base", "qspi_mmap";
>   				interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
> +				clock-names = "pclk";
>   				#address-cells = <1>;
>   				#size-cells = <0>;
>   				status = "disabled";
> @@ -299,6 +300,7 @@ qspi1: spi@f0024000 {
>   				reg-names = "qspi_base", "qspi_mmap";
>   				interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 53>;
> +				clock-names = "pclk";
>   				#address-cells = <1>;
>   				#size-cells = <0>;
>   				status = "disabled";
> 


-- 
Nicolas Ferre

      reply	other threads:[~2021-12-13 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 10:25 Tudor Ambarus
2021-12-13 13:47 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=050bb635-4462-793c-dcd4-97335ca2932c@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®