mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Pan Bian <bianpan2016@163.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure
Date: Mon, 5 Dec 2016 10:00:52 +0100	[thread overview]
Message-ID: <050e52af-7f58-1d46-51c0-ac314b99212f@suse.com> (raw)
In-Reply-To: <1480926142-19882-1-git-send-email-bianpan2016@163.com>

On 05/12/16 09:22, Pan Bian wrote:
> Variable err is initialized with 0. As a result, the return value may 
> be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
> the bug, initializing err with "-ENOMEM".
> 
> v1 is reviewed by: Juergen Gross <jgross@suse.com>

I didn't say so.

> Signed-off-by: Pan Bian <bianpan2016@163.com>

Now I do:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

> ---
>  drivers/xen/xenbus/xenbus_probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 33a31cf..8178d5b 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -702,7 +702,7 @@ static int __init xenbus_probe_initcall(void)
>   */
>  static int __init xenstored_local_init(void)
>  {
> -	int err = 0;
> +	int err = -ENOMEM;
>  	unsigned long page = 0;
>  	struct evtchn_alloc_unbound alloc_unbound;
>  
> 

  reply	other threads:[~2016-12-05  9:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05  8:22 Pan Bian
2016-12-05  9:00 ` Juergen Gross [this message]
2016-12-08  6:58 ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=050e52af-7f58-1d46-51c0-ac314b99212f@suse.com \
    --to=jgross@suse.com \
    --cc=bianpan2016@163.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®