From: David Engraf <david.engraf@sysgo.com>
To: Tony Lindgren <tony.lindgren@linux.intel.com>
Cc: pmladek@suse.com, rostedt@goodmis.org, john.ogness@linutronix.de,
senozhatsky@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Remove console options before decoding the name
Date: Wed, 16 Sep 2026 08:51:49 +0300 [thread overview]
Message-ID: <05107b0b-394d-4023-bbd5-8efef73f5542@sysgo.com> (raw)
In-Reply-To: <aqotk6oiOdp01hAF@tlindgre-MOBL1>
On 16.09.26 08:48 wrote Tony Lindgren:
> On Wed, Sep 16, 2026 at 08:32:18AM +0300, David Engraf wrote:
>> --- a/kernel/printk/printk.c
>> +++ b/kernel/printk/printk.c
>> @@ -2646,24 +2646,22 @@ static int __init console_setup(char *str)
>> if (_braille_console_setup(&str, &brl_options))
>> return 1;
>>
>> + /* Decode str into name, index, options */
>> + options = strchr(str, ',');
>> + if (options)
>> + *(options++) = 0;
>> +
>
> How about update the comment for why it needs to be first?
>
> Maybe something like:
>
> Decode str into options first. The options may contain a ':' used also
> for DEVNAME.
Okay I can update the comment if there are no other objections.
Best regards
- David
next prev parent reply other threads:[~2026-09-16 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 5:32 David Engraf
2026-09-16 5:48 ` Tony Lindgren
2026-09-16 5:51 ` David Engraf [this message]
2026-09-17 6:05 ` [PATCH v2] " David Engraf
2026-09-17 14:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05107b0b-394d-4023-bbd5-8efef73f5542@sysgo.com \
--to=david.engraf@sysgo.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony.lindgren@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®