From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A01F42E007 for ; Wed, 12 Aug 2026 11:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786535436; cv=none; b=IaxRke4rR5I4sYcXdNqUjfTkkLuytAyQpsNhxlKR942zojlGe3eFbr94YSWb/br9fnZGM56bu9dSAYOp+Dufmk/JTYsR908jk2zY9m7vlF2uxLTTdON9JmNE4vk9EbcSHWhl4L9kNB2jcfJjOQO0ozDWy2UVhYr0doOTgblOICE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786535436; c=relaxed/simple; bh=Oku+8IujH5h3PsOuNLHiIYYZ+VKD/ke6Wkl84JHaGtY=; h=Message-ID:Date:MIME-Version:From:Subject:To:References: In-Reply-To:Content-Type; b=DQ08G0kX1dEWf7CNI3cc23yIP5WOGKhpHhkjfqNJcfB2KbiUzY75tYFPzVF77KDvvTe9JaXLMEYEiLNlySNg61cmF+h4t5tQwIaJIkmhWyihUQg2Ntk0/Wd+IXaQfOw12RJb/nRYRc2H6EBv4uv52SiaR722cjHlGNpZpsQTDWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GeP4aYGo; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GeP4aYGo" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4956242332dso7625305e9.2 for ; Wed, 12 Aug 2026 04:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1786535432; x=1787140232; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=chiiEuqdm3rLXI4bL+ILzzFBPrfb/qRhs+Zf8F1BEQA=; b=GeP4aYGotMF12l4VxN8q6oREOzSbtnm7VRavHa6F5hrlrABCNReKVLJuNeKsQhDkip /jWLrI7ivFoDvwbn+fVmtEYWgj2jDfQmf0J5i4J3cB64SFBYzJknb+IZbPAqs3pORy3q ONB+8+wXaY63HKLrT8GBHueJaa0/W6TUp4mrFK7Qta6jeinxc46B1MoD5pxIW6NHLpyC EUgPZer3ivT/gVfQbMSJxVVY2Syql+K9CypYge7DXfyr4CdKsvDj01swlUX5bamKjMau rhcx7zPvydckZ4LGG/sMrE7hDkA8pYGXz8/68qEJXrpFqSKNUtcaYA4PxPTO61EBvw+J zILw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786535432; x=1787140232; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=chiiEuqdm3rLXI4bL+ILzzFBPrfb/qRhs+Zf8F1BEQA=; b=EEp2bkL669tkFsVCCoG14H+AXsZLqgS276rKdOvwb2geltTtNUPiIPzW2Y54aXEyZd MSQI230HVmnHgRReb/A+0ridvILb5lyg5H8t6fxYjEwepFACoWJnIXcF0I3HpNKUw6Np mIaie+cskq+k1yqisPa3MXFHM/slhiDcOwbl2yKfRy1Xkrvp+LDs/3AM8Jqm6cRFPGsH tbzgfuhfw9LUJGADW9rD8cORqtElcLuVUnvF2BBZd4uJNQPDpR9tBL9PI9LNxhGca56+ rEwc/nrLNvEzSeRADlnElye0e70LcGk5X1vczI0GFRZMXDMsdq+Igki023bRa//ufGa5 FKqA== X-Forwarded-Encrypted: i=1; AHgh+RoTH/p7RQ9AZtb85TCRhLslK39p6z0+sHVjmbY6W+sPMQygXYC0VTpS5UZ4ZLH4GFoWo5TupmGRWobQY3w=@vger.kernel.org X-Gm-Message-State: AOJu0YxoVjbVPVbUXF8Vd+7GmP0d5huBQo9PhFqqSOg5cRw90rGBXvvi 2LoyfYFe6MyzrGSY3EtU/ZTxCvrM3Y2x+zdwpPPhK52rafQOPneN9fXkxFycYgf0VSfpKTxAzWB +Oz7yGWw= X-Gm-Gg: AR+sD11385yFN8oIWKBfwbdP02mt9bVfv0IsekMtfaEthFCUOatPzjEvGia46R3JyEw X2UXFOpXoAFmRiPBcSTN97c5swnAO0SxzhEB0OjiZJzRxY8KjsgkE1Bd75Fc/8HA4NTVkJ1c49t vAz1VnVGAqJTNBpY/HH7UEBcgzyOPubvi4QWGYr566tKmnqRDi1L1c7A6GLMqb210hthGjwCza1 01oNiwR37TnBJ07D4hgerADyT/9JnBmtB1hUtCJP42XzVBpn5EqjuDAaJy+PzvymO7lWr3SWRpC g6vvXzRyYq/YP1VzGNes7D22euaEVb2zk8PuwHx2FURtCsdHgPgTcO+f9CFR/J1WlCyvnntGsAU ablK8EtCkuBc/ld5+T6Sj9Ci+uW4A1MvFsmOWaFCP7r2R+8+3vnzY3MiGMG0VAQAeEXetkiGu+U 3wvePS2iYmJivxsIfNmfb00m4SLVWyqoyOt7WNMsC/pvRTF+vgqW7EtXQIfvQvBoA7vEsVSJJ5P eF3y5rh+Wl44avwyJtRuY3iYClSYkNhG6tCJSgwaI6bZZvLbQ== X-Received: by 2002:a05:600c:a213:b0:499:737c:8a8b with SMTP id 5b1f17b1804b1-4997c12c7e8mr38151595e9.12.1786535432234; Wed, 12 Aug 2026 04:50:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:405d:735d:801e:de34? ([2a01:e0a:106d:1080:405d:735d:801e:de34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997d2ba6e5sm18736205e9.1.2026.08.12.04.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 04:50:31 -0700 (PDT) Message-ID: <0510ced7-7c91-4b00-bc7f-773a9b6517eb@linaro.org> Date: Wed, 12 Aug 2026 13:50:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/6] drm/panel: Use devm_mipi_dsi_attach in BOE panels To: Osama Abdelkader , luca.ceresoli@bootlin.com, Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerry Han , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260811165037.12437-1-osama.abdelkader@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260811165037.12437-1-osama.abdelkader@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 8/11/26 18:50, Osama Abdelkader wrote: > Use the managed MIPI DSI attach helper in BOE panel drivers and drop the > corresponding manual detach calls from remove paths. > > Signed-off-by: Osama Abdelkader > > v2: > - break long description lines. > - add Signed-off-by tag Please move the changelog after the ---, or use a tool like b4 to handle that automatically. > --- > drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-himax8279d.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-td4320.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 4 +--- > drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 7 +------ > 6 files changed, 6 insertions(+), 37 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > index 84c21c62a43e..6a74523a6614 100644 > --- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > +++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > @@ -359,7 +359,7 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&boe->panel); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret < 0) { > dev_err(dev, "Failed to attach to DSI host: %d\n", ret); > return ret; > @@ -371,12 +371,6 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) > static void boe_bf060y8m_aj0_remove(struct mipi_dsi_device *dsi) > { > struct boe_bf060y8m_aj0 *boe = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = mipi_dsi_detach(dsi); > - if (ret < 0) > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > - > drm_panel_remove(&boe->panel); > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > index 4a8560b4b899..ffcb63f65b75 100644 > --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c > +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c > @@ -881,7 +881,7 @@ static int panel_probe(struct mipi_dsi_device *dsi) > if (err < 0) > return err; > > - err = mipi_dsi_attach(dsi); > + err = devm_mipi_dsi_attach(&dsi->dev, dsi); > if (err < 0) > drm_panel_remove(&pinfo->base); > > @@ -891,12 +891,6 @@ static int panel_probe(struct mipi_dsi_device *dsi) > static void panel_remove(struct mipi_dsi_device *dsi) > { > struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi); > - int err; > - > - err = mipi_dsi_detach(dsi); > - if (err < 0) > - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err); > - > drm_panel_remove(&pinfo->base); > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-td4320.c b/drivers/gpu/drm/panel/panel-boe-td4320.c > index 23558a76dd72..704d5a9c13e7 100644 > --- a/drivers/gpu/drm/panel/panel-boe-td4320.c > +++ b/drivers/gpu/drm/panel/panel-boe-td4320.c > @@ -204,7 +204,7 @@ static int boe_td4320_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&ctx->panel); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret < 0) { > drm_panel_remove(&ctx->panel); > return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > @@ -216,12 +216,6 @@ static int boe_td4320_probe(struct mipi_dsi_device *dsi) > static void boe_td4320_remove(struct mipi_dsi_device *dsi) > { > struct boe_td4320 *ctx = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = mipi_dsi_detach(dsi); > - if (ret < 0) > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > - > drm_panel_remove(&ctx->panel); > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c > index a70a2e58f88c..94cc675973e6 100644 > --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c > +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c > @@ -393,7 +393,7 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&ctx->panel); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret < 0) { > dev_err_probe(&dsi->dev, ret, > "Failed to attach panel to DSI host\n"); > @@ -407,8 +407,6 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi) > static void boe_th101mb31ig002_dsi_remove(struct mipi_dsi_device *dsi) > { > struct boe_th101mb31ig002 *ctx = mipi_dsi_get_drvdata(dsi); > - > - mipi_dsi_detach(dsi); > drm_panel_remove(&ctx->panel); > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c > index 20b6e11a7d84..2ab7764d4094 100644 > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c > @@ -200,7 +200,7 @@ static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi) > > drm_panel_add(&ctx->panel); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret < 0) { > drm_panel_remove(&ctx->panel); > return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); > @@ -212,12 +212,6 @@ static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi) > static void boe_tv101wum_ll2_remove(struct mipi_dsi_device *dsi) > { > struct boe_tv101wum_ll2 *ctx = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = mipi_dsi_detach(dsi); > - if (ret < 0) > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > - > drm_panel_remove(&ctx->panel); > } > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > index 150dff3ab6c3..7d2672578dd8 100644 > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > @@ -1765,7 +1765,7 @@ static int boe_panel_probe(struct mipi_dsi_device *dsi) > > mipi_dsi_set_drvdata(dsi, boe); > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret) > drm_panel_remove(&boe->base); > > @@ -1775,11 +1775,6 @@ static int boe_panel_probe(struct mipi_dsi_device *dsi) > static void boe_panel_remove(struct mipi_dsi_device *dsi) > { > struct boe_panel *boe = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = mipi_dsi_detach(dsi); > - if (ret < 0) > - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); > > if (boe->base.dev) > drm_panel_remove(&boe->base); Otherwise looks good. Thanks, Neil