From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B67CA377AA6; Fri, 31 Jul 2026 08:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785486142; cv=none; b=lMTDSguYPmSqx201FrnhN1njObYLWYyn0kCDQHJRH/MR8qLCfgH5AJ59DCkxrqo/h2fXlGyME8PxU1Or0L2VxT87nzFv31SQ8diJ3VM4Cmps92wrZkd8eH4IG0a5XElpf8pzi1yEJ2guSoQYF4MOAj5VtVrRnd98codEzLIIwd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785486142; c=relaxed/simple; bh=U3VF5GVtmF6lcujs3Aw2aw4lWnm3cWfi8jxe7nQsYII=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q/RTfhkj19/XqzirdYOmBKqwYNmwSnToIW1ENu2HIXcTW8JeGeuoNz5qLOqLvzv25e/z1aI8RXsvZdKB0FnGR4FvhrqyhHJq0Om+Op36SkG/9ABDU69ul/oWBNxuv22A/YMsX33SMl7nlOPrLBejqOrQAAjd/m6EyQeWlv1jPIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=PdKXgchQ; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="PdKXgchQ" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B517F204C; Fri, 31 Jul 2026 01:22:14 -0700 (PDT) Received: from [10.2.212.8] (e134344.arm.com [10.2.212.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CB243F86F; Fri, 31 Jul 2026 01:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785486138; bh=U3VF5GVtmF6lcujs3Aw2aw4lWnm3cWfi8jxe7nQsYII=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PdKXgchQSaPWd6Qqp7ZXf+fRSlN/nIBZFB7ThXTVUpIRgsXojUyEzYNFKfR8RpvW5 hytA+PZJBQqX1FfHuuFBrx+U3ONiF/5IAyxhI2+W+7HxonlwTBgktj7OzeNPU7zGqp Zq0dU53MV8JGm6V1wBb6GU8tUAvu5/rvGMy0uWeA= Message-ID: <0511693b-5855-4419-8e1a-8444cfdd4253@arm.com> Date: Fri, 31 Jul 2026 09:22:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: [PATCH v6 10/10] arm_mpam: detect and enable MPAM-Fb PCC support To: Andre Przywara , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260730152539.2712312-1-andre.przywara@arm.com> <20260730152539.2712312-11-andre.przywara@arm.com> Content-Language: en-US From: Ben Horgan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Andre, On 7/31/26 09:16, Andre Przywara wrote: > Hi Ben, > > On 7/30/26 18:13, Ben Horgan wrote: >> Hi Andre, >> >> On 7/30/26 16:25, Andre Przywara wrote: >>> The Arm MPAM-Fb specification [1] describes a protocol to access MSC >>> registers through a firmware interface. This requires a shared memory >>> region to hold the message, and a mailbox to trigger the access. >>> For ACPI this is wrapped as a PCC channel, described using existing >>> ACPI abstractions. >>> >>> Add code to parse those PCC table descriptions associated with an MSC, >>> and store the parsed information in the MSC struct. >>> There can be multiple PCC channels, and each channel can serve multiple >>> MSCs, so we need to keep track of the channel usage, using a list and >>> a refcount. >>> >>> This will be used by the MPAM-Fb access wrapper code. >>> >>> [1] https://developer.arm.com/documentation/den0144/latest >>> >>> Signed-off-by: Andre Przywara >>> Tested-by: Ritwick Sharma >> Ritwick gave his Tested-by for the series on v5. Any reason to just add the tag on this patch? > > submitting-patches.rst says: > "Both Tested-by and Reviewed-by tags, once received on mailing list from tester or reviewer, should > be added by author to the *applicable* patches when sending next versions." > > I think this system relies on MPAM-Fb, so he couldn't test each patch in isolation, but "just" that > MPAM-Fb works, which is what only patch 10/10 enables. > > So I find tags given for the whole series always tricky to handle, but in this case I figured patch > 10/10 would be the right target. Ok, yes. I agree with that principle - I'm still learning how these things are done. Perhaps patch 8 would have been relevant too. Thanks, Ben > >> I guess patch 9 has significant enough changes to drop tags but I don't see it for the others. > > Well, even smaller changes could ruin a whole thing, but IIUC in this case Ritwick's setup doesn't > even enable error IRQs, so this part wasn't tested anyway. > > Cheers, > Andre. >