From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4532C32938E for ; Sat, 31 Jan 2026 16:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769875921; cv=none; b=NRVCCXNOEc0OUr5czEk2CpCxIH8Ji8Ky3TLEZEh2R1/VlqgqFtuk3fenlHYSIKRgYsew6/x55N9Zx2fwm5QdNigozOV8hSWM0EBaDSRNUmU6hwV663DiYHrvOq/Jo5wTMMFAoaPqjdEq5Edpr7gIUIdHlbCy0KCj1Q+sIBQ+/rA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769875921; c=relaxed/simple; bh=NGykyrCEun0ee1EVP6m9B/0TcaQSlwXO9GN4B5I/nt8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=klLKYpzikgVs6fYujVszO+irZIrnVsbt6vw9awem1Oeb+yqP8cEuxlMWX5OiVrT7axmbavN1A4FVNo+TLwvUlXNEGbV2TOiaGkUbLJ0M8uBO5wy2aelCUJupTvSbF6vzdVoOzTbrm5QKJEGSRsCztaxacnHtAQc4Z8/RI27uur4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=WrfCOFVk; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="WrfCOFVk" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so2632462f8f.3 for ; Sat, 31 Jan 2026 08:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1769875919; x=1770480719; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wt0nnlrDw5KDdKulBm7PH7mhYJ/mBjNcrtsksFarjCk=; b=WrfCOFVkfxIOeZ9NwHVVa0oDP0+p/tZFqJjc/OHkYIceVvJ3cJiBIgOC7vOPb1olqs r5ZsVK2uBgfo2ivCkGTyCg4WuehcqVt9RyeF+DWQNM8viRsOB4VkniIrwUjMaOibKaOC 1t0Hp90ev03KpBAaFmZCUdRWw2wNQB3FcsG/eBTTO9VRT5boDU6T0b7A3O8bbDQlT48J BDlY7BCdHE+UNTWAJPbdhn7NEURvS60O0znC88Yn0BQ+Gw/Yf6bvS7MjS5McUNtvjrGw xkJzQ9U3gKfD4BKl6zJGuYGwe+JU+JHjMjQl59XPXSTjAxEUG9JZ5/KOHsCvHWWyRMIa AkIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769875919; x=1770480719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wt0nnlrDw5KDdKulBm7PH7mhYJ/mBjNcrtsksFarjCk=; b=ttKoQN5Ybv5AWbFURqYL6bxJL0BULnPfhWep9P+OM6feNig4DXOQtksFY4LbHtsiwL SywhJSmXu94ynnu4/SFDRhfupwoivW5nCgK/o7gJbjLQcztrCIYRj4sqmXer2bsxHEZj N9GmZzROo9mIpG0Que2qnBhewKYejKSnQiQeCmMBdkJOTGd/yfsby8yJVwF1ydhcAskH vOlWN31ZW1Hhm4DNMyPc0Ew5GLFRbB1wtOUDt6FhxUUUydJ/gJxzJMCdqawXtCA2mdtz gdkabno+SE5xjddRKNIs7Z39Im9RSl08oh7JBrr4RIVxO9tmLjW5/Pm9DmTraacrdhNM d2Uw== X-Forwarded-Encrypted: i=1; AJvYcCWBKyGr6UPRUIKCCAZowXpizg0+cb3mfKd78wFVvLRGOEkS6Y/HBQE3TyPc2vWQk9eMvZofUqClfuEbrN8=@vger.kernel.org X-Gm-Message-State: AOJu0YwAJ9R7G8rZNIRdBE3mGZ6RP3F/ZgjJipCccb4gLrGtdzT6yMud 182+ge6jo/gSAiSxLyIlhBFXxPMd05UWlu6MclXyawu3gxVIVcCgpkzr/bUROyzJZwE= X-Gm-Gg: AZuq6aKg4acf0ibZETHJw/eBX1UWs8EneTsqzDN7xZcEFuufSbl/Ytn7eD9Jutt0b/k GHO/X1FpoAAFx3k3ojmKNOImq3E9W5a1eyxh0Byw+qWLjztr7vxGdWiGKf8KHWnZARwUfNx8gbt O2pSOuMi6NCC2PDLzW/zOK6dmOlC8eaBXPt0gDzkZ/6gdhzMnzlwSnZ1w3XOxXBCnlUDUZi31Yz 232GFMis5CXBQNdq+gPm1wtJ+jgiMWBRt2SBphrfhvyyP2vRNiuDxOd2Gt6KVHpP7X9fO4x5dfs 4/T3DU/vMvJs6bubokHTLtWFYJjKBDAKuh5gJhcm35WRlUD30vknLveDDzOeFJ2EMXrLBVoX7hm njIDW6dv2ev3X681FtCHC2ZS5U3JCOUYXQb7SU7qrdeddnm90yChzCIJH7Xb/DllIOwxuPr+GeC VSUWiCBqxBzRfPpFY4Fw== X-Received: by 2002:a05:6000:1a8d:b0:431:3a5:d9b2 with SMTP id ffacd0b85a97d-435f3aa7aa0mr9659948f8f.39.1769875918622; Sat, 31 Jan 2026 08:11:58 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm30719880f8f.16.2026.01.31.08.11.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jan 2026 08:11:58 -0800 (PST) Message-ID: <05128a16-553d-49d5-b09d-2c3e03cb4421@tuxon.dev> Date: Sat, 31 Jan 2026 18:11:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/19] nvmem: microchip-otpc: Expose UID registers as 2nd nvmem device To: Alexander Dahl Cc: Nicolas Ferre , Alexandre Belloni , Ryan Wanner , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Srinivas Kandagatla References: <20260120143759.904013-1-ada@thorsis.com> <20260120154502.1280938-1-ada@thorsis.com> <20260120154502.1280938-8-ada@thorsis.com> Content-Language: en-US From: Claudiu Beznea In-Reply-To: <20260120154502.1280938-8-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/26 17:44, Alexander Dahl wrote: > For SAM9X60 the Product UID x Register containing the Unique Product ID > is part of the OTPC registers. SAMA7G5 as well. > We have everything at hand here to just > create a trivial nvmem device for those. Please massage a bit the patch description to match https://www.kernel.org/doc/html/v6.13/process/submitting-patches.html#describe-your-changes > > Signed-off-by: Alexander Dahl > --- > > Notes: > v3: > - no changes > > v2: > - Use dev_err_probe() for error reporting (thanks Claudiu) > - Move required register definition over here from removed patch > > drivers/nvmem/microchip-otpc.c | 38 +++++++++++++++++++++++++++++++++- > 1 file changed, 37 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > index 34c0d7611f3e4..b35ed13b004bb 100644 > --- a/drivers/nvmem/microchip-otpc.c > +++ b/drivers/nvmem/microchip-otpc.c > @@ -25,10 +25,14 @@ > #define MCHP_OTPC_HR (0x20) > #define MCHP_OTPC_HR_SIZE GENMASK(15, 8) > #define MCHP_OTPC_DR (0x24) > +#define MCHP_OTPC_UID0R (0x60) > > #define MCHP_OTPC_NAME "mchp-otpc" > #define MCHP_OTPC_SIZE (11 * 1024) > > +#define MCHP_OTPC_UID_NAME "mchp-uid" > +#define MCHP_OTPC_UID_SIZE 16 I think you can drop these as they are used (individually) in a single place. > + > /** > * struct mchp_otpc - OTPC private data structure > * @base: base address > @@ -230,6 +234,16 @@ static int mchp_otpc_init_packets_list(struct mchp_otpc *otpc, u32 *size) > return 0; > } > > +static int mchp_otpc_uid_read(void *priv, unsigned int offset, > + void *val, size_t bytes) > +{ > + struct mchp_otpc *otpc = priv; > + > + memcpy_fromio(val, otpc->base + MCHP_OTPC_UID0R + offset, bytes); Include for this one? > + > + return 0; > +} > + > static struct nvmem_config mchp_nvmem_config = { > .name = MCHP_OTPC_NAME, > .type = NVMEM_TYPE_OTP, > @@ -239,6 +253,15 @@ static struct nvmem_config mchp_nvmem_config = { > .reg_read = mchp_otpc_read, > }; > > +static struct nvmem_config mchp_otpc_uid_nvmem_config = { > + .name = MCHP_OTPC_UID_NAME, Should the type be filled here? > + .read_only = true, > + .word_size = 4, > + .stride = 4, > + .size = MCHP_OTPC_UID_SIZE, > + .reg_read = mchp_otpc_uid_read, > +}; > + > static int mchp_otpc_probe(struct platform_device *pdev) > { > struct nvmem_device *nvmem; > @@ -269,8 +292,21 @@ static int mchp_otpc_probe(struct platform_device *pdev) > mchp_nvmem_config.size = size; > mchp_nvmem_config.priv = otpc; > nvmem = devm_nvmem_register(&pdev->dev, &mchp_nvmem_config); > + if (IS_ERR(nvmem)) { > + return dev_err_probe(&pdev->dev, PTR_ERR(nvmem), > + "Error registering OTP as nvmem device\n"); > + } > > - return PTR_ERR_OR_ZERO(nvmem); > + mchp_otpc_uid_nvmem_config.dev = otpc->dev; > + mchp_otpc_uid_nvmem_config.priv = otpc; > + > + nvmem = devm_nvmem_register(&pdev->dev, &mchp_otpc_uid_nvmem_config); > + if (IS_ERR(nvmem)) { > + return dev_err_probe(&pdev->dev, PTR_ERR(nvmem), > + "Error registering UIDxR as nvmem device\n"); > + } > + > + return 0; > } > > static const struct of_device_id __maybe_unused mchp_otpc_ids[] = {