mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Larsson <andreas@gaisler.com>
To: Stian Halseth <stian@itx.no>,
	davem@davemloft.net, sparclinux@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, david.laight.linux@gmail.com,
	glaubitz@physik.fu-berlin.de, thuth@redhat.com,
	regressions@lists.linux.dev, nroach44@nroach44.id.au,
	kaloz@kernel.org, unixpro1970@gmail.com
Subject: Re: [PATCH v3 2/2] sparc64: remove dead THREAD_SIZE branches for non-8K pages
Date: Wed, 7 Oct 2026 11:08:42 +0200	[thread overview]
Message-ID: <051531af-e41a-4d4b-a1cf-07bf69c4037c@gaisler.com> (raw)
In-Reply-To: <20260927212913.3237082-2-stian@itx.no>

On 2026-09-27 23:29, Stian Halseth wrote:
> Commit 15b9350a177b ("sparc64: Only support 4MB huge pages and 8KB
> base pages.") made 8K the only base page size, so PAGE_SHIFT is
> always 13 here and the else branches have been dead since. Remove
> them.
> 
> Fixes: 15b9350a177b ("sparc64: Only support 4MB huge pages and 8KB base pages.")
> Suggested-by: Andreas Larsson <andreas@gaisler.com>
> Signed-off-by: Stian Halseth <stian@itx.no>
> ---
>  arch/sparc/include/asm/thread_info_64.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h
> --- a/arch/sparc/include/asm/thread_info_64.h
> +++ b/arch/sparc/include/asm/thread_info_64.h
> @@ -99,13 +99,8 @@
>  #define FAULT_CODE_BLKCOMMIT	0x10	/* Use blk-commit ASI in copy_page */
>  #define	FAULT_CODE_BAD_RA	0x20	/* Bad RA for sun4v		   */
>  
> -#if PAGE_SHIFT == 13
>  #define THREAD_SIZE (4*PAGE_SIZE)
>  #define THREAD_SHIFT (PAGE_SHIFT + 2)
> -#else /* PAGE_SHIFT == 13 */
> -#define THREAD_SIZE PAGE_SIZE
> -#define THREAD_SHIFT PAGE_SHIFT
> -#endif /* PAGE_SHIFT == 13 */
>  
>  /*
>   * macros/functions for gaining access to the thread information structure
> @@ -128,11 +123,7 @@
>  #endif
>  
>  /* thread information allocation */
> -#if PAGE_SHIFT == 13
>  #define THREAD_SIZE_ORDER	2
> -#else /* PAGE_SHIFT == 13 */
> -#define THREAD_SIZE_ORDER	0
> -#endif /* PAGE_SHIFT == 13 */
>  
>  #define __thread_flag_byte_ptr(ti)	\
>  	((unsigned char *)(&((ti)->flags)))
> --
> 2.53.0

Reviewed-by: Andreas Larsson <andreas@gaisler.com>

Picking these two up to my for-next.

Thanks,
Andreas

  reply	other threads:[~2026-10-07  9:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  7:57 [PATCH 0/1] sparc64: unify thread stack sizing and add explicit 32KB stack Tony Rodriguez
2026-05-19  7:57 ` [PATCH 1/1] " Tony Rodriguez
2026-05-19  8:56   ` Nathaniel Roach
2026-06-16 14:18   ` Andreas Larsson
2026-06-16 19:58     ` David Laight
2026-06-18  5:53       ` Andreas Larsson
2026-06-18  7:29         ` Tony Rodriguez
2026-06-18  8:57           ` David Laight
2026-06-18 10:32         ` David Laight
2026-05-19 10:02 ` [PATCH 0/1] " David Laight
2026-05-19 23:57   ` Tony Rodriguez
2026-05-20 13:41     ` David Laight
2026-08-31 17:27       ` Stian Halseth
2026-08-31 17:29 ` [PATCH v2] sparc64: increase kernel thread stack size to 32K Stian Halseth
2026-08-31 18:25   ` Tony Rodriguez
2026-08-31 18:54     ` Stian Halseth
2026-08-31 20:18       ` Tony Rodriguez
2026-08-31 21:05         ` Stian Halseth
2026-09-02  3:30           ` Tony Rodriguez
2026-09-11  7:13             ` Stian Halseth
2026-09-27 20:49   ` Imre Kaloz
2026-09-27 21:29     ` [PATCH v3 1/2] " Stian Halseth
2026-09-27 21:29       ` [PATCH v3 2/2] sparc64: remove dead THREAD_SIZE branches for non-8K pages Stian Halseth
2026-10-07  9:08         ` Andreas Larsson [this message]
2026-09-27 21:30     ` [PATCH v2] sparc64: increase kernel thread stack size to 32K Stian Halseth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=051531af-e41a-4d4b-a1cf-07bf69c4037c@gaisler.com \
    --to=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=david.laight.linux@gmail.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=kaloz@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nroach44@nroach44.id.au \
    --cc=regressions@lists.linux.dev \
    --cc=sparclinux@vger.kernel.org \
    --cc=stian@itx.no \
    --cc=thuth@redhat.com \
    --cc=unixpro1970@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®