From: Judith Mendez <jm@ti.com>
To: Ulf Hansson <ulf.hansson@oss.qualcomm.com>
Cc: Ulf Hansson <ulfh@kernel.org>, Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: mmc: Add post-power-off-delay-ms property
Date: Fri, 17 Jul 2026 14:05:28 -0500 [thread overview]
Message-ID: <0516579f-cd02-45ca-bdf9-7381a52e5a96@ti.com> (raw)
In-Reply-To: <305cf4be-2f45-49b9-b933-05ac41092685@ti.com>
Hi Ulf,
On 7/17/26 12:40 PM, Judith Mendez wrote:
> Hi Ulf,
>
> On 7/17/26 5:21 AM, Ulf Hansson wrote:
>> On Fri, Jul 17, 2026 at 1:26 AM Judith Mendez <jm@ti.com> wrote:
>>>
>>> Add post-power-off-delay-ms property to MMC controller common.
>>>
>>> This property shall be used to specify delay if needed after
>>> deasserting power during MMC power cycles.
>>
>> Please clarify with some additional information from the cover-letter,
>> like "specify custom delays after MMC power off to work around
>> hardware issues such as slow RC circuites on MMC VDD rails."
>>
>>>
>>> Signed-off-by: Judith Mendez <jm@ti.com>
>>> ---
>>> .../devicetree/bindings/mmc/mmc-controller-common.yaml | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-
>>> common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-
>>> common.yaml
>>> index 3d7195e9461c3..3ff68d32a308f 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
>>> @@ -275,6 +275,14 @@ properties:
>>> not available.
>>> default: 10
>>>
>>> + post-power-off-delay-ms:
>>
>> For mmc-pwrseq-simple we already have "power-off-delay-us", perhaps
>> better to re-use that name instead.
>
> Besides having the same dt property name as mmc-pwrseq-simple what is
> the benefit of switching to power-off-delay-us?
>
> All values will have to be in us instead of ms and thus will look a bit
> less clean in code. If it is just a naming preference, I do prefer
> the current name in this version, please let me know if we can keep:
> post-power-off-delay-ms.
>
Forgot to mention, we are using mmc_delay which takes ms, if we switch
to microsecond dt property, we would have to make conversions or not use
mmc_delay.
~ Judith
next prev parent reply other threads:[~2026-07-17 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 23:26 [PATCH 0/2] mmc: Add post-power-off-delay-ms support Judith Mendez
2026-07-16 23:26 ` [PATCH 1/2] dt-bindings: mmc: Add post-power-off-delay-ms property Judith Mendez
2026-07-17 0:35 ` Rob Herring (Arm)
2026-07-17 10:21 ` Ulf Hansson
2026-07-17 17:40 ` Judith Mendez
2026-07-17 19:05 ` Judith Mendez [this message]
2026-07-17 20:10 ` Judith Mendez
2026-07-16 23:26 ` [PATCH 2/2] mmc: core: Add post-power-off-delay-ms support Judith Mendez
2026-07-17 10:41 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0516579f-cd02-45ca-bdf9-7381a52e5a96@ti.com \
--to=jm@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@oss.qualcomm.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox