From: David Rientjes <rientjes@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Nikunj A. Dadhania" <nikunj@amd.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
dave.hansen@linux.intel.com, seanjc@google.com,
pbonzini@redhat.com, thomas.lendacky@amd.com,
michael.roth@amd.com, stable@kernel.org
Subject: Re: [PATCH v3] x86/sev: Add SEV-SNP guest feature negotiation support
Date: Tue, 3 Jan 2023 15:25:36 -0800 (PST) [thread overview]
Message-ID: <05171aad-bcef-a731-970f-726b393e3ad3@google.com> (raw)
In-Reply-To: <Y7QRkzxg1HW9wMCp@zn.tnic>
On Tue, 3 Jan 2023, Borislav Petkov wrote:
> On Tue, Jan 03, 2023 at 09:07:14AM +0530, Nikunj A. Dadhania wrote:
> > Currently, GHCBData[24:63] is unused. If we intend to use the bit range(40bits), GHCB spec
> > will need to be updated. And probably would not be enough.
>
> My fear too...
>
> > As the termination request is done using GHCB MSR protocol, exit codes cannot be used.
>
> We need to figure out some other way of communicating to the guest owner because
> of which feature the guest refused booting.
>
Yeah, this was exactly the thought. If the guest terminates because
SNP_FEAT_NOT_IMPLEMENTED, it seems necessary to provide information on
which feature(s) the guest is lacking an implementation for that the
hypervisor has enabled. Otherwise this becomes a frustrating trial and
error for the customer.
next prev parent reply other threads:[~2023-01-03 23:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 8:38 Nikunj A Dadhania
2023-01-02 11:23 ` David Rientjes
2023-01-02 15:20 ` Nikunj A. Dadhania
2023-01-02 19:42 ` Borislav Petkov
2023-01-03 3:25 ` Nikunj A. Dadhania
2023-01-02 20:02 ` Borislav Petkov
2023-01-03 3:37 ` Nikunj A. Dadhania
2023-01-03 11:29 ` Borislav Petkov
2023-01-03 23:25 ` David Rientjes [this message]
2023-01-03 13:40 ` Borislav Petkov
2023-01-04 4:26 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05171aad-bcef-a731-970f-726b393e3ad3@google.com \
--to=rientjes@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®