From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C74F2459C8; Wed, 16 Apr 2025 22:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744843570; cv=none; b=t9q3ChyccYzPw7eCT2zX+Op3IoRU8ABs1mV2rvBib3BkGFxcYoHiZeMLQk7r65kDbw0Uw5idhqpI4TbcCRfjykCbByNHuVFiqy+0unKnqP0uR5ow67xkc8wBBVqzLEPJZQJ/SztvmWXegkV9It3oT4Rsyu1kTjyTUebg7GM3Taw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744843570; c=relaxed/simple; bh=HVh5xJy/ANkBPHD/Sg1nDZZa4c6HM3ME7V4lUgnTxBE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=lf6PGkjx0HnhFmx8E/1+rzcfk17CS8iD93KPRC7aMlCv0XNX/+gLB76LQHXfMMKh619nvru9DD+tVgB/NX6N+m0cHG/VhNMEGzvMdH4x56xWEj1b1Pdx5vPor7Rv7RkihFFc3635bdGEbNCkgHKEMY0gLIJ4NORBHXUBXpWhD/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=NqKrFflU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="NqKrFflU" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53GMNdb7020536; Wed, 16 Apr 2025 22:45:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xNfrCvKLz1HL2/Ep2TIoQ6EJuGuvEvjrG/9oyVd/u88=; b=NqKrFflUuvmOzgIb tnKdyY7U46RSAItH7u6oAgSMZPHNeAlPVKEjevMzYAiY8KW9gPajHLwQEhB4ziYn G5Vkj1xOEgluDc6TeD5M9RtzyzbaEEB7KSYuTskmf5aOKEKogbEeGVDnxHYsOlp5 5RY34pNAqLPzzK/07Kr2NctqklzPqoQaQLpHI63oVqnaQCwaAVWkzwFi0C2Tflyw fOHcEOhyOS2WlLN6nLbQM/27oNOTpJBxIlap/w7q2olVx8GpnnLITVMfT25krb6E wT74ryb+bLR1DzYwahReYwS98oAzBlPRt1HQx/7xrGGMVIpjRA+3O1/Rf4fWyCsb VUly3Q== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yhbpvt5k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Apr 2025 22:45:49 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53GMjmYO017521 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Apr 2025 22:45:48 GMT Received: from [10.110.59.41] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 16 Apr 2025 15:45:48 -0700 Message-ID: <0517c37d-b1ba-466e-bffd-9f47b0d458d5@quicinc.com> Date: Wed, 16 Apr 2025 15:45:43 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/10] phy: qcom: Add M31 based eUSB2 PHY driver To: Vinod Koul , Melody Olvera CC: Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Philipp Zabel , Bjorn Andersson , "Konrad Dybcio" , Catalin Marinas , Will Deacon , , , , , , References: <20250409-sm8750_usb_master-v4-0-6ec621c98be6@oss.qualcomm.com> <20250409-sm8750_usb_master-v4-6-6ec621c98be6@oss.qualcomm.com> Content-Language: en-US From: Wesley Cheng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: tQ2iOfxn8lJ-9NvJwiHwGQLX2R8JqxPZ X-Proofpoint-GUID: tQ2iOfxn8lJ-9NvJwiHwGQLX2R8JqxPZ X-Authority-Analysis: v=2.4 cv=I+plRMgg c=1 sm=1 tr=0 ts=6800331d cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=hpYwsUs0O2kreVQoPgkA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-16_09,2025-04-15_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504160182 Hi Vinod, On 4/10/2025 4:53 AM, Vinod Koul wrote: > On 09-04-25, 10:48, Melody Olvera wrote: > >> +static int m31eusb2_phy_write_readback(void __iomem *base, u32 offset, >> + const u32 mask, u32 val) >> +{ >> + u32 write_val; >> + u32 tmp; >> + >> + tmp = readl_relaxed(base + offset); >> + tmp &= ~mask; >> + write_val = tmp | val; >> + >> + writel_relaxed(write_val, base + offset); >> + >> + tmp = readl_relaxed(base + offset); > > Why are you using _relaxed version here? > No particular reason. I think someone pointed this out previously, and I was open to use the non-relaxed variants, but I assume using the relaxed vs non-relaxed apis comes down to preference in this case. Thanks Wesley Cheng