From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE6421FFC4E for ; Wed, 8 Jan 2025 17:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736356460; cv=none; b=qxIjpj+VUZa4/EWmn06S0y36Ph93Orh/+99JpPdtmYKX9p2h7D3x+RgpSpQCDePrKzw5bpKQUqq1CJwYuMGKtSsnE9qauAAvtnLmIwa2M+Zh4e08ZaMemDvbqj4hF47ulIqYunJ5ZJkQ2HakyJXnW2MNaNLB9m+/Bb6WzZ0ox3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736356460; c=relaxed/simple; bh=aooA7LYXUoVys5fZ1anzMAbIybJlbE/gkMABOVVxI/g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=asVTIR1DuWobqJUaXwgALg/Xj0f+J+tAWodnL4IrbscC3OKpWmmbTr/OTn7XXfrDM413IRDWYSh5QnS5OIQ0OE/t7IeOXf8k3yIGfc40w8F/3FbN0Bu5yLW8BV0F0vptPop8LAmHCCO8bFQyN/OpNAp01F9uAYaaT2eN3R5zdgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=voBSnZUl; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="voBSnZUl" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3863c36a731so11955f8f.1 for ; Wed, 08 Jan 2025 09:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736356457; x=1736961257; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KQZuIYs4dJFxY5w9PNV/Pi3AUB4FBPjFOwxnGDPvk84=; b=voBSnZUlGz5/ZSiAk7P4IFcH71LssNfOqrzV8WHDXoTuCLqXn1hSxlgNspwrWfIqo3 poOJ9ZtB31vg9mXzGDS437JK9v4JHa+Mg2CyM5nJAXoZoRJHxc4xEFnyfeaVLr8QytWC f/qGNPCF1FcxArST4VEBqtWB6qtd83Y9ML2Otq99iLoyS4qiTifIf591cZABrQShU4Oq fLhnsnqAAVI1Zb7QxIPt3jBX3qpxOLSgrOP8VsydENwXWfDV9qe5qpaUrpD0u+pte2mx XFTRJXhb0gojJM4KiGBJiqmOm2/M9XCdwnwV9+wkeV+n015ABH01isUh/651qBbdltLv YW4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736356457; x=1736961257; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KQZuIYs4dJFxY5w9PNV/Pi3AUB4FBPjFOwxnGDPvk84=; b=MAKAqW9e4z5U1kfqSHW/L1tcR8YA3a2F8oYZSg/Zhl180Ogy7ucEaMuV/6r6gHIJP2 Vxit0Zf7FFjAKWjzMjrJulv8AxaHmX8v/1eZjFasgKgaWs2PhmMUKth2O/mAQRMGtj1c PtI1yiV6Wo+AeTF/54xdFYC5u+q+5O60vLshNTrogpje3B0UVQeqv8ZiYOoEeDwcvsI0 oDtkRNb8NWYS/2f/JDmdM+XW+vF4fCaEnNYlnTIUIkIuB9fSI7BRggl6BkMxJxuZtUHG WX3RWtzL42zo+VsJBtKqQF790+sKSESN2wXxpZdzoCUr+MJVPfm0Q+XdlRt8G2JfiDHe DbeA== X-Forwarded-Encrypted: i=1; AJvYcCWUrm4wTVcTT0b62o99107ocZymRG+b+cSINfCkdx0Fv/GJA606LWYcicTows6d8nTIcVgMOYfJ3zOthng=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu5BulDvAviDoBmCoX67SQW/0+hHNHSQaUwjBJ+6KzeRXiQuy5 gy6TDcIi6pPWwLs73RNA653lNkUeErrj7RD86Qcovw/ywrCFs4vjoGtR4qmt0GI= X-Gm-Gg: ASbGncvHSqhj9QkxiT/WTL353ONztWZLM8/UHoIO6WEgwriduEc3uL2BphDsGdSRbb6 evP/HSDOD7y4nnV0hXBucX1IgvIogy64mu+UhP069VVVL6NtPdPfAQF5BJ0M9JWSmErDh6o2nV/ 5xHmPmQ2twgn+E/PfHANlzrtoCUc09uKixXi06rTZ7v2M0D2ktavA9gEEVooYFj0vp7hDPxU6wQ WCQXVqwqGzbWh0lDVgZwZ18yU/jl/dqy4MlxXPASLfyf2TUl1xl9z/7iG4Ycg== X-Google-Smtp-Source: AGHT+IFmN2O6u5JhvIH2VcEzrI77cQ6Q1cDuRHrLNzPC9J6UpQtHIgTBqtUCzq6KiNRm740FpmamKQ== X-Received: by 2002:a05:6000:1862:b0:385:f6b9:e762 with SMTP id ffacd0b85a97d-38a8733068dmr3316575f8f.36.1736356457291; Wed, 08 Jan 2025 09:14:17 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e1a1sm52748082f8f.69.2025.01.08.09.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:14:17 -0800 (PST) Date: Wed, 8 Jan 2025 20:14:13 +0300 From: Dan Carpenter To: Dave Penkler Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Modernize gpib_interface_t initialization and make static Message-ID: <0518fba7-7c35-4a91-9354-6a32a35f2ed7@stanley.mountain> References: <20250108152942.17687-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250108152942.17687-1-dpenkler@gmail.com> The subsystem prefix is missing in the subject. On Wed, Jan 08, 2025 at 04:29:42PM +0100, Dave Penkler wrote: > All interface drivers were using the old style initialization of > this struct > > field : value; > > This generated the followng sparse warning, for example: > agilent_82357a/agilent_82357a.c:1492:1: warning: obsolete struct initializer, use C99 syntax > > Change the initialization to use the C99 syntax > > .field = value; > > This also resolves the checkpatch constraint of no indentation. > > These structs were also not declared as static, unnecessarily polluting > the symbol namespace and generating the following sparse warnings, > for example: > > agilent_82357a/agilent_82357a.c:1465:18: warning: symbol 'agilent_82357a_gpib_interface' was not declared. Should it be static? > > Declare them as static and remove any conflicting extern declarations > in the corresponding include files. The c99 initializers and the making the structs static would ideally be done in separate patches. Splitting up patches is kind of more art than science... regards, dan carpenter