Re: [PATCH v8 12/13] platform/x86/amd: hfi: Add debugfs support

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Tue, 18 Feb 2025, Mario Limonciello wrote:

> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> Add a dump of the class and capabilities table to debugfs to assist
> with debugging scheduler issues.
> 
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v8:
>  * s,for_each_present_cpu,for_each_possible_cpu,
> v3:
>  * Move idx to earlier line
> ---
>  drivers/platform/x86/amd/hfi/hfi.c | 35 ++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
> index 14378a0e09e21..79d065d7b6441 100644
> --- a/drivers/platform/x86/amd/hfi/hfi.c
> +++ b/drivers/platform/x86/amd/hfi/hfi.c
> @@ -13,6 +13,7 @@
>  #include <linux/acpi.h>
>  #include <linux/cpu.h>
>  #include <linux/cpumask.h>
> +#include <linux/debugfs.h>
>  #include <linux/gfp.h>
>  #include <linux/init.h>
>  #include <linux/io.h>
> @@ -74,6 +75,8 @@ struct amd_hfi_data {
>  	void __iomem		*pcc_comm_addr;
>  	struct acpi_subtable_header	*pcct_entry;
>  	struct amd_shmem_info	*shmem;
> +
> +	struct dentry *dbgfs_dir;
>  };
>  
>  /**
> @@ -235,6 +238,13 @@ static int amd_hfi_alloc_class_data(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static void amd_hfi_remove(struct platform_device *pdev)
> +{
> +	struct amd_hfi_data *dev = platform_get_drvdata(pdev);
> +
> +	debugfs_remove_recursive(dev->dbgfs_dir);
> +}
> +
>  static int amd_set_hfi_ipcc_score(struct amd_hfi_cpuinfo *hfi_cpuinfo, int cpu)
>  {
>  	for (int i = 0; i < hfi_cpuinfo->nr_class; i++)
> @@ -389,6 +399,26 @@ static int amd_hfi_metadata_parser(struct platform_device *pdev,
>  	return ret;
>  }
>  
> +static int class_capabilities_show(struct seq_file *s, void *unused)
> +{
> +	int cpu, idx;
> +
> +	seq_puts(s, "CPU #\tWLC\tPerf\tEff\n");
> +	for_each_possible_cpu(cpu) {
> +		struct amd_hfi_cpuinfo *hfi_cpuinfo = per_cpu_ptr(&amd_hfi_cpuinfo, cpu);
> +
> +		seq_printf(s, "%d", cpu);
> +		for (idx = 0; idx < hfi_cpuinfo->nr_class; idx++) {
> +			seq_printf(s, "\t%d\t%d\t%d\n", idx,
> +				   hfi_cpuinfo->amd_hfi_classes[idx].perf,
> +				   hfi_cpuinfo->amd_hfi_classes[idx].eff);

Please use %u for unsigned variables.

> +		}
> +	}
> +
> +	return 0;
> +}
> +DEFINE_SHOW_ATTRIBUTE(class_capabilities);
> +
>  static int amd_hfi_pm_resume(struct device *dev)
>  {
>  	int ret, cpu;
> @@ -468,6 +498,10 @@ static int amd_hfi_probe(struct platform_device *pdev)
>  
>  	schedule_work(&sched_amd_hfi_itmt_work);
>  
> +	amd_hfi_data->dbgfs_dir = debugfs_create_dir("amd_hfi", arch_debugfs_dir);
> +	debugfs_create_file("class_capabilities", 0644, amd_hfi_data->dbgfs_dir, pdev,
> +			    &class_capabilities_fops);
> +
>  	return 0;
>  }
>  
> @@ -479,6 +513,7 @@ static struct platform_driver amd_hfi_driver = {
>  		.acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
>  	},
>  	.probe = amd_hfi_probe,
> +	.remove = amd_hfi_remove,
>  };
>  
>  static int __init amd_hfi_init(void)
> 

-- 
 i.