From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751264AbeAUVPE (ORCPT ); Sun, 21 Jan 2018 16:15:04 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:41421 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbeAUVPC (ORCPT ); Sun, 21 Jan 2018 16:15:02 -0500 X-Google-Smtp-Source: AH8x2251Gm7TDZt4UTIGZm6KRM109GsihGXuo+5A76NuzDWnedXlzFOaAWKWWVvJfVWOiTTSUxrx1w== Date: Sun, 21 Jan 2018 13:14:58 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <20180121201049.GA23310@beacon.debie> References: <20180112064658.25019-1-aaron.ma@canonical.com> <20180112083940.p36qj6ltzzwtuhng@dtor-ws> <06bbeca0-8a90-8935-9be3-f154db0b9fe9@canonical.com> <20180112181830.ccpkltghgkj3oh3e@dtor-ws> <6a96ce54-9f8a-2424-1e48-34ec6445cb8f@canonical.com> <20180116230713.rppztybwe5ufhoxo@dtor-ws> <20180121201049.GA23310@beacon.debie> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported To: ulrik.debie-os@e2big.org CC: Aaron Ma , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Dmitry Torokhov Message-ID: <051BA339-04DD-4AF7-B7CA-BBB5401053D8@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w0LLF8sj012061 On January 21, 2018 12:10:50 PM PST, ulrik.debie-os@e2big.org wrote: >On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: >Hi Dmitry, > >> >> On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: >> > Will your patch go to stable kernel? >> > If yes, that's fine. >> >> Hmm, it looks like we need this patch after all as we do have screwy >> Lenovos with apparently 0x01 devices reporting 0 buttons. From >> https://bugzilla.kernel.org/show_bug.cgi?id=196253 >> >> thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown >> thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE >> >> psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: >0/0 >> >> I'll ask them to try my patch and if it is indeed 0x01 device I'll >apply >> your patch. > >It is quite strange. In the past,for commit 293b915fd9be >"Input: trackpoint - assume 3 buttons when buttons detection fails" >there was >success reported for lenovo e470 and I see the same success report in >that >bugzilla ticket. I can also report success on lenovo e570. > >But some seem to have problems, could it be that they are not including >that >commit in the kernel they are running ? Or did a bios upgrade change >the >behaviour ? >It would be best when we have a confirmation from a e470 owner that >without the >proposed patch from Aaron the middle button does not work on his e470, >and it >works with it. I suppose Lenovo changed the firmware, because if you take a look at bugzilla link I provided there is a box that does not fail the command but indeed responds with 0 as number of buttons. It still reports device ID 0x010e. Hi Ulrik, Thanks. -- Dmitry