From: Kirill Marinushkin <k.marinushkin@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
devel@driverdev.osuosl.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Anholt <eric@anholt.net>,
Michael Zoran <mzoran@crowfest.net>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()
Date: Fri, 23 Mar 2018 20:22:09 +0100 [thread overview]
Message-ID: <0524fb43-ed08-6c54-39ed-32bd96ccaca4@gmail.com> (raw)
In-Reply-To: <CAHp75VdYiySBzu99MYoBAZ8tORGP1R43z9d+=VRdktg+U=_ZDw@mail.gmail.com>
On 03/23/18 17:23, Andy Shevchenko wrote:
> On Thu, Mar 22, 2018 at 11:37 PM, Kirill Marinushkin
> <k.marinushkin@gmail.com> wrote:
>
>
>> +static void snd_devm_release(struct device *dev)
>> +{
>> + struct bcm2835_chip *chip = dev_get_drvdata(dev);
>> +
>> + kfree(chip);
>> +}
>> + device->release = snd_devm_release;
> This is not devm function, so, it would be rather called
> snd_bcm2835_release().
Ah, you mean "devm" in the names. Now I got it.
Agree, I will rename it to "snd_bcm2835_release()"
>
>> static struct snd_card *snd_devm_card_new(struct device *dev)
>> {
>> struct snd_card *card;
>> int ret;
>>
>> ret = snd_card_new(dev, -1, NULL, THIS_MODULE, 0, &card);
>> + if (ret)
>> return ERR_PTR(ret);
>>
>> return card;
>> }
> Same here. You removed anything related to devm here, so, please make
> function name consistent.
Good, I will rename it to "snd_bcm2835_card_new()"
> After addressing above, FWIW,
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-23 19:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 5:52 [PATCH] " Kirill Marinushkin
2018-03-06 12:14 ` Greg Kroah-Hartman
2018-03-06 17:42 ` Kirill Marinushkin
2018-03-13 19:34 ` [PATCH v2] " Kirill Marinushkin
2018-03-13 21:23 ` Andy Shevchenko
2018-03-15 5:57 ` Kirill Marinushkin
2018-03-21 15:03 ` Andy Shevchenko
2018-03-21 16:58 ` Kirill Marinushkin
2018-03-21 18:48 ` [PATCH v3] " Kirill Marinushkin
2018-03-21 19:24 ` Andy Shevchenko
2018-03-21 19:51 ` Kirill Marinushkin
2018-03-22 21:21 ` Kirill Marinushkin
2018-03-22 21:37 ` [PATCH v4] " Kirill Marinushkin
2018-03-23 16:23 ` Andy Shevchenko
2018-03-23 19:22 ` Kirill Marinushkin [this message]
2018-03-25 10:33 ` Andy Shevchenko
2018-03-25 10:44 ` Kirill Marinushkin
2018-03-25 13:03 ` Andy Shevchenko
2018-03-25 13:54 ` Kirill Marinushkin
2018-03-23 19:32 ` [PATCH v5] " Kirill Marinushkin
2018-03-25 10:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0524fb43-ed08-6c54-39ed-32bd96ccaca4@gmail.com \
--to=k.marinushkin@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mzoran@crowfest.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®