From: songchai <quic_songchai@quicinc.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v1] Coresight: Narrow down the matching range of tpdm
Date: Wed, 9 Oct 2024 17:20:26 +0800 [thread overview]
Message-ID: <0525c2a9-45a5-4654-aaf4-b0ab9e161884@quicinc.com> (raw)
In-Reply-To: <a7fc66fe-0fb3-4d2c-8f23-03ccd46a4766@arm.com>
On 10/9/2024 4:54 PM, Suzuki K Poulose wrote:
> On 09/10/2024 09:50, Songwei Chai wrote:
>> The format of tpdm's peripheral id is 1f0exx. To avoid potential
>> conflicts in the future, update the .id_table's id to 0x001f0e00.
>> This update will narrow down the matching range and prevent incorrect
>> matches. For example, another component's peripheral id might be
>> f0e00, which would incorrectly match the old id.
>>
>> Signed-off-by: Songwei Chai <quic_songchai@quicinc.com>
>> ---
>> drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c
>> b/drivers/hwtracing/coresight/coresight-tpdm.c
>> index b7d99e91ab84..8e2985d17549 100644
>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
>> @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev)
>> */
>> static struct amba_id tpdm_ids[] = {
>> {
>> - .id = 0x000f0e00,
>> - .mask = 0x000fff00,
>> + .id = 0x001f0e00,
>> + .mask = 0x00ffff00,
>> },
>> { 0, 0, NULL },
>> };
>>
>
> Please could you add "Fixes" tag for this ? You don't want an old
> kernel detect something else as TPDM, so this must go to stable kernels.
> Also, while at it, please could you intend the id and mask values with
> tabs, so it is easier to what exactly we are matching ? e.g,
Thanks for your quick response, Suzuki.
Corrected it in the new version!
>
>
> .id = 0x001f0e00,
> .mask = 0x00ffff00,
>
> Kind regards
> Suzuki
>
>
prev parent reply other threads:[~2024-10-09 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:50 Songwei Chai
2024-10-09 8:54 ` Suzuki K Poulose
2024-10-09 9:20 ` songchai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0525c2a9-45a5-4654-aaf4-b0ab9e161884@quicinc.com \
--to=quic_songchai@quicinc.com \
--cc=agross@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®