From: Dinh Nguyen <dinguyen@kernel.org>
To: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] arm64: dts: intel: fix dw-apb-timer clock initialisation on Agilex and Agilex5
Date: Wed, 2 Sep 2026 19:30:50 -0500 [thread overview]
Message-ID: <0525e219-c39d-47f2-aca3-d79c45b1f62f@kernel.org> (raw)
In-Reply-To: <cover.1779785788.git.adrian.ho.yin.ng@altera.com>
On 5/26/26 17:00, Adrian Ng Ho Yin wrote:
> The DesignWare APB timers on Intel Agilex and Agilex5 SoCs fail to
> initialise because their clock managers are platform drivers registered
> at core_initcall, which runs after time_init() where TIMER_OF_DECLARE
> callbacks fire. With clocks/clock-names in the DTS, the timer driver
> calls clk_get() at a point when the clock provider is not yet
> registered, causing the timers to never come up.
>
> Replace the clocks/clock-names reference in both DTSIs with a static
> clock-frequency of 100 MHz, which is the L4_SP clock rate configured
> by the bootloader. The dw-apb-timer binding explicitly supports this
> as an alternative when the clock framework is unavailable at probe time.
>
> Adrian Ng Ho Yin (2):
> arm64: dts: socfpga: agilex5: replace clocks reference with
> clock-frequency for dw-apb-timer
> arm64: dts: socfpga: agilex: replace clocks reference with
> clock-frequency for dw-apb-timer
>
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 12 ++++--------
> arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++--------
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
Do you want this to get backported to stable releeases? If so, please
append a Fixes tag.
I think the same patch can be applied to socfpga_stratix10.dtsi.
Thanks,
Dinh
prev parent reply other threads:[~2026-09-03 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 9:00 Adrian Ng Ho Yin
2026-05-26 9:00 ` [PATCH 1/2] arm64: dts: socfpga: agilex5: replace clocks reference with clock-frequency for dw-apb-timer Adrian Ng Ho Yin
2026-05-26 9:00 ` [PATCH 2/2] arm64: dts: socfpga: agilex: " Adrian Ng Ho Yin
2026-09-03 0:30 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0525e219-c39d-47f2-aca3-d79c45b1f62f@kernel.org \
--to=dinguyen@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®