mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	maxime.chevallier@bootlin.com, pavel@ucw.cz,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-leds@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: phy: dap8211r: add PHY LED control support
Date: Tue, 17 Nov 2026 14:36:05 +0100	[thread overview]
Message-ID: <052adff8-b1d4-4cf2-941c-cfb2725d13a0@lunn.ch> (raw)
In-Reply-To: <20261117114432.2794961-5-a.shimko.dev@gmail.com>

> +/*
> + * LED_COMCON force mode bits:
> + * bit 2   - FORCE_EN (enable force mode for this LED)
> + * bit 1:0 - FORCE_MODE (00 = OFF, 01 = ON, 10/11 = blink mode1/mode2)
> + *
> + * Only ON/OFF is supported.
> + */
> +#define DAP8211R_LED_COMCON		0xA00B
> +#define DAP8211R_LED_FORCE_EN_BIT	BIT(2)
> +#define DAP8211R_LED_FORCE_ON_BIT	BIT(0)

Given your comment, this last one is not strictly correct.

Otherwise, this looks O.K. Lets see what the LLM says.

	   Andrew

  reply	other threads:[~2026-11-17 13:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:44 [PATCH net-next v2 0/4] net: phy: dap8211r: add " Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 1/4] net: phy: dap8211r: fix kernel-doc comments for extended register helpers Artem Shimko
2026-11-17 13:29   ` Andrew Lunn
2026-11-17 11:44 ` [PATCH net-next v2 2/4] dt-bindings: net: dptel,dap8211r: add LED nodes Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 3/4] net: phy: dap8211r: add extended register write helper Artem Shimko
2026-11-17 13:30   ` Andrew Lunn
2026-11-17 11:44 ` [PATCH net-next v2 4/4] net: phy: dap8211r: add PHY LED control support Artem Shimko
2026-11-17 13:36   ` Andrew Lunn [this message]
2026-11-17 13:41     ` Artem Shimko
2026-11-17 13:49       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=052adff8-b1d4-4cf2-941c-cfb2725d13a0@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=a.shimko.dev@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®