From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F6CECDFB1 for ; Fri, 13 Jul 2018 09:19:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D9AB2124D for ; Fri, 13 Jul 2018 09:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D9AB2124D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729275AbeGMJdj (ORCPT ); Fri, 13 Jul 2018 05:33:39 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:59773 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726824AbeGMJdj (ORCPT ); Fri, 13 Jul 2018 05:33:39 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 743ED16E062B2; Fri, 13 Jul 2018 17:19:49 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.382.0; Fri, 13 Jul 2018 17:19:49 +0800 Subject: Re: [PATCH] DAC960: hide unused procfs helpers To: References: <20180713071610.14276-1-yuehaibing@huawei.com> CC: , From: YueHaibing Message-ID: <052d5583-8b72-e052-36f9-2156df2be4f5@huawei.com> Date: Fri, 13 Jul 2018 17:19:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20180713071610.14276-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pls ignore this, there has a fix. [PATCH] block/DAC960.c: fix defined but not used build warnings On 2018/7/13 15:16, YueHaibing wrote: > When CONFIG_PROC_FS isn't set, gcc warning this: > > drivers/block/DAC960.c:6429:12: warning: ‘dac960_proc_show’ defined but not used [-Wunused-function] > static int dac960_proc_show(struct seq_file *m, void *v) > ^ > drivers/block/DAC960.c:6449:12: warning: ‘dac960_initial_status_proc_show’ defined but not used [-Wunused-function] > static int dac960_initial_status_proc_show(struct seq_file *m, void *v) > ^ > drivers/block/DAC960.c:6456:12: warning: ‘dac960_current_status_proc_show’ defined but not used [-Wunused-function] > static int dac960_current_status_proc_show(struct seq_file *m, void *v) > ^ > fix this by adding #ifdef around them. > > Signed-off-by: YueHaibing > --- > drivers/block/DAC960.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c > index f651806..7a05831 100644 > --- a/drivers/block/DAC960.c > +++ b/drivers/block/DAC960.c > @@ -6426,6 +6426,7 @@ static bool DAC960_V2_ExecuteUserCommand(DAC960_Controller_T *Controller, > return true; > } > > +#ifdef CONFIG_PROC_FS > static int dac960_proc_show(struct seq_file *m, void *v) > { > unsigned char *StatusMessage = "OK\n"; > @@ -6485,6 +6486,7 @@ static int dac960_current_status_proc_show(struct seq_file *m, void *v) > seq_printf(m, "%.*s", Controller->CurrentStatusLength, Controller->CurrentStatusBuffer); > return 0; > } > +#endif > > static int dac960_user_command_proc_show(struct seq_file *m, void *v) > { >