From: "Schenk, Gavin" <G.Schenk@eckelmann.de>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"longman@redhat.com" <longman@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"dave@stgolabs.net" <dave@stgolabs.net>
Subject: Re: [Customers.Eckelmann] [PATCH] locking/rwsem: Fix up_read_non_owner() warning with DEBUG_RWSEMS
Date: Wed, 20 Jun 2018 05:49:30 +0000 [thread overview]
Message-ID: <052d9796f814fc5d6625ac7fcd00dc37b0f11da1.camel@eckelmann.de> (raw)
In-Reply-To: <ba5a8266-b475-0f80-50eb-1ed39ffa6d2a@redhat.com>
Hi,
On Wed, 2018-06-20 at 07:09 +0800, Waiman Long wrote:
> On 05/24/2018 09:26 PM, Waiman Long wrote:
> > It was found that the use of up_read_non_owner() in NFS was causing
> > the following warning when DEBUG_RWSEMS was configured.
> >
> > DEBUG_LOCKS_WARN_ON(sem->owner != ((struct task_struct *)(1UL << 0)))
> >
> > Looking into the rwsem.c file, it was discovered that the corresponding
> > down_read_non_owner() function was not setting the owner field properly.
> > This is fixed now, and the warning should be gone.
> >
> > Signed-off-by: Waiman Long <longman@redhat.com>
Tested-by: Gavin Schenk <g.schenk@eckelmann.de>
This fixes my reproducible locking splat when booting with nfsroot and changing password. Thank you!
Regards
Gavin Schenk
next prev parent reply other threads:[~2018-06-20 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 13:26 Waiman Long
2018-06-19 23:09 ` Waiman Long
2018-06-20 5:49 ` Schenk, Gavin [this message]
2018-06-20 9:17 ` Peter Zijlstra
2018-06-20 9:33 ` [tip:locking/urgent] " tip-bot for Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=052d9796f814fc5d6625ac7fcd00dc37b0f11da1.camel@eckelmann.de \
--to=g.schenk@eckelmann.de \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome