From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC9B04457A7 for ; Wed, 29 Jul 2026 10:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785322183; cv=none; b=ZlGdEmZOcAGng4BovVseZIC4lioMj84ys7zs/03yOgXAsE1VZlMmY9glmPmWlDj05eQZJwFB+7xx/P7qdhCEByckC4ZUu60HuqKDXlK9eu9IPvtUJ1iXh5GJmx+fpHnj2huv+EJDfDDsgCBzSDQeDKvF3GEIbgDEeXQAp0oHvzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785322183; c=relaxed/simple; bh=2usr0i2dFD5LSEt/TM85K2oR2cSK9laanCcXUmD0pdg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XXkFvBtq4P6jnTNMZY6QCyNiXR3UiooxowZxDYiRGRgSu+yUD70cg5bq5AhqfFRTsuC02T/l1/bSDJZway1EV1ezU79miWmWJoyMVsQiOEPXDUM1AFL5B0Q2IpcG66mW8XzZzlOwR0y54rTZ1vVsS9ZJgPH7nr1KRvbEU6cYWIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OG27n2YI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DnTr0gcQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OG27n2YI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DnTr0gcQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66T7etvR2326509 for ; Wed, 29 Jul 2026 10:49:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LWAY9zP8dExKQDKxyzQktKQkEBLqrC9Cfvw5ivxGBXU=; b=OG27n2YIQFTTwow2 AOSmAJUO9yWICPiPADS6UdPHTrUdRUsH83V9pQdpfI/B1P+tGFG9v+aBQqdAD/pP CpyD08WCjCqSXPksrLqKBeUzi32JVxB3IwitourBH4w+2cK3cVScqG5E6u+Tnbh0 vWlCbwk/xGrFRToFek1nBKo69m7o53Qa85+Alc11dfb/haMXpAx5usbXyzCAiuEi pqKpk7WOKIwjcOgR7/MDFbD9apjytt/4zRtZa1jKHUDDlHqJTCnr7hZpONn85Ai/ 9YVZ+mD+Dy8uOZvTq6/QiZ+i9OZH5OXB8P4DBZihFgetBbQXlXBEnMoHbyfv6PkH BIQTEQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqbm1h9vv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 10:49:40 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb733fc5024so1130951a12.2 for ; Wed, 29 Jul 2026 03:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785322180; x=1785926980; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LWAY9zP8dExKQDKxyzQktKQkEBLqrC9Cfvw5ivxGBXU=; b=DnTr0gcQCsApnK83J7LjD/ouYsgiAKq3MCAsWsmOTq+S0Wqj7ROkX4Xwfb26ovZuU2 DaJ2ZWMa0t3JyDgxTBBQoJHDCO/WZF3t3HvmdPS0rn7DjI4Tz7cKF+ziJtBZubYzex9T 93IO2N464ee4L6OH7qse6+R6vF0hMv6amzL38n6paw/dvSjr4gDCToy5MK8dSqAoMJuP 1eSFbUq6NeX5nIwHNd5XcKjhq86VXf91SG9SQqn8hJ6pQEhoB7RGuqTRTWmB/Q8+P6Cv xZG3AGYh5ABXzDPRr1LrQkaxY/j9sb6VFL/axYGE7qxiX5bxK290S6YhrH5zK3dGxe87 Z8Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785322180; x=1785926980; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LWAY9zP8dExKQDKxyzQktKQkEBLqrC9Cfvw5ivxGBXU=; b=IYKa0wHHo1vQ/U1Ge47LXjbFakXFkbtqLSrRj/WQtVW9nfqf8QAg4KXYvdKIQ264qV eJ3beJRCZKtLALFdecBbTrB+5eSr3673l9VpRqQBhLZBedwuu9Oy7Q6kaUYrpqYfeUcT cgigOqxFxtkibQp9uLdieIpH4zOgykXZzLDmdWniZE+Kg39XaYLZtvMECKJMsK8DCBWj Bad8XHlj/IJv8/trcqV9XWKDiGDrIo/pOAq84swriHYDBNsp6MxVcbzYRxWnFBeJEBp3 LQHph8+gxjar4yePnEBxEp8DXnj//IBlPYOVSlzhIoasKi7vhzXOFpRPAkAqAR587ldM ixZw== X-Forwarded-Encrypted: i=1; AHgh+RrezpjaM++icwgaesgc7obGctNMdjmOdfaA0Vgjt0Nwxz1pvJ235sqJ3ALcDRHhOBWuqf6zvNz6pgCHOqA=@vger.kernel.org X-Gm-Message-State: AOJu0YyGRH+GOk409a4tORhEMbXwWuCVsZ2OoZ89h/mpr908aTlrcWpt N7YD2/L3u/S8wmIo33gCO+Fp1awsVQwKB66JHpSEXUpJ9uditnRZsOXu5Sx0z+xFmvgB9zrtJpe q22yBLkW/Qb/tf/ILmFMgZV0eO3OfSLTsSrzwHXER322YqYkRuiObDL7VVGyfeA0+SYw= X-Gm-Gg: AR+sD12jgkKZn0HUWaagjImlhIOaTWHvBOwbSS2i7XEw61e5aamN1k3GevxFwNkXNT9 m+VVmqW0w3XKLdCrKBNuUcx7AAwHflCf6Vn6YCr5veliK5kQidgmGA1irFl/vk6uH+iGIrK2tIU lg6UyGrphFcL7WAtjr7dcL5C6x7zA6cRwHyc0kJMocij4Fc8V10QyKTziN5Ke2HAM8Jl0wdQ0K3 lbCO1WmrV/qhKry1tZ8gURl2l3BHE1FCiEsnHaHi/BI2yTnHiA143jSq3fjh2yFjmlUsXxM+t5S YYDjI5VzMiCU0/H8rnfnHkbabPDhl7ga2r4dqASbRJNPO3zppTc8wAAvFu7ImhLLhkEbW8LuwqX fYo4P1p00EQ+KaI4j6QrjfD3MZJc7mIhdlflahBEAtSBrbO9QSpjDXwtlp/qnLezH1OVqJtGNIo S+TMhVOx+AZAXw X-Received: by 2002:a05:6a20:7fa7:b0:3c3:f431:25 with SMTP id adf61e73a8af0-3c8ba5b7785mr7131227637.39.1785322180303; Wed, 29 Jul 2026 03:49:40 -0700 (PDT) X-Received: by 2002:a05:6a20:7fa7:b0:3c3:f431:25 with SMTP id adf61e73a8af0-3c8ba5b7785mr7131197637.39.1785322179891; Wed, 29 Jul 2026 03:49:39 -0700 (PDT) Received: from [10.149.71.180] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbdba3519a5sm724263a12.18.2026.07.29.03.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 03:49:39 -0700 (PDT) Message-ID: <052e32ab-c7a6-40be-a11b-3d11f599cfc6@oss.qualcomm.com> Date: Wed, 29 Jul 2026 16:19:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: reject incomplete responses To: Bryan O'Donoghue , Linmao Li , Sibi Sankar Cc: Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Maya Matuszczyk , Dmitry Baryshkov , Konrad Dybcio , linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260728111924.4106898-1-lilinmao@kylinos.cn> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDA4OSBTYWx0ZWRfXwom4JEErxgb1 S44BwL3NrBTiHCxdnz3CqxxAWi5UfbG1yKf9KvGiBWouROp6Vk7PjPpNfCvpUyrEdDURTT61oiE xsygmQ5OoblDaj+66IUDCh/NGn0uHle9ipGExW9W5vEJHOEtCSWqQx97PO+PA4VYqEtB7B0w4Ir fdoJ39iianHshgXgmzjmacKrUDj2DtZax85VLxtlQhZszrRB7xJJZKrqsHG9OD9+7oanWrvsYD7 EBJvUYLBNghEjxuYXARthIlhrCtvv05x9xRzoMUVODxTeg+5hhFVjTGunjmc9M994fJljjK9S5X 1PF1D/n+Qly12xfb9TSeWSIlSbTFuSYZZ+2PvA3bFGZWtgI14shB141w1tmZcWwbCgbdizqjv3w mTbiZ4VExGifFZ4k//vZDH/cSkW9PVZf11pwE4QTmUepA/nz1t0eJ20Qbi/O7CmjeNuM/C2WnIJ Qf8Btkz4mRqpe9H7kXg== X-Proofpoint-GUID: IfS_9P9R3mC0ieQizGhOqNHTm9xNXLS9 X-Authority-Analysis: v=2.4 cv=R7Az39RX c=1 sm=1 tr=0 ts=6a69dac5 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=c4HiQqaVnwyIzI225tcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: IfS_9P9R3mC0ieQizGhOqNHTm9xNXLS9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDA4OSBTYWx0ZWRfX++vR0v1mPwkj gHsIo23MTWbW16b7dWVKTgm8hr81hBazhc8hyHesQlrmXhxPksqTDePJdZQ4YgWOfz5RZ0C6kRw atPu/LHiTP0/zQwSc33PnMUAPVkOK6I= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_03,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290089 On 7/29/2026 3:53 PM, Bryan O'Donoghue wrote: > On 29/07/2026 11:08, Anvesh Jain P wrote: >>> -    if (resp[0] >= resp_len) >>> +    if (resp[0] != resp_len - 1) >>>           return -EINVAL; >>>         return 0; >> Thanks for catching this — nice find. >> >> This is independently fixed in an in-flight series that reworks >> qcom_ec_read() to use raw i2c_transfer() instead of >> i2c_smbus_read_i2c_block_data(), removing the partial-read case >> entirely, and it already has the same resp[0] != resp_len - 1 check. >> That series just hasn't landed yet, so your report stands on its own — >> happy to add a Reported-by: Linmao Li tag on that >> commit when it's re-posted, if that works for you. > > What about -stable ? > > Seems like we should take this fix and your series should rebase on top > of the fix instead of the corollary. > > That's the way this should work Fixes > New stuff. > > Can you add your Review-by/Tested-by and then rebase yourself ? > > --- > bod Agreed. I'll rebase my series on top once this is applied. Reviewed-by: Anvesh Jain P anvesh.p@oss.qualcomm.com -- Best Regards, Anvesh