From: Suman Anna <s-anna@ti.com>
To: Henri Roosen <henri.roosen@ginzinger.com>,
<linux-remoteproc@vger.kernel.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
Date: Fri, 2 Jun 2017 16:40:15 -0500 [thread overview]
Message-ID: <053186d1-f05d-06e0-2fa9-e15bcfa5bb02@ti.com> (raw)
In-Reply-To: <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com>
On 06/02/2017 06:36 AM, Henri Roosen wrote:
> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
>
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
Acked-by: Suman Anna <s-anna@ti.com>
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
> /* Link the channel to our vrp */
> vch->vrp = vrp;
>
> - /* Assign callbacks for rpmsg_channel */
> - vch->rpdev.ops = &virtio_rpmsg_ops;
> -
> /* Assign public information to the rpmsg_device */
> rpdev = &vch->rpdev;
> rpdev->src = chinfo->src;
>
next prev parent reply other threads:[~2017-06-02 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 11:36 Henri Roosen
2017-06-02 21:40 ` Suman Anna [this message]
2017-06-25 21:43 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=053186d1-f05d-06e0-2fa9-e15bcfa5bb02@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=henri.roosen@ginzinger.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®