From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E02CE337B97 for ; Tue, 17 Feb 2026 12:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771329735; cv=none; b=cD/E4z+sDeYtIHBl+sDG9VJG/E4Xmix7mcH/31G5mKAsV1wtCG+FptyAW6gzPqPISJEGM5B3WRpMYD2T3yEdtVW3aqKTIBsIutULuhWQ2iqyTlQoNCSskgweFES1JhP3bbCtb+jDZCLbphk1ebvZCVGtLnTNk/IN3QbSNY0Ccvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771329735; c=relaxed/simple; bh=5716HxySxYgesPMYObLsvfNKf2FB8Di/1BrEhT/qcHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O77zJI/gz6WWM0mQcprh/c0lTELnhCBFf8QZ+hkGGjkecGO44uyIeHA+/Dbwa8bL4B2Uu1sdh2AXbLby12mL62LjMG56uFOdfBpb1ZcNUEjUR9iZJMkXHKNoJaL4RFX7nT6pd0HOk+hqJkXzzz91wtXaP0hQ6E6eHFLJcmUHOk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hvfclo9b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JEc8MrJB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hvfclo9b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JEc8MrJB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HB4Exw1944069 for ; Tue, 17 Feb 2026 12:02:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dqPOiVgA/LPAUkGW1EX1UemeyO4lv7fTBluprRdgR4g=; b=Hvfclo9bAahDk7q5 MpDFvxK7wn0DwQxQ3tM4Gpx1Ml5AakmvHI4eVntH8g2+edkM5FmvWo7A5yZpt70e E0O8M30UZerMNLLNTO91REy4Qcjlue9RcMTwCYv4ysToXRvxfsdLGt4S1rjNikth UVMTrSCSpkuESAgRPmFAL+HkMeGbJ9z+XGCJ7cVP6hKnPPklMI9pXfnQCpsKHiwx se35bLl98mpIPDiqaq0JhMsXy0jxOLK8spkTBMHPapLHGzZOReMUZ7gUGg+i/Pin w1jXoms5bFgyRyvjNYS7hmAN37/ABzOh3WI5rvbUmkzBU1hCjuIhiy94kpgz7S79 julpxA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ccq4g060s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 12:02:12 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5064fbe2babso31444281cf.1 for ; Tue, 17 Feb 2026 04:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771329732; x=1771934532; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dqPOiVgA/LPAUkGW1EX1UemeyO4lv7fTBluprRdgR4g=; b=JEc8MrJBMc9izO25eNh5wsI+itj277Z824f5Kr63g7h54ewp3oNQ7zAdQ9gJyl7D2O fA0EKm9yIZvKrhlfKl3haZ5LKcCr9IQVNdUFLyAMSoHNtIXv4Fa+KDpGv6mSGywkartB OEvSmD881ECA9hVACalQ9K3ojMdnr43ZE4pHDPES7B8wBN052ueXEmis3zO4yMCYgfRq MbJ5PV+Tn5fvp4iAdQmFA16bshtk3lQ4+9wNAra/SRwWEyuKifBwFC7rvC1d+QvH4q1N FMvyvDLnSfIbiKYsvo1NuOh80Ekc4PHqSLz3q+JBBzd5v6VNtf0eFg2nmTcp1cI6rcOP 7WyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771329732; x=1771934532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dqPOiVgA/LPAUkGW1EX1UemeyO4lv7fTBluprRdgR4g=; b=vgIclomDO/9qCqQp1zCEKH0vPSR0aJEUDs0qN8A77/D+553PUkCQSTHvUJpd5eIKZS rJpx9Q7nFvv/NTIgr7AdoLRCGh6wTOjwBdBsAWlJths0elvSyu+FMokNRii+1WGFtLiv BURPd9pKrDssnyGz2SDZ+pwNCWX5egAaclkTVtiqLawDPYfDv7lk4eBAlUlaJLq5IzN3 Q3OM+9w4/drjly0vm5J/vTbEOJGVm0OoR2YVdLJGQg9iuipRHeB/+AG/AUSQbI/XCdk+ bU/LKoXLVGxyXPPArvt0/GhJ3JNf6NQVmJ1Yx2QuWCDM+aA2gPlsiVua5qOw+Exeveyy l4xQ== X-Forwarded-Encrypted: i=1; AJvYcCUo/2bjTtDNzqEcW+bt5DaJoz3ujtTQgxzI0R7Xldt6fa44X0HHxk+aRGpF904jA+sepStOYlZeRSt3eHc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4j9wLaRKGx3jndot1HR6zt5W1IagG+6PluCYHYc7IFE73z2wN +b+Vh9HOo+vwbDQS+dbj0izhQdQJelAJ/mNBwsynGfh4QZ2yGVAoU6mf60mvoORcL07Vxli47re +tDbHBnw8JOZCPixkue/jn/oclVEeysNrAa807h5ZAqXd4Oq0u7VYvZOS1d5QxUc8BAc= X-Gm-Gg: AZuq6aKndYn15fmUyYNczhx9Q1Bko1ykOXmDypr6pLFculjM8pxcyNuieaD6jbmO2Hb N/rensaXZkl2nk0gn6iVRZ8Wbuzqp9F7731ksFD/0+INKPw2XZMFdhFw2wK89ZBF67GGWSpRwb/ Q0p5V2+vewTf/DsGfbebs6jiiuGKM75W69aZg+SyvQElTTo6rsBUoHsi6xMdyLDwzZQQV1ARIpI nQAEHgJLmccO98ctmTJEBSpGEGaG4b8lIAjyeqyawdaiEotj+HkUq8grmlOZ1OEMZfQmmkKbBL+ qevulEFyaQUH9sq1lmnVvKe21KqXtgj7TAjDyGCSWb1u6B72IgfYpwg6atXd4fZKjwYbGdfR9rw NY0EdoA8DLsr/cRl5ZygaqC5FCkANRpUfWC8yVSicZEZOK5ciEiLqEvjwMlpzeZ2p9qALmusnzX 5/0X0= X-Received: by 2002:ac8:5f0a:0:b0:501:4504:6f80 with SMTP id d75a77b69052e-506a6a4d9d9mr136978471cf.9.1771329730602; Tue, 17 Feb 2026 04:02:10 -0800 (PST) X-Received: by 2002:ac8:5f0a:0:b0:501:4504:6f80 with SMTP id d75a77b69052e-506a6a4d9d9mr136978111cf.9.1771329730143; Tue, 17 Feb 2026 04:02:10 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3e38f5sm2332241a12.19.2026.02.17.04.02.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 04:02:08 -0800 (PST) Message-ID: <05340972-2013-45b6-801c-7e52fe48cef0@oss.qualcomm.com> Date: Tue, 17 Feb 2026 13:02:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-6-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260206174112.4149893-6-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5OSBTYWx0ZWRfX3jV+w0C+mx9H YpInmpnseEyOiF4cGzPG5ZxOoDnieKYxxeNvkLYGyKG0ln1g+75WSjsmOqShJ1mI8mN3N/9jEA6 EboKjP9rd5rGkoWpJ5UOC9xwaQ0HCkE0UO9U8/m7yWwBFVEnUvc5l3VG0QZJZUpuHaI4Uq9YmaA jq0jTVAZQReWnGAlgM6XuW2SP5R2fjMLkBI2bLm4yezFzNzZInWe4AY0LN+yYPNfrOG1wh0dcS2 NfakJ7nqSRzDdAaLO43YbDeOefw0GceGox5LsSzcGOgMbwhI1zxMLT4nI5tEBTQuZCDa5Q9WSha AV3vS84ZYoXI3QkMnksg2vcWuUcXdYUYlinbpotZOYVtWAgshTfdvg1H+d8b3/l324OvKaR//XD 4zYD6xN8YVBdHmplDiV+OyasEpqRxbqvaBqUPq6qKlkjEDutoS67+YJJRwCOd9uSlgfHvuZEO1y GIRohOx1M4H8ZaQMfpw== X-Proofpoint-ORIG-GUID: XWgHKEfkAKyXiN9mZBWpdY3Idc2R_wCK X-Proofpoint-GUID: XWgHKEfkAKyXiN9mZBWpdY3Idc2R_wCK X-Authority-Analysis: v=2.4 cv=YdiwJgRf c=1 sm=1 tr=0 ts=699458c4 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=W3I9JGv7J1k6QNzkgEYA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170099 On 2/6/26 6:41 PM, Praveen Talari wrote: > The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource > activation/deactivation sequences independently, leading to code > duplication. > > Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to > power on/off resources.The activate function enables ICC, clocks, and TLMM > whereas the deactivate function disables resources in reverse order > including OPP rate reset, clocks, ICC and TLMM. > > Signed-off-by: Praveen Talari > --- > v4 -> v5 > Konrad > - updated return value as 0 for geni_se_resources_activate(). I would really like you to include that kerneldoc bit I mentioned it https://lore.kernel.org/linux-arm-msm/ff9a2aa3-1b2b-4001-82ce-198c61a4b637@oss.qualcomm.com/ Konrad