From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073F81EB9E3 for ; Tue, 17 Dec 2024 12:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734438758; cv=none; b=tprOnMpKT0zIxjDE5cUN1iwNRcTqAB/pgAFpR70yclgf0DWFG6e9KcgX4LKkcGh5U/4xZxSKcE62zTci8Gvvqh8yPcwpy8031ALWckWxK45BS8I5qy2i8X+OtAbwxSjzLyO3unFjJ4qd57k5Si1+ggA1lJgLIOikd4Wbx/QORAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734438758; c=relaxed/simple; bh=YbfDs8LoY5asKM7zZM/qu8gLr3JGUTt7arQC8J9od4M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=px0SaBXtkv0JXKR3etqx4aF0aC+JcBvAWT+fSDrzxbvFUuQ6+vzyMsyXB0beZxnTvJSAkr+Q4kdKJTspGrFxj7r/eJHENEfGMaaVBEHp7ip0APOFf8rh1E9hSG4sVwdFjs2YLCdqYMXq17XA6VMzo5meO8TPdjlGO58k0xLzMoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Qul2Xkte; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qul2Xkte" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d4e2aa7ea9so2114269a12.2 for ; Tue, 17 Dec 2024 04:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734438755; x=1735043555; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vadTVklg9DZ5KZn/j1FjuzNmgd1jDV/1Li8ndKsd3tw=; b=Qul2XkteNGKGuQGn2HWKJC0pzrkQhXq4k9nAgHHAhL1CeOEoBx5Wr3FfWpsXjffc4r t8MqNdhX3kjOpCrCCyY8MZ8txcn3F4Bry7Ibbb6vQ5osDMq3qOigAaxpPJCn28UxiyQD aibyBkIntJZr9HIbTgGVWHm6pcWTGq+usDYHh8kf01Z0GXKCOaa6DFmh4vF2DvQwikbw N+42qhZothYnYNppq60Y5ASH8oMBKwsNazRXdyBaRzW8xk4HvtWvGqIQFBM/iOI+IpHa tUYkhUIgwcb2faqdMZKBjIZP04rnBQLh1qpiIglkGQReTgfbNmM3IUh2p1mHQit0qYPi qflw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734438755; x=1735043555; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vadTVklg9DZ5KZn/j1FjuzNmgd1jDV/1Li8ndKsd3tw=; b=s6ygX7cPeXyIc28E5Ub1Wrz4/DJ0BCEtdDh+5PEYGRCqJjnMUmvN/A//Z2kTTdmrTV +iVG1zn1VUEn3xGtaVkqsURCl47P2tui7HAIDQaYltQVnoCCx1IasP5F2MiT3QSZ4SmK Y6BVx/mNFvY2tiqMmQtsY7uifbx6R7OoQfR4ToHl1fGNVjbFLbf+b0Pr1WlLqkHJB41t Wj4z5flN+uu2khd6fDyx7bwUhS+P239VeXFDlmQAovm0OcAvpq1E78DRIK2TVkFgMgt7 wSulOc8CXZzHbc0r/EfVBOxiDM3eYXpjZnUXD6eM+bSFma1C7efB9LUdZ+d2CWY6tOq6 aqLA== X-Forwarded-Encrypted: i=1; AJvYcCXeo5R9gb97m5LPL4eWd+TNho/eC0ouy/xipOye2wCA7jPk/KjThlYToIwPjR4Of52hIrbTNF0mT5sHDzY=@vger.kernel.org X-Gm-Message-State: AOJu0YwazmBlAYiVAy8iHLrY4O99Vd3W/RJt1LW63dX/scCaoIzYkmBB CPn85aDM1LT5/CeGDsrJfcu7jjnrHuWXI0hM1h5vs9YtWDcyyM4Z+pOXB2bX/40= X-Gm-Gg: ASbGnctEM7t8JD8dnAevJfcVu5YD2Uw9U35K4DoTc6CgxTwTWgtzZd3eDcRUCTq5KUU rVWTrEYtOJicDtZy/1FhJF+7T8Zk1PM3oPKFx5o+aDwHLBsjDZ9juVJZTyhIDVOmvODDky8i7dn Su2LyU5rEB2+g3KJXIdoHsex5hcokTbdL9suLwoXhQvPAeGcaMRm2GSjliD54tjxsxcJieGjfrO ockjl4d7D6KdQfEKQWDtoZkjm1OdJXCx2yV03Wr6ols14QuyVK1rzdzQeLnjw== X-Google-Smtp-Source: AGHT+IHQ03iEFjc/Teha21bLrHNLnNIrRs6fDpiX/v4CZTbwJmuV1NtVhgiSm8VrPkB6aW1UmvcDog== X-Received: by 2002:a05:6402:5288:b0:5d3:e8d1:a46 with SMTP id 4fb4d7f45d1cf-5d63c3bf48dmr17438136a12.30.1734438755313; Tue, 17 Dec 2024 04:32:35 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d652f271a6sm4407073a12.60.2024.12.17.04.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 04:32:34 -0800 (PST) Date: Tue, 17 Dec 2024 15:32:31 +0300 From: Dan Carpenter To: Herbert Xu Cc: Steffen Klassert , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] xfrm: prevent some integer overflows in verify_ functions Message-ID: <053456e5-56e7-478b-b73e-96b7c2098d07@stanley.mountain> References: <92dc4619-7598-439e-8544-4b3b2cf5e597@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 17, 2024 at 08:03:38PM +0800, Herbert Xu wrote: > On Tue, Dec 17, 2024 at 11:42:31AM +0300, Dan Carpenter wrote: > > > > + if (algp->alg_key_len > INT_MAX) { > > Why not check for UINT_MAX - 7? INT_MAX seems a bit arbitrary. > That seems like basic algebra but we have a long history of getting integer overflow checks wrong so these days I like to just use INT_MAX where ever I can. I wanted to use USHRT_MAX. We aren't allowed to use more than USHRT_MAX bytes, but maybe we're allowed USHRT_MAX bits, so I didn't do that. regards, dan carpenter