From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84285C7EE23 for ; Wed, 3 May 2023 14:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjECOJl (ORCPT ); Wed, 3 May 2023 10:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbjECOJj (ORCPT ); Wed, 3 May 2023 10:09:39 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BF7244BE for ; Wed, 3 May 2023 07:09:37 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-50bc3088b7aso7848606a12.3 for ; Wed, 03 May 2023 07:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683122976; x=1685714976; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mK68NYi4Md501UpiqLonzXIdRt1tnNyCrIythi7sS+M=; b=noHAyyyWDYLPP6JO/zozkSkR2vkzidbvTevSRwNzUbJtQSxqGAz6P6BoNIlrpA2tgX 0Ax7FwFNNxXaxvq4AjYH3l57NVqojg41eZVsE2h5SSsCehHN+iCbJvkvSGd5t6soY04T oMX9YalyuVn63F8wnmCgYqHfrYekJjagE9II6StQoP6XZQHZbEY+/hyuCD/VkdXgCBJJ ejNtLOpI5Cjr2+mHCvoXIgJou5lWthj2vGJ0qlsnLJtAX4PQdKnckJvCw95W4LD5WWot GA/UjQy6yVG2Rz1QebCVbZENPCi1x8UzZEZ9T2O3ZzsITG5rCjBsrDWkKyHVVosoSrIt RDZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683122976; x=1685714976; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mK68NYi4Md501UpiqLonzXIdRt1tnNyCrIythi7sS+M=; b=RrWoycjzDPQucSqfsomtRmOr6NiruX+/1xDOpkWFpXTiqBLyeFW87PaM0C8ATcfemM pHpD+NcrCbG2iDOwZfR4JEzIVdF3Tmd+nK7OGy7hWgGZ80Q+XrQDX7Sf3ysdRyUcYwsb gmIF7aZnefJkdkwzA4dRNj3R5uQ7mWvIX61oL8BxcGVEsm4BF6dzXql1jFiFbEnJc2UZ Q0MKlfDnIc8hUrf9Nb3v2p8D8zJtu16GaJ4QuzyU/DCfV4Oy1U9KzSls10+GUFEBEXSJ X67vtiGcABcNDeTny+L/an9iz59KJjr4vkk9nJXZVSVbczqnoz1pSnXLQq7htOVNjcvO lHCA== X-Gm-Message-State: AC+VfDydcg1pe+WXQcRtUKg1qBimMI7uTh2mzD6T569RQG6pHwo5BZT9 gCo9DKNaENjwMKs9WtKCK/SpKQ== X-Google-Smtp-Source: ACHHUZ7MpB081+GYrlSXGSVot5dVaOLY86f0bU3jAd2a2xjuJu5mlKxTH5nx1WwtH/pn1/saQX/7nw== X-Received: by 2002:a17:906:58cf:b0:94f:2852:1d2b with SMTP id e15-20020a17090658cf00b0094f28521d2bmr3247307ejs.72.1683122976003; Wed, 03 May 2023 07:09:36 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:db42:e3d0:c55a:8cf1? ([2a02:810d:15c0:828:db42:e3d0:c55a:8cf1]) by smtp.gmail.com with ESMTPSA id h20-20020a1709070b1400b009658f5a90d2sm127868ejl.189.2023.05.03.07.09.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 May 2023 07:09:35 -0700 (PDT) Message-ID: <0537e5be-87c3-c551-ac12-d2cdf5b18b07@linaro.org> Date: Wed, 3 May 2023 16:09:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to xlnx,zynqmp-dpdma Content-Language: en-US To: Michal Simek , Laurent Pinchart Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Hyun Kwon , Krzysztof Kozlowski , Rob Herring , Vinod Koul , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <30424f5886ef42419f65c2d5131ad30881c727a4.1683100816.git.michal.simek@amd.com> <20230503125125.GE32586@pendragon.ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2023 15:27, Michal Simek wrote: > Hi, > > On 5/3/23 14:51, Laurent Pinchart wrote: >> Hi Michal, >> >> Thank you for the patch. >> >> On Wed, May 03, 2023 at 10:00:20AM +0200, Michal Simek wrote: >>> DP DMA has own power domain that's why describe optional power-domain >>> property. >> >> As far as I understand, the property should always be specified, the >> only reason why it's not mandatory is backward-compatibility (I would >> make it mandatory, as I think proper validation of new DT is more >> important than avoiding breaking validation - but not operation! - of >> old DT, but that's a separate story). If my understanding is correct, >> could you please update the example in the bindings to add the >> power-domains property ? > > backward compatible - of course > always specified - if pd driver is enabled it must be there. If not it doesn't > do anything - just describes it. > > I am not in a position to decide this. But if dt folks agree with your ask I am > happy to make it mandatory and extend example. By making it mandatory in the bindings only, not in the driver, no real ABI gets broken. Linux won't stop booting if property is missing. Therefore if device is always part of power domain and it is actually required, then sure - making it required is useful. Best regards, Krzysztof