From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A92C10DCE for ; Fri, 6 Mar 2020 09:51:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD4DC2072A for ; Fri, 6 Mar 2020 09:51:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726140AbgCFJvi (ORCPT ); Fri, 6 Mar 2020 04:51:38 -0500 Received: from foss.arm.com ([217.140.110.172]:58688 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgCFJvi (ORCPT ); Fri, 6 Mar 2020 04:51:38 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A96831B; Fri, 6 Mar 2020 01:51:37 -0800 (PST) Received: from [192.168.1.161] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C01543F6C4; Fri, 6 Mar 2020 01:51:35 -0800 (PST) Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM To: "james qian wang (Arm Technology China)" , Liviu Dudau Cc: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Mihail Atanassov , Brian Starkey , David Airlie , Daniel Vetter , nd@arm.com References: <20200304145412.33936-1-vincenzo.frascino@arm.com> <20200305184255.GH364558@e110455-lin.cambridge.arm.com> <20200306041407.GA27096@jamwan02-TSP300> From: Vincenzo Frascino Message-ID: <053abb02-cdeb-76f8-d651-88734a338010@arm.com> Date: Fri, 6 Mar 2020 09:51:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200306041407.GA27096@jamwan02-TSP300> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On 3/6/20 4:14 AM, james qian wang (Arm Technology China) wrote: > On Fri, Mar 06, 2020 at 02:42:55AM +0800, Liviu Dudau wrote: >> On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote: >>> komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when >>> CONFIG_PM is enabled. Having it disabled triggers the following warning >>> at compile time: >>> >>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: >>> warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function] >>> static int komeda_rt_pm_resume(struct device *dev) >>> ^~~~~~~~~~~~~~~~~~~ >>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: >>> warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function] >>> static int komeda_rt_pm_suspend(struct device *dev) >>> >>> Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on >>> CONFIG_PM to address the issue. >>> >>> Cc: "James (Qian) Wang" >>> Cc: Liviu Dudau >>> Cc: Mihail Atanassov >>> Cc: Brian Starkey >>> Cc: David Airlie >>> Cc: Daniel Vetter >>> Signed-off-by: Vincenzo Frascino >> > > Hi Vincenzo: > > Thanks for the patch. > > and Vincenzo & Liviu, sorry > > Since there is a patch for this problem already: > https://patchwork.freedesktop.org/series/71721/ > > And I have pushed that old fix to drm-misc-fixes just before I saw > this mail. sorry. > No issue, as far as it is fixed :) It is annoying stepping on it during randconfig :) Thanks for letting me know! [...] -- Regards, Vincenzo