From: "Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"wenst@chromium.org" <wenst@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nfraprado@collabora.com" <nfraprado@collabora.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188
Date: Tue, 18 Jul 2023 06:34:28 +0000 [thread overview]
Message-ID: <054014f207e24e1507199cd9833085346ed8cbd6.camel@mediatek.com> (raw)
In-Reply-To: <9e46c996-3e3b-b437-f2c4-2ca86a1c7e6c@linaro.org>
Hi Krzysztof,
On Mon, 2023-07-17 at 21:55 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 17/07/2023 14:02, Jason-ch Chen wrote:
> > From: jason-ch chen <Jason-ch.Chen@mediatek.com>
> >
> > Add MT8188 PMIC Wrapper compatible to binding document.
>
> No improvements here - the compatible is already there. Subject has
> the
> same issue. Explain what you are doing and why.
The reason for changing the patch was that while MT8188 uses the same
pwrap as MT8195, the original code was applicable to 'compatible =
"mediatek,mt8188-pwrap"'.
To resolve the DTBS check warning that '['mediatek,mt8188-pwrap',
'mediatek,mt8195-pwrap', 'syscon'] is too long', I modified the code as
per the current patch.
>
> >
> > Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
> > ---
> > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6
> +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > index a06ac2177444..4737e5f45d54 100644
> > ---
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > +++
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > @@ -41,7 +41,6 @@ properties:
> > - mediatek,mt8173-pwrap
> > - mediatek,mt8183-pwrap
> > - mediatek,mt8186-pwrap
> > - - mediatek,mt8188-pwrap
>
> Look, here ^^^^
>
> > - mediatek,mt8195-pwrap
> > - mediatek,mt8365-pwrap
> > - mediatek,mt8516-pwrap
> > @@ -50,6 +49,11 @@ properties:
> > - mediatek,mt8186-pwrap
> > - mediatek,mt8195-pwrap
> > - const: syscon
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-pwrap
>
>
> Best regards,
> Krzysztof
Thanks,
Jason
>
next prev parent reply other threads:[~2023-07-18 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 12:02 [PATCH v3 0/4] Add basic node support for MediaTek MT8188 SoC Jason-ch Chen
2023-07-17 12:02 ` [PATCH v3 1/4] dt-bindings: arm: Add compatible for MediaTek MT8188 Jason-ch Chen
2023-07-17 12:02 ` [PATCH v3 2/4] dt-bindings: arm: mediatek: Add mt8188 pericfg compatible Jason-ch Chen
2023-07-17 12:02 ` [PATCH v3 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188 Jason-ch Chen
2023-07-17 19:55 ` Krzysztof Kozlowski
2023-07-18 6:34 ` Jason-ch Chen (陳建豪) [this message]
2023-07-18 6:36 ` Krzysztof Kozlowski
2023-07-18 7:09 ` Jason-ch Chen (陳建豪)
2023-07-17 12:03 ` [PATCH v3 4/4] arm64: dts: Add MediaTek MT8188 dts and evaluation board and Makefile Jason-ch Chen
2023-07-17 19:58 ` Krzysztof Kozlowski
2023-07-18 6:36 ` Jason-ch Chen (陳建豪)
2023-07-18 7:41 ` Krzysztof Kozlowski
2023-07-18 8:05 ` Jason-ch Chen (陳建豪)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=054014f207e24e1507199cd9833085346ed8cbd6.camel@mediatek.com \
--to=jason-ch.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®