From: "Johan Korsnes (jkorsnes)" <jkorsnes@cisco.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the hid tree
Date: Thu, 13 Feb 2020 06:28:52 +0000 [thread overview]
Message-ID: <05403763-3849-06ec-870e-c7e9c907714d@cisco.com> (raw)
In-Reply-To: <20200213074940.4fc25926@canb.auug.org.au>
On 2/12/20 9:49 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 5ebdffd25098 ("HID: core: fix off-by-one memset in hid_report_raw_event()")
>
> Fixes tag
>
> Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event()
>
> has these problem(s):
>
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>
Sorry about this. The checkpatch.pl script initially did complain
about the format of my commit references in v1:
"ERROR: Please use git commit description style"
But it only complained about number of characters in SHA, it did not
mention anything about line break. I will take care not to introduce
these line breaks in future commits, but it would be nice if
checkpatch.pl could check for this.
Johan
next prev parent reply other threads:[~2020-02-13 6:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 20:49 Stephen Rothwell
2020-02-13 6:28 ` Johan Korsnes (jkorsnes) [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-27 21:05 Stephen Rothwell
2024-06-06 21:47 Stephen Rothwell
2024-06-07 9:12 ` Benjamin Tissoires
2024-05-07 21:35 Stephen Rothwell
2024-05-08 7:10 ` Kenny Levinsen
2024-02-13 21:07 Stephen Rothwell
2023-01-26 22:39 Stephen Rothwell
2022-08-25 23:56 Stephen Rothwell
2022-08-28 10:14 ` José Expósito
2022-07-24 22:04 Stephen Rothwell
2022-03-14 11:09 Stephen Rothwell
2021-11-22 21:17 Stephen Rothwell
2021-11-22 22:59 ` Thomas Weißschuh
2021-05-05 22:21 Stephen Rothwell
2020-10-29 20:58 Stephen Rothwell
2020-04-29 22:06 Stephen Rothwell
2020-05-01 16:56 ` Jason Gerecke
2019-11-06 20:56 Stephen Rothwell
2019-08-19 15:19 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05403763-3849-06ec-870e-c7e9c907714d@cisco.com \
--to=jkorsnes@cisco.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®