From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbeAJT0Z (ORCPT + 1 other); Wed, 10 Jan 2018 14:26:25 -0500 Received: from mout.web.de ([212.227.17.12]:50351 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881AbeAJT0U (ORCPT ); Wed, 10 Jan 2018 14:26:20 -0500 Subject: [PATCH 2/7] VMCI: Improve a size determination in two functions From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton , Arnd Bergmann , Dan Carpenter , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Ingo Molnar , Masahiro Yamada Cc: LKML References: <2747f123-a95d-bc68-b858-0327dce3758b@users.sourceforge.net> Message-ID: <05412529-d0e2-0894-6229-431caa48c498@users.sourceforge.net> Date: Wed, 10 Jan 2018 20:25:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2747f123-a95d-bc68-b858-0327dce3758b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ypjtjrOflKlUuI3jlXqnidTezv94oZu0nGUWVS0ab2zGPacPZuc iXwsaUzw9vHUz4rG4Iv+gu2YJ+Aj7z/ik8lAkXM91FPmvdWVG+e2lJe932Eq9HuKPQ8Jsxb dFc7w4ZYjLU1uISDeo4ekItK19PYpzN5IRphHd7l2e/UzikQf/cIY91h++etZTVx7S64ZRm yOy1n15iqI+wHNuQHv9Lg== X-UI-Out-Filterresults: notjunk:1;V01:K0:cB9c1h7UigM=:YO4DijODOiOV6cujlx1zd0 mtg1dXfJGFl+JPdNk1n0fwwAW4wQWYm+dmeLwpi7k+8CEC/NRLsUSHwT+dYR1HhyarauoTiAI MhvpHP9ZBGWTGi4C8HQv2DX6UxMZtIgHTtGFbbT2bIYN8BcwldchOcFuaNSd/7NBeic06HEeM QbQFzJQhbhexmJQddo6IhGfKUhIM0hnAzt/uEsEFkgg7r4DogS9lLRB3wrShnjLh5+2SuV5xr tregrExjiAMWe2WEruXvJlfagYmixVpQ8/jTgMJQA1Gg99+vVniqnukTXAln8Zsgghaqe4kbX 1LDPxeekrOZ6YMUx/lYyyFKEnyYTKZHSv3f55CeFXWPEg8nuPTwFU9MeOVFx1rL9IkP17ev7k URe81TtqSCzb+LnAy791OcyyPl7wIBE2AK/2PDdMhWwE8mecBpySUfahN4tF6Z/JlAjGnlB8p Nqpnb947bLSZg29w+P4c2hSxQJ1fFesiBMMI/Lkr8zgqQgOS6NbjKu/ZfIDbIeLC7l69L9vXf 158CVEUwCK0K9JcxW0EfJxNFMmE18+3qPLtVgH6W2DgzaS+KUflBm4iNZVPlCjdoAUdfhwZBh eePhGYDRSMg/XO0SDo4ps3qExppHbhy+3w5J6P4QgKq9OzipOWIfG9JBFoA1/pVBUqsG/Je/b KOz8s9Nagsg9es1HGVEVr7aqNXUfCWWJiOgj8VR0NhDXhgTOcjFh2vMrz3MEZH0Eb19W93rAi ewygrDV/1kcwg6C5iKK4Tdcya5uevfkbdd45Ga/cVn6UIvQbHt47CHY7LAEaYgqpuypnWhg+0 GHm+x89lxu2UJl/WxrBS+eH+OR73D6rSSbrfHeLRxT6NHtE44k= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Wed, 10 Jan 2018 17:47:40 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/vmw_vmci/vmci_context.c | 2 +- drivers/misc/vmw_vmci/vmci_host.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_context.c b/drivers/misc/vmw_vmci/vmci_context.c index c0ea68255340..c7085ff76327 100644 --- a/drivers/misc/vmw_vmci/vmci_context.c +++ b/drivers/misc/vmw_vmci/vmci_context.c @@ -618,7 +618,7 @@ int vmci_ctx_add_notification(u32 context_id, u32 remote_cid) goto out; } - notifier = kmalloc(sizeof(struct vmci_handle_list), GFP_KERNEL); + notifier = kmalloc(sizeof(*notifier), GFP_KERNEL); if (!notifier) { result = VMCI_ERROR_NO_MEM; goto out; diff --git a/drivers/misc/vmw_vmci/vmci_host.c b/drivers/misc/vmw_vmci/vmci_host.c index 4246a033de18..14da8210fd34 100644 --- a/drivers/misc/vmw_vmci/vmci_host.c +++ b/drivers/misc/vmw_vmci/vmci_host.c @@ -124,7 +124,7 @@ static int vmci_host_open(struct inode *inode, struct file *filp) { struct vmci_host_dev *vmci_host_dev; - vmci_host_dev = kzalloc(sizeof(struct vmci_host_dev), GFP_KERNEL); + vmci_host_dev = kzalloc(sizeof(*vmci_host_dev), GFP_KERNEL); if (vmci_host_dev == NULL) return -ENOMEM; -- 2.15.1