From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D62BC3279B for ; Tue, 10 Jul 2018 06:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4892720843 for ; Tue, 10 Jul 2018 06:11:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4892720843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbeGJGLe (ORCPT ); Tue, 10 Jul 2018 02:11:34 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:44657 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751288AbeGJGJ6 (ORCPT ); Tue, 10 Jul 2018 02:09:58 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id B8C7E3639D645; Tue, 10 Jul 2018 14:09:53 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.382.0; Tue, 10 Jul 2018 14:09:52 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb To: Jaegeuk Kim , Chao Yu CC: , References: <20180707012020.4708-1-jaegeuk@kernel.org> <0cb1e0fd-1fb4-ba69-6c70-e05e991a243a@kernel.org> <20180709203624.GA24534@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <05429d14-a690-7f57-cde4-7fddadef241c@huawei.com> Date: Tue, 10 Jul 2018 14:09:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180709203624.GA24534@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/7/10 4:36, Jaegeuk Kim wrote: > On 07/09, Chao Yu wrote: >> On 2018/7/7 9:20, Jaegeuk Kim wrote: >>> When unmounting f2fs in force mode, we can get it stuck by io_schedule() >> >> force mode means force shutdown? > > Yes. > >> >>> by some pending IOs in meta_inode. >>> >>> io_schedule+0xd/0x30 >>> wait_on_page_bit_common+0xc6/0x130 >> >> Looks like a deadlock here? Does this mean we forget to submit cached bio in >> somewhere? > > I'm hitting this randomly, when running all the testcases in xfstests. > I can't find the missing flow, and only get this during kill_sb. I guess we need this before returning from ->writepage{,s}: if (is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) f2fs_submit_merged_write() How about trying this instead? Thanks, > >> >> Thanks, >> >>> __filemap_fdatawait_range+0xbd/0x100 >>> filemap_fdatawait_keep_errors+0x15/0x40 >>> sync_inodes_sb+0x1cf/0x240 >>> sync_filesystem+0x52/0x90 >>> generic_shutdown_super+0x1d/0x110 >>> ceph_kill_sb+0x28/0x80 [ceph] >>> deactivate_locked_super+0x35/0x60 >>> cleanup_mnt+0x36/0x70 >>> task_work_run+0x79/0xa0 >>> exit_to_usermode_loop+0x62/0x70 >>> do_syscall_64+0xdb/0xf0 >>> entry_SYSCALL_64_after_hwframe+0x44/0xa9 >>> 0xffffffffffffffff >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/super.c | 16 +++++++++++++--- >>> 1 file changed, 13 insertions(+), 3 deletions(-) >>> >>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>> index 3995e926ba3a..1dc6809fac38 100644 >>> --- a/fs/f2fs/super.c >>> +++ b/fs/f2fs/super.c >>> @@ -3089,9 +3089,19 @@ static struct dentry *f2fs_mount(struct file_system_type *fs_type, int flags, >>> static void kill_f2fs_super(struct super_block *sb) >>> { >>> if (sb->s_root) { >>> - set_sbi_flag(F2FS_SB(sb), SBI_IS_CLOSE); >>> - f2fs_stop_gc_thread(F2FS_SB(sb)); >>> - f2fs_stop_discard_thread(F2FS_SB(sb)); >>> + struct f2fs_sb_info *sbi = F2FS_SB(sb); >>> + >>> + set_sbi_flag(sbi, SBI_IS_CLOSE); >>> + f2fs_stop_gc_thread(sbi); >>> + f2fs_stop_discard_thread(sbi); >>> + >>> + if (is_sbi_flag_set(sbi, SBI_IS_DIRTY) || >>> + !is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) { >>> + struct cp_control cpc = { >>> + .reason = CP_UMOUNT, >>> + }; >>> + f2fs_write_checkpoint(sbi, &cpc); >>> + } >>> } >>> kill_block_super(sb); >>> } >>> > > . >