From: Kumar Gala <galak@kernel.crashing.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: i2c@lm-sensors.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] Copy mpc-i2c to preserve support for ARCH=ppc and allow changes on ARCH=powerpc
Date: Tue, 18 Dec 2007 09:53:28 -0600 [thread overview]
Message-ID: <054B7122-6815-4483-96FE-7B4098198FA1@kernel.crashing.org> (raw)
In-Reply-To: <20071218023915.8530.67500.stgit@terra.home>
On Dec 17, 2007, at 8:39 PM, Jon Smirl wrote:
> Temporarily copy the mpc-i2c driver to continue support for the ppc
> architecture until it is removed in mid-2008. This file should be
> deleted as part of ppc's final removal.
>
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
>
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
>
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
> ---
>
> arch/ppc/configs/TQM8540_defconfig | 2
> arch/ppc/configs/TQM8541_defconfig | 2
> arch/ppc/configs/TQM8555_defconfig | 2
> arch/ppc/configs/TQM8560_defconfig | 2
> arch/ppc/configs/mpc834x_sys_defconfig | 2
> arch/ppc/configs/mpc8540_ads_defconfig | 2
> arch/ppc/configs/mpc8548_cds_defconfig | 2
> arch/ppc/configs/mpc8555_cds_defconfig | 2
> arch/ppc/configs/mpc8560_ads_defconfig | 2
> drivers/i2c/busses/Kconfig | 16 +
> drivers/i2c/busses/Makefile | 1
> drivers/i2c/busses/i2c-mpc-ppc.c | 418 +++++++++++++++++++++++
> +++++++++
> 12 files changed, 443 insertions(+), 10 deletions(-)
> create mode 100644 drivers/i2c/busses/i2c-mpc-ppc.c
Nak.
Just ifdef the probe functionality in i2c-mpc.c based on
CONFIG_PPC_MERGE. Your patch set shows the reason you should do
this. You provide fixes to the error path handling, but only for i2c-
mpc.c and not i2c-mpc-ppc.c.
- k
next prev parent reply other threads:[~2007-12-18 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 2:39 [PATCH 0/7] Series to add device tree naming to i2c Jon Smirl
2007-12-18 2:39 ` [PATCH 1/7] Copy mpc-i2c to preserve support for ARCH=ppc and allow changes on ARCH=powerpc Jon Smirl
2007-12-18 15:53 ` Kumar Gala [this message]
2007-12-18 2:39 ` [PATCH 2/7] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2007-12-18 2:39 ` [PATCH 3/7] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2007-12-18 2:39 ` [PATCH 4/7] Clean up error returns Jon Smirl
2007-12-18 2:39 ` [PATCH 5/7] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2007-12-18 2:39 ` [PATCH 6/7] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2007-12-18 2:39 ` [PATCH 7/7] Makefile Jon Smirl
2007-12-18 2:43 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=054B7122-6815-4483-96FE-7B4098198FA1@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=i2c@lm-sensors.org \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®