From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC53C28CC5 for ; Wed, 5 Jun 2019 12:47:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E41B206DF for ; Wed, 5 Jun 2019 12:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Dm/RdGMR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727769AbfFEMr5 (ORCPT ); Wed, 5 Jun 2019 08:47:57 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:34886 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727600AbfFEMr5 (ORCPT ); Wed, 5 Jun 2019 08:47:57 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x55Clplb096622; Wed, 5 Jun 2019 07:47:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1559738871; bh=m+aTF9fbF05MfZ/qcMNkOezHIu4xmi21OJYFRSBBLKc=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=Dm/RdGMRwboWg+VwyGsaPcYwqQ7UZbssHe5yqhXEv6jkD0W+NtQWeFOZwcEPRr54n px/Au8zvMFOuvpTxsS07qgCvtgEd9Q88bqYaRlJh2dYBf7l3dbWVjnmVraWDIZDHmu VTKTM3c4dGZOac8qQ0QAzfZqRgWHcQKslAoIMGyc= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x55ClpxQ064739 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 5 Jun 2019 07:47:51 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 5 Jun 2019 07:47:51 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 5 Jun 2019 07:47:51 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x55Clop3086390; Wed, 5 Jun 2019 07:47:50 -0500 Subject: Re: [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible From: Dan Murphy To: Mark Brown CC: , , , , , References: <20190604174345.14841-1-dmurphy@ti.com> <20190604174345.14841-2-dmurphy@ti.com> <20190605100132.GL2456@sirena.org.uk> <7ba7a633-1a39-adcc-e942-12c0eb7c3b16@ti.com> Message-ID: <054c3715-e85f-e052-faf1-057bf3a67d45@ti.com> Date: Wed, 5 Jun 2019 07:47:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <7ba7a633-1a39-adcc-e942-12c0eb7c3b16@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark On 6/5/19 7:02 AM, Dan Murphy wrote: > Mark > > On 6/5/19 5:01 AM, Mark Brown wrote: >> On Tue, Jun 04, 2019 at 12:43:40PM -0500, Dan Murphy wrote: >>> The use of and enablement of the GPIO can be used across devices. >>> Use the enable_reg in the regulator descriptor for the register to >>> write. >>> >>> Signed-off-by: Dan Murphy >>> Signed-off-by: Jacek Anaszewski >>> --- >>> >>> v5 - No changes to the patch changes requested in this patch were >>> done in >>> patch 4 of this series - >>> https://lore.kernel.org/patchwork/patch/1077408/ >> I was expecting this patch to just be completely dropped?  It looks like >> the end result is very similar, we're still using enable_reg to get the >> register and I don't see new validation added in patch 4. > > I can squash patch 1 into 4. > > Also not sure what you mean by new validation. > Disregard I understand.  The patch is missing the validation code. > Please comment on patch 4 to what you are looking for > > Dan >